mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Celine Joy A. Capua" <celinejoy.capua@analog.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,  Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: regulator: Document the ltc7871 regulator
Date: Mon, 10 Feb 2025 09:37:21 +0100	[thread overview]
Message-ID: <20250210-melodic-lush-bettong-9de9d0@krzk-bin> (raw)
In-Reply-To: <20250210-staging-ltc7871-v1-2-c593ad86aab2@analog.com>

On Mon, Feb 10, 2025 at 10:30:53AM +0800, Celine Joy A. Capua wrote:
> The LTC7871 is a bidirectional buck or boost
> switching regulator controller that operates in
> either buck or boost mode on demand. Add
> corresponding DT bindings.

This fails tests, so limited review follows.


Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

Please use subject prefixes matching the subsystem. You can get them for
example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

> 
> Signed-off-by: Celine Joy A. Capua <celinejoy.capua@analog.com>
> ---
>  .../bindings/regulator/adi,ltc7871-regulator.yaml  | 98 ++++++++++++++++++++++
>  1 file changed, 98 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/adi,ltc7871-regulator.yaml b/Documentation/devicetree/bindings/regulator/adi,ltc7871-regulator.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..b1ae8b16e19c11b3faf2d4a41a4ae4f615ca3c1e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/adi,ltc7871-regulator.yaml
> @@ -0,0 +1,98 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (c) 2025 Analog Devices, Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/adi,ltc7871-regulator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices LTC7871 Buck-Boost Voltage Regulator

Blank line

> +maintainers:
> +  - Celine Joy Capua <celinejoy.capua@analog.com>
> +
> +description:
> +  The LTC7871 is a high performance bidirectional buck or boost switching
> +  regulator controller that operates in either buck or boost mode on demand.
> +  It regulates in buck mode from VHIGH-to-VLOW and boost mode from
> +  VLOW-to-VHIGH depending on a control signal, making it ideal for 48V/12V
> +  automotive dual battery systems

Blank line. Open existing bindings and see how it is done there.

> +properties:
> +  compatible:
> +    enum:
> +      - adi,ltc7871
> +      - adi,ltc7872

Are devices compatible?

> +
> +  reg:
> +    maxItems: 1
> +
> +  adi,enable-chip-ctrl-wp:
> +    description: If present, this indicates the use of regulator's
> +      internal write protection.
> +    type: boolean
> +
> +  adi,ra-external-ohms:
> +    description: External Resistor used to compute the value of
> +      programmable VLOW in buck mode.
> +    default: 10000
> +
> +  adi,rb-external-ohms:
> +    description: External Resistor used to compute the value of
> +      programmable VLOW in buck mode.
> +    default: 107000
> +
> +  adi,rc-external-ohms:
> +    description: External Resistor used to compute the value of
> +      programmable VHIGH in boost mode.
> +    default: 12700
> +
> +  adi,rd-external-ohms:
> +    description: External Resistor used to compute the value of
> +      programmable VHIGH in boost mode.
> +    default: 499000
> +
> +  adi,idac-setcur-microamp:
> +    description: Adjusts the IDAC_SETCUR to program SETCUR
> +      pin's sourcing current.
> +    minimum: -63
> +    maximum: 64
> +    default: 0
> +
> +  adi,freq-spread-percentage:
> +    description: Sets the range of modulation with respect to the
> +      switching frequency.
> +    enum: [+-12%, +-15%, +-10%, +-8%]

That's something new. Where is such property suffix defined?

> +    default: +-12%
> +
> +  adi,switching-freq-divider:
> +    description: The factor at which the switching frequency is
> +      divided to get the modulation frequency.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [512, 1024, 2048, 4096, 256, 128, 64]

Keep this ordered by increasing value.

> +    default: 512
> +
> +required:
> +  - compatible
> +  - reg

Best regards,
Krzysztof


      parent reply	other threads:[~2025-02-10  8:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-10  2:30 [PATCH 0/2] Add support for the LTC7871 voltage regulator Celine Joy A. Capua
2025-02-10  2:30 ` [PATCH 1/2] regulator: ltc7871: Add driver for LTC7871 Celine Joy A. Capua
2025-02-10  8:40   ` Krzysztof Kozlowski
2025-02-10 19:14   ` kernel test robot
2025-02-10  2:30 ` [PATCH 2/2] dt-bindings: regulator: Document the ltc7871 regulator Celine Joy A. Capua
2025-02-10  3:30   ` Rob Herring (Arm)
2025-02-10  8:37   ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250210-melodic-lush-bettong-9de9d0@krzk-bin \
    --to=krzk@kernel.org \
    --cc=broonie@kernel.org \
    --cc=celinejoy.capua@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®