mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Theil <theil.markus@gmail.com>
To: linux-kernel@vger.kernel.org, andi.shyti@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org, netdev@vger.kernel.org,
	Jason@zx2c4.com, tytso@mit.edu,
	Markus Theil <theil.markus@gmail.com>
Subject: [PATCH v2 3/3] prandom: remove next_pseudo_random32
Date: Tue, 11 Feb 2025 07:33:32 +0100	[thread overview]
Message-ID: <20250211063332.16542-4-theil.markus@gmail.com> (raw)
In-Reply-To: <20250211063332.16542-1-theil.markus@gmail.com>

next_pseudo_random32 implements a LCG with known bad statistical
properties and was only used in two pieces of testing code.

After the users are converted to prandom as part of this series,
remove the LCG here.

This removes another option of using an insecure PRNG.

Signed-off-by: Markus Theil <theil.markus@gmail.com>
---
 include/linux/prandom.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/include/linux/prandom.h b/include/linux/prandom.h
index f2ed5b72b3d6..ff7dcc3fa105 100644
--- a/include/linux/prandom.h
+++ b/include/linux/prandom.h
@@ -47,10 +47,4 @@ static inline void prandom_seed_state(struct rnd_state *state, u64 seed)
 	state->s4 = __seed(i, 128U);
 }
 
-/* Pseudo random number generator from numerical recipes. */
-static inline u32 next_pseudo_random32(u32 seed)
-{
-	return seed * 1664525 + 1013904223;
-}
-
 #endif
-- 
2.47.2


  parent reply	other threads:[~2025-02-11  6:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-10 13:35 [PATCH] " Markus Theil
2025-02-10 13:39 ` Jason A. Donenfeld
2025-02-10 23:07   ` Andi Shyti
2025-02-11  6:13     ` Markus Theil
2025-02-11  6:33   ` [PATCH v2 0/3] " Markus Theil
2025-02-11  6:33     ` [PATCH v2 1/3] drm/i915/selftests: use prandom in selftest Markus Theil
2025-02-13 17:19       ` Andi Shyti
2025-03-19 17:13         ` Jason A. Donenfeld
2025-03-21 12:37           ` Jani Nikula
2025-03-21 12:52             ` Jason A. Donenfeld
2025-02-11  6:33     ` [PATCH v2 2/3] media: vivid: use prandom Markus Theil
2025-02-11  6:33     ` Markus Theil [this message]
2025-02-13 14:27     ` [PATCH v2 0/3] prandom: remove next_pseudo_random32 Krzysztof Karas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250211063332.16542-4-theil.markus@gmail.com \
    --to=theil.markus@gmail.com \
    --cc=Jason@zx2c4.com \
    --cc=andi.shyti@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®