From: Eric Biggers <ebiggers@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: linux-crypto@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
x86@kernel.org
Subject: Re: [PATCH] x86/crc32: improve crc32c_arch() code generation with clang
Date: Wed, 12 Feb 2025 12:10:22 -0800 [thread overview]
Message-ID: <20250212201022.GB128826@sol.localdomain> (raw)
In-Reply-To: <20250210210741.471725-1-ebiggers@kernel.org>
On Mon, Feb 10, 2025 at 01:07:41PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> crc32c_arch() is affected by
> https://github.com/llvm/llvm-project/issues/20571 where clang
> unnecessarily spills the inputs to "rm"-constrained operands to the
> stack. Replace "rm" with ASM_INPUT_RM which partially works around this
> by expanding to "r" when the compiler is clang. This results in better
> code generation with clang, though still not optimal.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
>
> This applies to
> https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=crc-next
Applied to crc-next.
- Eric
prev parent reply other threads:[~2025-02-12 20:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 21:07 Eric Biggers
2025-02-12 20:10 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250212201022.GB128826@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=ardb@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®