From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Ferry Toth <fntoth@gmail.com>
Subject: Re: [PATCH v2 2/3] usb: dwc3: gadget: Add support for snps,reserved-endpoints property
Date: Thu, 13 Feb 2025 01:16:15 +0000 [thread overview]
Message-ID: <20250213011610.ov3q2rq6bfzdzqlk@synopsys.com> (raw)
In-Reply-To: <Z6x5lB4hGpz-9IzS@smile.fi.intel.com>
On Wed, Feb 12, 2025, Andy Shevchenko wrote:
> On Wed, Feb 12, 2025 at 01:10:17AM +0000, Thinh Nguyen wrote:
> > On Mon, Feb 03, 2025, Andy Shevchenko wrote:
> > > The snps,reserved-endpoints property lists the reserved endpoints
> > > that shouldn't be used for normal transfers. Add support for that
> > > to the driver.
>
> > > While at it, make sure we don't crash by a sudden access to those
> > > endpoints in the gadget driver.
>
> ^^^ (1)
>
> ...
>
> > > /* Reset resource allocation flags */
> > > - for (i = resource_index; i < dwc->num_eps && dwc->eps[i]; i++)
> > > - dwc->eps[i]->flags &= ~DWC3_EP_RESOURCE_ALLOCATED;
> > > + for (i = resource_index; i < dwc->num_eps; i++) {
> > > + dep = dwc->eps[i];
> > > + if (!dep)
> > > + continue;
> > > +
> > > + dep->flags &= ~DWC3_EP_RESOURCE_ALLOCATED;
> > > + }
> >
> > Please keep code refactoring as a separate patch.
>
> It's induced by the change you asked for, it's not a simple refactoring.
>
> Or do you want me to have the patch to check eps against NULL to be separated
> from this one (see (1) above)?
The condition "i < dwc->num && dwc->eps[i]" already does the NULL check.
The change here only move things around.
>
> > >
> > > return 0;
>
> ...
>
> > > +static int dwc3_gadget_parse_reserved_endpoints(struct dwc3 *dwc, const char *propname,
> > > + u8 *eps, u8 num)
> > > +{
> > > + u8 count;
> > > + int ret;
> > > +
> > > + if (!device_property_present(dwc->dev, propname))
> > > + return 0;
> > > +
> > > + ret = device_property_count_u8(dwc->dev, propname);
> > > + if (ret < 0)
> > > + return ret;
> > > + count = ret;
> > > +
> > > + ret = device_property_read_u8_array(dwc->dev, propname, eps, min(num, count));
> >
> > Why do min(num, count)? Can we just put the size of the eps array as
> > specified by the function doc.
>
> No, we can't ask more than there is. The call will fail in such a case.
> In case you wonder, the similar OF call also behaves in the same way.
Yeah, I realized that right after I wrote the comment and responded
after.
BR,
Thinh
next prev parent reply other threads:[~2025-02-13 1:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 19:10 [PATCH v2 0/3] usb: dwc3: Avoid using reserved EPs Andy Shevchenko
2025-02-03 19:10 ` [PATCH v2 1/3] dt-bindings: usb: dwc3: Add a property to reserve endpoints Andy Shevchenko
2025-02-03 23:05 ` Rob Herring (Arm)
2025-02-03 19:10 ` [PATCH v2 2/3] usb: dwc3: gadget: Add support for snps,reserved-endpoints property Andy Shevchenko
2025-02-12 1:10 ` Thinh Nguyen
2025-02-12 1:13 ` Thinh Nguyen
2025-02-12 10:36 ` Andy Shevchenko
2025-02-12 18:58 ` Andy Shevchenko
2025-02-13 1:17 ` Thinh Nguyen
2025-02-13 8:07 ` Andy Shevchenko
2025-02-13 1:16 ` Thinh Nguyen [this message]
2025-02-13 1:25 ` Thinh Nguyen
2025-02-13 8:02 ` Andy Shevchenko
2025-02-03 19:10 ` [PATCH v2 3/3] usb: dwc3: gadget: Avoid using reserved endpoints on Intel Merrifield Andy Shevchenko
2025-02-11 0:23 ` Thinh Nguyen
2025-02-10 19:23 ` [PATCH v2 0/3] usb: dwc3: Avoid using reserved EPs Ferry Toth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213011610.ov3q2rq6bfzdzqlk@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=balbi@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fntoth@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®