mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <leitao@debian.org>
Cc: <andrew+netdev@lunn.ch>, <davem@davemloft.net>,
	<dsahern@kernel.org>, <edumazet@google.com>,
	<eric.dumazet@gmail.com>, <horms@kernel.org>, <kuba@kernel.org>,
	<kuniyu@amazon.co.jp>, <kuniyu@amazon.com>,
	<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
	<pabeni@redhat.com>, <ushankar@purestorage.com>
Subject: Re: [PATCH net v4 1/2] net: Add non-RCU dev_getbyhwaddr() helper
Date: Fri, 14 Feb 2025 14:49:33 +0900	[thread overview]
Message-ID: <20250214054933.62409-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20250213-arm_fix_selftest-v4-1-26714529a6cf@debian.org>

From: Breno Leitao <leitao@debian.org>
Date: Thu, 13 Feb 2025 04:42:37 -0800
> Add dedicated helper for finding devices by hardware address when
> holding rtnl_lock, similar to existing dev_getbyhwaddr_rcu(). This prevents
> PROVE_LOCKING warnings when rtnl_lock is held but RCU read lock is not.
> 
> Extract common address comparison logic into dev_comp_addr().
> 
> The context about this change could be found in the following
> discussion:
> 
> Link: https://lore.kernel.org/all/20250206-scarlet-ermine-of-improvement-1fcac5@leitao/
> 
> Cc: kuniyu@amazon.com
> Cc: ushankar@purestorage.com
> Suggested-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Breno Leitao <leitao@debian.org>

Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>

Thanks!

  reply	other threads:[~2025-02-14  5:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-13 12:42 [PATCH net v4 0/2] net: core: improvements to device lookup by hardware address Breno Leitao
2025-02-13 12:42 ` [PATCH net v4 1/2] net: Add non-RCU dev_getbyhwaddr() helper Breno Leitao
2025-02-14  5:49   ` Kuniyuki Iwashima [this message]
2025-02-18  0:32   ` Jakub Kicinski
2025-02-13 12:42 ` [PATCH net v4 2/2] arp: switch to dev_getbyhwaddr() in arp_req_set_public() Breno Leitao
2025-02-18  0:33   ` Jakub Kicinski
2025-02-18  9:36     ` Breno Leitao
2025-02-18 14:29       ` Jakub Kicinski
2025-02-18 16:27         ` Breno Leitao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250214054933.62409-1-kuniyu@amazon.com \
    --to=kuniyu@amazon.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@amazon.co.jp \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ushankar@purestorage.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®