From: Siddh Raman Pant <siddh.raman.pant@oracle.com>
To: Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>
Cc: netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [RFC PATCH] netlink: Unset cb_running when terminating dump on release.
Date: Fri, 14 Feb 2025 12:28:49 +0530 [thread overview]
Message-ID: <20250214065849.28983-1-siddh.raman.pant@oracle.com> (raw)
When we terminated the dump, the callback isn't running, so cb_running
should be set to false to be logically consistent.
Fixes: 1904fb9ebf91 ("netlink: terminate outstanding dump on socket close")
Fixes: 16b304f3404f ("netlink: Eliminate kmalloc in netlink dump operation.")
Signed-off-by: Siddh Raman Pant <siddh.raman.pant@oracle.com>
---
I found this by inspection and was thinking why it isn't being done. So
I thought I should ask by sending a patch.
net/netlink/af_netlink.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 85311226183a..f8f13058a46e 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -771,6 +771,7 @@ static int netlink_release(struct socket *sock)
nlk->cb.done(&nlk->cb);
module_put(nlk->cb.module);
kfree_skb(nlk->cb.skb);
+ WRITE_ONCE(nlk->cb_running, false);
}
module_put(nlk->module);
--
2.45.2
next reply other threads:[~2025-02-14 6:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 6:58 Siddh Raman Pant [this message]
2025-02-15 1:06 ` Jakub Kicinski
2025-02-15 9:40 ` [PATCH] " Siddh Raman Pant
2025-02-19 2:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250214065849.28983-1-siddh.raman.pant@oracle.com \
--to=siddh.raman.pant@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®