mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nick Child <nnac123@linux.ibm.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: haren@linux.ibm.com, ricklind@us.ibm.com, nick.child@ibm.com,
	jacob.e.keller@intel.com, horms@kernel.org,
	Nick Child <nnac123@linux.ibm.com>
Subject: [PATCH v2 2/3] hexdump: Use for_each macro in print_hex_dump
Date: Fri, 14 Feb 2025 10:24:35 -0600	[thread overview]
Message-ID: <20250214162436.241359-3-nnac123@linux.ibm.com> (raw)
In-Reply-To: <20250214162436.241359-1-nnac123@linux.ibm.com>

The looping logic in print_hex_dump can be handled by the macro
for_each_line_in_hex_dump.

Signed-off-by: Nick Child <nnac123@linux.ibm.com>
---
 lib/hexdump.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/lib/hexdump.c b/lib/hexdump.c
index c3db7c3a7643..181b82dfe40d 100644
--- a/lib/hexdump.c
+++ b/lib/hexdump.c
@@ -263,19 +263,14 @@ void print_hex_dump(const char *level, const char *prefix_str, int prefix_type,
 		    const void *buf, size_t len, bool ascii)
 {
 	const u8 *ptr = buf;
-	int i, linelen, remaining = len;
+	int i;
 	unsigned char linebuf[32 * 3 + 2 + 32 + 1];
 
 	if (rowsize != 16 && rowsize != 32)
 		rowsize = 16;
 
-	for (i = 0; i < len; i += rowsize) {
-		linelen = min(remaining, rowsize);
-		remaining -= rowsize;
-
-		hex_dump_to_buffer(ptr + i, linelen, rowsize, groupsize,
-				   linebuf, sizeof(linebuf), ascii);
-
+	for_each_line_in_hex_dump(i, rowsize, linebuf, sizeof(linebuf),
+				  groupsize, buf, len) {
 		switch (prefix_type) {
 		case DUMP_PREFIX_ADDRESS:
 			printk("%s%s%p: %s\n",
-- 
2.48.0


  parent reply	other threads:[~2025-02-14 16:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-14 16:24 [PATCH v2 0/3] Use new for_each macro to create hexdumps Nick Child
2025-02-14 16:24 ` [PATCH 1/3] hexdump: Implement macro for converting large buffers Nick Child
     [not found]   ` <87tt8wflt5.fsf@linux.ibm.com>
2025-02-14 18:33     ` Nick Child
2025-02-15 16:36   ` Simon Horman
2025-02-15 17:40     ` David Laight
2025-02-15 17:46       ` David Laight
2025-02-16  9:32         ` Simon Horman
2025-02-16 11:24           ` David Laight
2025-02-17 15:09             ` Nick Child
2025-02-18 12:31               ` Paolo Abeni
2025-02-14 16:24 ` Nick Child [this message]
2025-02-14 16:24 ` [PATCH v2 3/3] ibmvnic: Print data buffers with kernel API's Nick Child

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250214162436.241359-3-nnac123@linux.ibm.com \
    --to=nnac123@linux.ibm.com \
    --cc=haren@linux.ibm.com \
    --cc=horms@kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nick.child@ibm.com \
    --cc=ricklind@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®