From: Fedor Pchelkin <boddah8794@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Fedor Pchelkin <boddah8794@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
"Christian A. Ehrhardt" <lk@c--e.de>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Benson Leung <bleung@chromium.org>,
Jameson Thies <jthies@google.com>,
Saranya Gopal <saranya.gopal@intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Mark Pearson <mpearson@squebb.ca>
Subject: [PATCH 0/2] usb: typec: ucsi: avoid problems during initial PPM reset
Date: Mon, 17 Feb 2025 13:54:38 +0300 [thread overview]
Message-ID: <20250217105442.113486-1-boddah8794@gmail.com> (raw)
The first patch of the series is intended to fix a "WARNING in
ucsi_reset_ppm()" reported in mailing lists [1], in bugzilla [2] and
distro-specific bug-trackers [3]. I've got the same splat rather
frequently occuring on my system so took the patch [4] proposed by
Christian for testing.
The second patch is all about timeout issues during the initial PPM reset
attempt which I observe every time booting my Lenovo laptop (I'm not an
active UCSI user so didn't pay attention to them before but saw this
problem while poking around with the patch for WARNING). The timeout issue
is not a recent regression and it is reproduced on my laptop back to v5.12
at least. That said, this timeout also sometimes leads to the WARNING in
question because it is used for polling the CCI value there as well.
Link to the initial RFC version [5] with comments and reviews.
[1]: https://lore.kernel.org/linux-usb/Z18hJM55ED2hYJ6D@lappy/
[2]: https://bugzilla.kernel.org/show_bug.cgi?id=219590
[3]: https://retrace.fedoraproject.org/faf/reports/1113325/
[4]: https://lore.kernel.org/linux-usb/Z2Cf1AI8CXao5ZAn@cae.in-ulm.de/
[5]: https://lore.kernel.org/linux-usb/20250206184327.16308-1-boddah8794@gmail.com/
Christian A. Ehrhardt (1):
acpi: typec: ucsi: Introduce a ->poll_cci method
Fedor Pchelkin (1):
usb: typec: ucsi: increase timeout for PPM reset operations
drivers/usb/typec/ucsi/ucsi.c | 12 ++++++------
drivers/usb/typec/ucsi/ucsi.h | 2 ++
drivers/usb/typec/ucsi/ucsi_acpi.c | 21 ++++++++++++++-------
drivers/usb/typec/ucsi/ucsi_ccg.c | 1 +
drivers/usb/typec/ucsi/ucsi_glink.c | 1 +
drivers/usb/typec/ucsi/ucsi_stm32g0.c | 1 +
drivers/usb/typec/ucsi/ucsi_yoga_c630.c | 1 +
7 files changed, 26 insertions(+), 13 deletions(-)
--
2.48.1
next reply other threads:[~2025-02-17 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 10:54 Fedor Pchelkin [this message]
2025-02-17 10:54 ` [PATCH 1/2] acpi: typec: ucsi: Introduce a ->poll_cci method Fedor Pchelkin
2025-02-17 10:54 ` [PATCH 2/2] usb: typec: ucsi: increase timeout for PPM reset operations Fedor Pchelkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250217105442.113486-1-boddah8794@gmail.com \
--to=boddah8794@gmail.com \
--cc=bleung@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jthies@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lk@c--e.de \
--cc=mpearson@squebb.ca \
--cc=saranya.gopal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®