From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3AD4224F0 for ; Mon, 17 Feb 2025 21:56:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739829374; cv=none; b=CznWp5NnAAwfERAxqIabaxNpKKTdED9c4vkyLBY55Q710UCDCjAEM8OUaCrZFiaFLfxhjyJlAXWmwBUF3ohlsGzPdHn21zw0DqCsyAkmJoX/Oo3UsYhVtnD+lfz+qT7Xt2zTnppK0DDIK3p/wTGphMmEtOAAYb4AB4v1U1w7wVw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739829374; c=relaxed/simple; bh=N2pCvbsInOvtXuv75JS94lrc9pN+Og0+y7iXDBWGipE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QDLZWbjpcvFl13F0RQNOvb+dih1PwWdYGbUytDp8KEHceORiXbmHVa6ANCzQVMB4KROLtm9xujX0Cp5a/vKSFPAPApsQVyfKDuAXLwTD8YbCUMBzSx4CHhox8d+NhNZ8Eph6IpmrkoAsUnu38kQdN6ixDj4EbrcYL9a/4cl1fYI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YPLLW8EX; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YPLLW8EX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739829371; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ma+WDCstUob+rO5FJpLhVsCO991W7dWOQMuhns1ORLM=; b=YPLLW8EXZk3IEf82KnfiS7UcC7uYmiGx76757P2FSZ/jb7+Td9VopOitXA9QEhJ9rgq5CU 4SLWz8cDOEgtTUqd6zFMVgHU5MqmYOYEyZ05iyTn/AtP+NUzH93z6fzPiLh2271dY9F/y8 +TIPkMAyLyXypjccku+RxaFZ+d/R5jQ= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-hL-ww40APjOMaKR-tiJvWw-1; Mon, 17 Feb 2025 16:56:10 -0500 X-MC-Unique: hL-ww40APjOMaKR-tiJvWw-1 X-Mimecast-MFC-AGG-ID: hL-ww40APjOMaKR-tiJvWw_1739829370 Received: by mail-il1-f198.google.com with SMTP id e9e14a558f8ab-3cffc88f0cbso3048775ab.0 for ; Mon, 17 Feb 2025 13:56:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739829370; x=1740434170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ma+WDCstUob+rO5FJpLhVsCO991W7dWOQMuhns1ORLM=; b=rMX4UojaJY+cq6+lD78DXKVrL+np4eceEBe24o9j1w2+nQyePgXolrwb095P2bjgHg F4XS+bzbQ4DKP3KQfhAaT83yYtxwsnN6VD8rQJP0kXsgE75lnaslgk8cUa8qvut6iNou vrBSLxIHwFPL0gUgVd8CxuwW7fRL2/8TaXyzZbu3fuv3x/Y+5/IM6eMmXcVnEnaPtMMX zPNaEuhQEdn806tYGQXockyJRu1QTSHAHfZ5YXZ12zyMu4cthH8gD2toj1BEid5ZXXcp eKf9RY4H3FbpWIH9ilSj3u0W34DNX082PkodDqs5NmD5c/EL0Y3DeiU9PIJNdnJM+NxC VAaQ== X-Forwarded-Encrypted: i=1; AJvYcCU24qfBNDkKHygYq0ulHgUeGi8FjSox6hMuiJ9cwUVs/l1a35Tt6K0CNt0zEBwdfZTYI/mNMdrzYE3EFz8=@vger.kernel.org X-Gm-Message-State: AOJu0YytPYEwDEzCcN+GydLfEemFWqCj+rMY2Zxv7LBk5Prwv+JqgIiG xBqkHvsZyTSRR7uEWOahFIFkFNZgv9+XBBryvGNcbwgcwxsbJ5n99IQYGA+4ToKqywUgjZO+BHa 6a8xgXeWV0O9eD9SqKULEygzw1k1SsB98yqxFdEr8D1uDdMq72YhQoB+/YthIoQ== X-Gm-Gg: ASbGnctK+sJ1eopYPaactWttqnzX0yv6962PQdn+shofk+vGW5pMV20qcQF/Lek4gBr XycGucf/ksScKPWEj6Ci5QobG9N8kJYrttQjgpKbdJGGPCdZPdOUf4K+mEQ29vEwZEENvdiC5Tl DGykbs3CszNj30cXyjZ2cj+AqZtteZNBu6B4Ua9WoYePYRWRKPHDn7e7e/BEl49DDETh2+qB6Wq RYjFyui+UL57Gmv1r+l8GAq8gO91c/glMQ4CSlWMQh6Jy3eJIdmUqiNHf6PGoDpV7iuNG22oR8C 5ccblVqS X-Received: by 2002:a05:6602:13d4:b0:855:683d:d468 with SMTP id ca18e2360f4ac-85579fe5006mr245136939f.0.1739829369723; Mon, 17 Feb 2025 13:56:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IGnC63RTWm/9A8auCeEObZ+CHD/OXQEjDxR7vyZ9cE6BFwEm2a2tfvMMhgn6LJkud3CRBJDvw== X-Received: by 2002:a05:6602:13d4:b0:855:683d:d468 with SMTP id ca18e2360f4ac-85579fe5006mr245135939f.0.1739829369431; Mon, 17 Feb 2025 13:56:09 -0800 (PST) Received: from redhat.com ([38.15.36.11]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ee82c8d5b0sm1436012173.120.2025.02.17.13.56.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 13:56:08 -0800 (PST) Date: Mon, 17 Feb 2025 14:56:06 -0700 From: Alex Williamson To: David Hildenbrand Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, peterx@redhat.com, mitchell.augustin@canonical.com, clg@redhat.com, akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH 4/5] mm: Provide page mask in struct follow_pfnmap_args Message-ID: <20250217145606.22b95d9b.alex.williamson@redhat.com> In-Reply-To: References: <20250205231728.2527186-1-alex.williamson@redhat.com> <20250205231728.2527186-5-alex.williamson@redhat.com> <20250214101735.4b180123.alex.williamson@redhat.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 14 Feb 2025 22:39:30 +0100 David Hildenbrand wrote: > On 14.02.25 18:17, Alex Williamson wrote: > > > > Nudge. Peter Xu provided an R-b for the series. Would any other mm > > folks like to chime in here to provide objection or approval for this > > change and merging it through the vfio tree? Series[1]. Thanks! > > > > Only skimmed over it, nothing jumped at me except ... > > Nitpicking: > > I was wondering if "page mask" really the right term here. I know that > we use it in some context (gup, hugetlb, zeropage) to express "mask this > off and you get the start of the aligned huge page". > > For something that walks PFNMAPs (page frames without any real "huge > page" logical metadata etc. grouping) it was uintuitive for me at first. > > addr_mask or pfn_mask (shifted addr_mask) would have been clearer for me. > > No strong opinion, just what came to mind while reading this ... It's called addr_mask in pfnmap_args_setup() so I'm happy to keep that naming if pgmask is less intuitive. Thanks, Alex