From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Gabriele Monaco <gmonaco@redhat.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-trace-kernel@vger.kernel.org,
Juri Lelli <juri.lelli@redhat.com>
Subject: Re: [PATCH v2 03/11] sched: Add sched tracepoints for RV task model
Date: Mon, 17 Feb 2025 17:49:17 +0100 [thread overview]
Message-ID: <20250217164917.GB40464@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20250217113844.5ad7893c@gandalf.local.home>
On Mon, Feb 17, 2025 at 11:38:44AM -0500, Steven Rostedt wrote:
> > +void __do_trace_set_current_state(int state_value)
> > +{
> > + __do_trace_sched_set_state_tp(current, current->__state, state_value);
>
> And this should not be using the internal macros of a trace point. It should be:
>
> trace_sched_set_state_tp(current, state_value);
>
> (I removed the current->__state as mentioned above).
But the static branch is already in the caller, no point duplicating
that.
next prev parent reply other threads:[~2025-02-17 16:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 9:07 [PATCH v2 00/11] rv: Add scheduler specification monitors Gabriele Monaco
2025-02-13 9:07 ` [PATCH v2 01/11] tracing: Fix DECLARE_TRACE_CONDITION Gabriele Monaco
2025-02-13 9:08 ` [PATCH v2 02/11] rv: Add license identifiers to monitor files Gabriele Monaco
2025-02-13 9:08 ` [PATCH v2 03/11] sched: Add sched tracepoints for RV task model Gabriele Monaco
2025-02-14 8:00 ` kernel test robot
2025-02-14 11:15 ` Gabriele Monaco
2025-02-17 16:39 ` Steven Rostedt
2025-02-14 9:52 ` kernel test robot
2025-02-17 16:38 ` Steven Rostedt
2025-02-17 16:49 ` Peter Zijlstra [this message]
2025-02-17 17:16 ` Steven Rostedt
2025-02-18 7:06 ` Gabriele Monaco
2025-02-13 9:08 ` [PATCH v2 04/11] rv: Add option for nested monitors and include sched Gabriele Monaco
2025-02-16 22:39 ` kernel test robot
2025-02-17 6:56 ` Gabriele Monaco
2025-02-13 9:08 ` [PATCH v2 05/11] rv: Add sco and tss per-cpu monitors Gabriele Monaco
2025-02-13 9:08 ` [PATCH v2 06/11] rv: Add snroc per-task monitor Gabriele Monaco
2025-02-13 9:08 ` [PATCH v2 07/11] rv: Add scpd, snep and sncid per-cpu monitors Gabriele Monaco
2025-02-13 9:08 ` [PATCH v2 08/11] tools/rv: Add support for nested monitors Gabriele Monaco
2025-02-13 9:08 ` [PATCH v2 09/11] verification/dot2k: " Gabriele Monaco
2025-02-13 9:08 ` [PATCH v2 10/11] Documentation/rv: Add docs for the sched monitors Gabriele Monaco
2025-02-13 9:08 ` [PATCH v2 11/11] tools/rv: Allow rv list to filter for container Gabriele Monaco
2025-02-17 13:11 [PATCH v2 00/11] rv: Add scheduler specification monitors Gabriele Monaco
2025-02-17 13:11 ` [PATCH v2 03/11] sched: Add sched tracepoints for RV task model Gabriele Monaco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250217164917.GB40464@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=gmonaco@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®