From: Leo Yan <leo.yan@arm.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
James Clark <james.clark@linaro.org>,
Mike Leach <mike.leach@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
Will Deacon <will@kernel.org>,
Graham Woodward <graham.woodward@arm.com>,
Paschalis.Mpeis@arm.com, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Leo Yan <leo.yan@arm.com>
Subject: [PATCH v3 10/12] perf arm-spe: Set sample flags with supplement info
Date: Mon, 17 Feb 2025 19:59:06 +0000 [thread overview]
Message-ID: <20250217195908.176207-11-leo.yan@arm.com> (raw)
In-Reply-To: <20250217195908.176207-1-leo.yan@arm.com>
Based on the supplement information in the record, this commit sets the
sample flags for conditional branch, function call, return. It also
sets events in flags, such as mispredict, not taken, and in transaction.
Reviewed-by: Ian Rogers <irogers@google.com>
Reviewed-by: James Clark <james.clark@linaro.org>
Signed-off-by: Leo Yan <leo.yan@arm.com>
---
tools/perf/util/arm-spe.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c
index 0e8e05c87fd7..daecf9e1017a 100644
--- a/tools/perf/util/arm-spe.c
+++ b/tools/perf/util/arm-spe.c
@@ -484,6 +484,26 @@ static void arm_spe__sample_flags(struct arm_spe_queue *speq)
if (record->type & ARM_SPE_BRANCH_MISS)
speq->flags |= PERF_IP_FLAG_BRANCH_MISS;
+
+ if (record->type & ARM_SPE_BRANCH_NOT_TAKEN)
+ speq->flags |= PERF_IP_FLAG_NOT_TAKEN;
+
+ if (record->type & ARM_SPE_IN_TXN)
+ speq->flags |= PERF_IP_FLAG_IN_TX;
+
+ if (record->op & ARM_SPE_OP_BR_COND)
+ speq->flags |= PERF_IP_FLAG_CONDITIONAL;
+
+ if (record->op & ARM_SPE_OP_BR_CR_BL)
+ speq->flags |= PERF_IP_FLAG_CALL;
+ else if (record->op & ARM_SPE_OP_BR_CR_RET)
+ speq->flags |= PERF_IP_FLAG_RETURN;
+ /*
+ * Indirect branch instruction without link (e.g. BR),
+ * take it as a function return.
+ */
+ else if (record->op & ARM_SPE_OP_BR_INDIRECT)
+ speq->flags |= PERF_IP_FLAG_RETURN;
}
}
--
2.34.1
next prev parent reply other threads:[~2025-02-17 19:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 19:58 [PATCH v3 00/12] perf script: Refactor branch flags for Arm SPE Leo Yan
2025-02-17 19:58 ` [PATCH v3 01/12] perf script: Make printing flags reliable Leo Yan
2025-03-03 10:44 ` Adrian Hunter
2025-03-03 16:22 ` Leo Yan
2025-03-03 15:05 ` Adrian Hunter
2025-03-03 18:11 ` Leo Yan
2025-03-03 16:56 ` Adrian Hunter
2025-03-03 18:49 ` Leo Yan
2025-02-17 19:58 ` [PATCH v3 02/12] perf script: Refactor sample_flags_to_name() function Leo Yan
2025-02-17 19:58 ` [PATCH v3 03/12] perf script: Separate events from branch types Leo Yan
2025-02-17 19:59 ` [PATCH v3 04/12] perf script: Add not taken event for branches Leo Yan
2025-02-17 19:59 ` [PATCH v3 05/12] perf script: Add not taken event for branch stack Leo Yan
2025-02-17 19:59 ` [PATCH v3 06/12] perf arm-spe: Fix load-store operation checking Leo Yan
2025-02-26 13:33 ` James Clark
2025-02-17 19:59 ` [PATCH v3 07/12] perf arm-spe: Extend branch operations Leo Yan
2025-02-17 19:59 ` [PATCH v3 08/12] perf arm-spe: Decode transactional event Leo Yan
2025-02-17 19:59 ` [PATCH v3 09/12] perf arm-spe: Fill branch operations and events to record Leo Yan
2025-02-17 19:59 ` Leo Yan [this message]
2025-02-17 19:59 ` [PATCH v3 11/12] perf arm-spe: Add branch stack Leo Yan
2025-02-17 19:59 ` [PATCH v3 12/12] perf arm-spe: Support previous branch target (PBT) address Leo Yan
2025-03-03 9:38 ` [PATCH v3 00/12] perf script: Refactor branch flags for Arm SPE Leo Yan
2025-03-03 21:00 ` Namhyung Kim
2025-03-04 11:33 ` Leo Yan
2025-03-04 18:43 ` Namhyung Kim
2025-03-05 9:53 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250217195908.176207-11-leo.yan@arm.com \
--to=leo.yan@arm.com \
--cc=Paschalis.Mpeis@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=graham.woodward@arm.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=namhyung@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®