From: Andy Yan <andyshrk@163.com>
To: heiko@sntech.de
Cc: hjc@rock-chips.com, krzk+dt@kernel.org,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
derek.foreman@collabora.com, detlev.casanova@collabora.com,
daniel@fooishbar.org, robh@kernel.org,
sebastian.reichel@collabora.com,
Andy Yan <andy.yan@rock-chips.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH v15 12/13] dt-bindings: display: vop2: Add rk3576 support
Date: Tue, 18 Feb 2025 19:28:46 +0800 [thread overview]
Message-ID: <20250218112848.34535-1-andyshrk@163.com> (raw)
In-Reply-To: <20250218112744.34433-1-andyshrk@163.com>
From: Andy Yan <andy.yan@rock-chips.com>
Add vop found on rk3576, the main difference between rk3576 and the
previous vop is that each VP has its own interrupt line.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
(no changes since v13)
Changes in v13:
- Use maxItems constraint for clocks in allOf block
Changes in v12:
- Split from patch 10/13
Changes in v11:
- Remove redundant min/maxItems constraint
Changes in v10:
- Move interrupt-names back to top level
- Add constraint of interrupts for all platform
- Add constraint for all grf phandles
- Reorder some properties
Changes in v9:
- Drop 'vop-' prefix of interrupt-names.
- Add blank line between DT properties
- Remove list interrupt-names in top level
Changes in v8:
- Fix dt_binding_check errors
- ordered by soc name
- Link to the previous version:
https://lore.kernel.org/linux-rockchip/6pn3qjxotdtpzucpul24yro7ppddezwuizneovqvmgdwyv2j7p@ztg4mqyiqmjf/T/#u
Changes in v4:
- describe constraint SOC by SOC, as interrupts of rk3576 is very
different from others
- Drop Krzysztof's Reviewed-by, as this version changed a lot.
Changes in v3:
- ordered by soc name
- Add description for newly added interrupt
Changes in v2:
- Add dt bindings
.../display/rockchip/rockchip-vop2.yaml | 61 ++++++++++++++++++-
1 file changed, 58 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
index 083eadcf0588..f546d481b7e5 100644
--- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
+++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
@@ -21,6 +21,7 @@ properties:
enum:
- rockchip,rk3566-vop
- rockchip,rk3568-vop
+ - rockchip,rk3576-vop
- rockchip,rk3588-vop
reg:
@@ -38,10 +39,21 @@ properties:
- const: gamma-lut
interrupts:
- maxItems: 1
+ minItems: 1
+ maxItems: 4
description:
- The VOP interrupt is shared by several interrupt sources, such as
- frame start (VSYNC), line flag and other status interrupts.
+ For VOP version under rk3576, the interrupt is shared by several interrupt
+ sources, such as frame start (VSYNC), line flag and other interrupt status.
+ For VOP version from rk3576 there is a system interrupt for bus error, and
+ every video port has it's independent interrupts for vsync and other video
+ port related error interrupts.
+
+ interrupt-names:
+ items:
+ - const: sys
+ - const: vp0
+ - const: vp1
+ - const: vp2
# See compatible-specific constraints below.
clocks:
@@ -136,6 +148,11 @@ allOf:
clock-names:
maxItems: 5
+ interrupts:
+ maxItems: 1
+
+ interrupt-names: false
+
ports:
required:
- port@0
@@ -149,6 +166,39 @@ allOf:
required:
- rockchip,grf
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - rockchip,rk3576-vop
+ then:
+ properties:
+ clocks:
+ maxItems: 5
+
+ clock-names:
+ maxItems: 5
+
+ interrupts:
+ minItems: 4
+
+ interrupt-names:
+ minItems: 4
+
+ ports:
+ required:
+ - port@0
+ - port@1
+ - port@2
+
+ rockchip,vo1-grf: false
+ rockchip,vop-grf: false
+
+ required:
+ - rockchip,grf
+ - rockchip,pmu
+
- if:
properties:
compatible:
@@ -164,6 +214,11 @@ allOf:
minItems: 7
maxItems: 9
+ interrupts:
+ maxItems: 1
+
+ interrupt-names: false
+
ports:
required:
- port@0
--
2.34.1
next prev parent reply other threads:[~2025-02-18 11:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 11:27 [PATCH v15 00/13] VOP Support for rk3576 Andy Yan
2025-02-18 11:27 ` [PATCH v15 01/13] drm/rockchip: vop2: use devm_regmap_field_alloc for cluster-regs Andy Yan
2025-02-18 11:27 ` [PATCH v15 02/13] drm/rockchip: vop2: Remove AFBC from TRANSFORM_OFFSET register macro Andy Yan
2025-02-18 11:27 ` [PATCH v15 03/13] drm/rockchip: vop2: Add platform specific callback Andy Yan
2025-02-18 11:27 ` [PATCH v15 04/13] drm/rockchip: vop2: Merge vop2_cluster/esmart_init function Andy Yan
2025-02-18 11:27 ` [PATCH v15 05/13] drm/rockchip: vop2: Support for different layer select configuration between VPs Andy Yan
2025-02-18 11:27 ` [PATCH v15 06/13] drm/rockchip: vop2: Introduce vop hardware version Andy Yan
2025-02-18 11:27 ` [PATCH v15 07/13] drm/rockchip: vop2: Register the primary plane and overlay plane separately Andy Yan
2025-03-02 18:57 ` Heiko Stübner
2025-03-03 6:17 ` Andy Yan
2025-02-18 11:27 ` [PATCH v15 08/13] drm/rockchip: vop2: Set plane possible crtcs by possible vp mask Andy Yan
2025-02-18 11:27 ` [PATCH v15 09/13] drm/rockchip: vop2: Add uv swap for cluster window Andy Yan
2025-02-18 11:27 ` [PATCH v15 10/13] dt-bindings: display: vop2: describe constraint SoC by SoC Andy Yan
2025-02-18 11:28 ` [PATCH v15 11/13] dt-bindings: display: vop2: Add missing rockchip,grf property for rk3566/8 Andy Yan
2025-02-18 11:28 ` Andy Yan [this message]
2025-02-18 11:28 ` [PATCH v15 13/13] drm/rockchip: vop2: Add support for rk3576 Andy Yan
2025-03-02 19:09 ` Heiko Stübner
2025-03-02 12:01 ` Re:[PATCH v15 00/13] VOP Support " Andy Yan
2025-03-02 18:34 ` (subset) [PATCH " Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250218112848.34535-1-andyshrk@163.com \
--to=andyshrk@163.com \
--cc=andy.yan@rock-chips.com \
--cc=daniel@fooishbar.org \
--cc=derek.foreman@collabora.com \
--cc=detlev.casanova@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®