From: "Dmitry V. Levin" <ldv@strace.io>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Alexey Gladkov <legion@kernel.org>,
Eugene Syromyatnikov <evgsyr@gmail.com>,
strace-devel@lists.strace.io, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 3/6] syscall.h: introduce syscall_set_nr()
Date: Wed, 19 Feb 2025 21:30:07 +0200 [thread overview]
Message-ID: <20250219193007.GC14216@strace.io> (raw)
In-Reply-To: <alpine.DEB.2.21.2502191917420.65342@angie.orcam.me.uk>
On Wed, Feb 19, 2025 at 07:20:33PM +0000, Maciej W. Rozycki wrote:
> On Wed, 19 Feb 2025, Dmitry V. Levin wrote:
[...]
> > Would you be OK with the following wording:
> > /*
> > * New syscall number has to be assigned to regs[2] because it is
> > * loaded from there unconditionally after syscall_trace_enter()
> > * invocation.
>
> May I suggest "[...] after return from syscall_trace_enter() invocation."
> instead? Minor reformatting might be required for better visual alignment
> though.
Like this:
/*
* New syscall number has to be assigned to regs[2] because
* it is loaded from there unconditionally after return from
* syscall_trace_enter() invocation.
*
* Consequently, if the syscall was indirect and nr != __NR_syscall,
* then after this assignment the syscall will cease to be indirect.
*/
?
--
ldv
next prev parent reply other threads:[~2025-02-19 19:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 9:08 [PATCH v6 0/6] ptrace: introduce PTRACE_SET_SYSCALL_INFO API Dmitry V. Levin
2025-02-17 9:10 ` [PATCH v6 1/6] hexagon: add syscall_set_return_value() Dmitry V. Levin
2025-02-17 9:10 ` [PATCH v6 2/6] syscall.h: add syscall_set_arguments() Dmitry V. Levin
2025-02-19 17:15 ` Maciej W. Rozycki
2025-02-19 18:48 ` Dmitry V. Levin
2025-02-19 19:16 ` Maciej W. Rozycki
2025-02-17 9:10 ` [PATCH v6 3/6] syscall.h: introduce syscall_set_nr() Dmitry V. Levin
2025-02-19 17:16 ` Maciej W. Rozycki
2025-02-19 18:24 ` Dmitry V. Levin
2025-02-19 19:20 ` Maciej W. Rozycki
2025-02-19 19:30 ` Dmitry V. Levin [this message]
2025-02-20 23:19 ` Maciej W. Rozycki
2025-02-17 9:10 ` [PATCH v6 4/6] ptrace_get_syscall_info: factor out ptrace_get_syscall_info_op Dmitry V. Levin
2025-02-17 9:11 ` [PATCH v6 5/6] ptrace: introduce PTRACE_SET_SYSCALL_INFO request Dmitry V. Levin
2025-02-17 9:11 ` [PATCH v6 6/6] selftests/ptrace: add a test case for PTRACE_SET_SYSCALL_INFO Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250219193007.GC14216@strace.io \
--to=ldv@strace.io \
--cc=akpm@linux-foundation.org \
--cc=evgsyr@gmail.com \
--cc=legion@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=oleg@redhat.com \
--cc=strace-devel@lists.strace.io \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®