From: niravkumar.l.rabara@intel.com
To: Vinod Koul <vkoul@kernel.org>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Cc: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>,
nirav.rabara@altera.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, Jisheng Zhang <jszhang@kernel.org>
Subject: [PATCH v4] dma: dw-axi-dmac: remove unnecessary axi_dma_enable() calling
Date: Thu, 20 Feb 2025 17:40:47 +0800 [thread overview]
Message-ID: <20250220094047.3799548-1-niravkumar.l.rabara@intel.com> (raw)
From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
DMA is always enabled before calling axi_chan_block_xfer_start(),
so it does not need to be enabled again here.
Re-enabling DMA causes random failures in the dmatest test when running
multiple iterations.
e.g.
[ 29.600722] dmatest: dma0chan2-copy0: summary 100 tests, 1 failures 160.26 iops 1299 KB/s (0)
Fixes: 1fe20f1b8454 ("dmaengine: Introduce DW AXI DMAC driver")
Tested-by :Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
---
Changes in v4:
* Add fixes tag
* Rebase to v6.14-rc1
link to v3:
- https://lore.kernel.org/all/20230521101216.4084-4-jszhang@kernel.org/
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
index b23536645ff7..43d30c7b8f03 100644
--- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
+++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
@@ -435,8 +435,6 @@ static void axi_chan_block_xfer_start(struct axi_dma_chan *chan,
return;
}
- axi_dma_enable(chan->chip);
-
config.dst_multblk_type = DWAXIDMAC_MBLK_TYPE_LL;
config.src_multblk_type = DWAXIDMAC_MBLK_TYPE_LL;
config.tt_fc = DWAXIDMAC_TT_FC_MEM_TO_MEM_DMAC;
--
2.25.1
reply other threads:[~2025-02-20 9:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220094047.3799548-1-niravkumar.l.rabara@intel.com \
--to=niravkumar.l.rabara@intel.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=dmaengine@vger.kernel.org \
--cc=jszhang@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nirav.rabara@altera.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®