From: Josh Poimboeuf <jpoimboe@kernel.org>
To: David Laight <david.laight.linux@gmail.com>
Cc: linux-kernel@vger.kernel.org, Miroslav Benes <mbenes@suse.cz>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 1/1] objdump: Fix disassembly if CROSS_COMPILE not set
Date: Thu, 20 Feb 2025 14:12:42 -0800 [thread overview]
Message-ID: <20250220221242.rdmfpabnhowjpu2m@jpoimboe> (raw)
In-Reply-To: <20250220221157.njqmvge5t6kvn6b5@jpoimboe>
On Thu, Feb 20, 2025 at 02:11:59PM -0800, Josh Poimboeuf wrote:
> On Sat, Feb 15, 2025 at 02:23:21PM +0000, David Laight wrote:
> > If CROSS_COMPILE isn't set and -v specified the code tries to run
> > system("(null)objdump ....")
> > which really doesn't work very well.
> > Fix by changing NULL to "".
> >
> > Fixes: ca653464dd097 ("objtool: Add verbose option for disassembling affected functions")
> > Signed-off-by: David Laight <david.laight.linux@gmail.com>
> > ---
> > tools/objtool/check.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> > index 753dbc4f8198..c1b771e772fd 100644
> > --- a/tools/objtool/check.c
> > +++ b/tools/objtool/check.c
> > @@ -4506,6 +4506,8 @@ static int disas_funcs(const char *funcs)
> > char *cmd;
> >
> > cross_compile = getenv("CROSS_COMPILE");
> > + if (!cross_compile)
> > + cross_compile = "";
>
> Makes sense, I'm not sure how this works for me already? Regardless:
>
> Acked-by: Josh Poimboeuf <jpoimboe@kernel.org>
>
> Peter, can you take this one?
With s/objdump/objtool/ in subject :-)
--
Josh
prev parent reply other threads:[~2025-02-20 22:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-15 14:23 David Laight
2025-02-20 22:11 ` Josh Poimboeuf
2025-02-20 22:12 ` Josh Poimboeuf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220221242.rdmfpabnhowjpu2m@jpoimboe \
--to=jpoimboe@kernel.org \
--cc=david.laight.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®