mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cindy Lu <lulu@redhat.com>
To: lulu@redhat.com, jasowang@redhat.com, mst@redhat.com,
	michael.christie@oracle.com, sgarzare@redhat.com,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org
Subject: [PATCH v6 6/6] vhost: Add check for inherit_owner status
Date: Sun, 23 Feb 2025 23:36:21 +0800	[thread overview]
Message-ID: <20250223154042.556001-7-lulu@redhat.com> (raw)
In-Reply-To: <20250223154042.556001-1-lulu@redhat.com>

The VHOST_NEW_WORKER requires the inherit_owner
setting to be true. So we need to add a check for this.

Signed-off-by: Cindy Lu <lulu@redhat.com>
---
 drivers/vhost/vhost.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 45d8f5c5bca9..26da561c6685 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -1017,6 +1017,13 @@ long vhost_worker_ioctl(struct vhost_dev *dev, unsigned int ioctl,
 	switch (ioctl) {
 	/* dev worker ioctls */
 	case VHOST_NEW_WORKER:
+		/*
+		 * vhost_tasks will account for worker threads under the parent's
+		 * NPROC value but kthreads do not. To avoid userspace overflowing
+		 * the system with worker threads inherit_owner must be true.
+		 */
+		if (!dev->inherit_owner)
+			return -EFAULT;
 		ret = vhost_new_worker(dev, &state);
 		if (!ret && copy_to_user(argp, &state, sizeof(state)))
 			ret = -EFAULT;
-- 
2.45.0


  parent reply	other threads:[~2025-02-23 15:41 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-23 15:36 [PATCH v6 0/6] vhost: Add support of kthread API Cindy Lu
2025-02-23 15:36 ` [PATCH v6 1/6] vhost: Add a new parameter in vhost_dev to allow user select kthread Cindy Lu
2025-02-24  1:36   ` Jason Wang
2025-02-23 15:36 ` [PATCH v6 2/6] vhost: Reintroduce vhost_worker to support kthread Cindy Lu
2025-02-24  1:36   ` Jason Wang
2025-02-23 15:36 ` [PATCH v6 3/6] vhost: Add the cgroup related function Cindy Lu
2025-02-24  1:39   ` Jason Wang
2025-02-26  2:15     ` Cindy Lu
2025-02-25  2:35   ` kernel test robot
2025-02-23 15:36 ` [PATCH v6 4/6] vhost: introduce worker ops to support multiple thread models Cindy Lu
2025-02-24  1:44   ` Jason Wang
2025-02-26  2:06     ` Cindy Lu
2025-02-23 15:36 ` [PATCH v6 5/6] vhost: Add new UAPI to support change to task mode Cindy Lu
2025-02-24  1:54   ` Jason Wang
2025-02-24 21:41   ` Michael S. Tsirkin
2025-02-24 21:46   ` Michael S. Tsirkin
2025-02-26  6:16     ` Cindy Lu
2025-02-25 11:31   ` Stefano Garzarella
2025-02-26  6:13     ` Cindy Lu
2025-02-26  8:46       ` Stefano Garzarella
2025-02-26  8:50         ` Michael S. Tsirkin
2025-02-26  9:02           ` Stefano Garzarella
2025-02-26  9:05   ` Stefano Garzarella
2025-02-26  9:19     ` Cindy Lu
2025-02-23 15:36 ` Cindy Lu [this message]
2025-02-24  1:56   ` [PATCH v6 6/6] vhost: Add check for inherit_owner status Jason Wang
2025-02-24 15:13 ` [PATCH v6 0/6] vhost: Add support of kthread API Lei Yang
2025-02-24 21:43 ` Michael S. Tsirkin
2025-02-26  2:04   ` Cindy Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250223154042.556001-7-lulu@redhat.com \
    --to=lulu@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.christie@oracle.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=sgarzare@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®