From: Qais Yousef <qyousef@layalina.io>
To: Ingo Molnar <mingo@kernel.org>
Cc: Andrea Righi <arighi@nvidia.com>,
Joel Fernandes <joelagnelf@nvidia.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Juri Lelli <juri.lelli@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
John Stultz <jstultz@google.com>,
Saravana Kannan <saravanak@google.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Frederic Weisbecker <frederic@kernel.org>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Kconfig.hz: Change default HZ to 1000
Date: Sun, 23 Feb 2025 23:21:51 +0000 [thread overview]
Message-ID: <20250223232151.xtsobtuoaofotrxx@airbuntu> (raw)
In-Reply-To: <Z7rxuqIB38Wv557A@gmail.com>
On 02/23/25 11:00, Ingo Molnar wrote:
>
> * Andrea Righi <arighi@nvidia.com> wrote:
>
> > On Wed, Feb 12, 2025 at 09:50:54AM -0500, Joel Fernandes wrote:
> > > On Mon, Feb 10, 2025 at 12:19:15AM +0000, Qais Yousef wrote:
> > ...
> > > > I believe HZ_250 was the default as a trade-off for battery power
> > > > devices that might not be happy with frequent TICKS potentially draining
> > > > the battery unnecessarily. But to my understanding the current state of
> > >
> > > Actually, on x86, me and Steve did some debug on Chromebooks and we found
> > > that HZ_250 actually increased power versus higher HZ. This was because
> > > cpuidle governor changes C states on the tick, and by making it less
> > > frequent, the CPU could be in a shallow C state for longer.
> >
> > FWIW, I found the same about power consumption when we decided to switch to
> > CONFIG_HZ=1000 in the Ubuntu kernel:
> > https://discourse.ubuntu.com/t/enable-low-latency-features-in-the-generic-ubuntu-kernel-for-24-04/42255
Thanks for sharing the data Andrea!
>
> The "HZ=1000 reduces power consumption or keeps it the same" is
> actually a pretty good argument to change the default to HZ=1000.
>
> These experiments and numbers (if any) should be incorporated in the
> changelog prominently - as actual data and the Kconfig decisions made
> by major distros will, most of the time, be superior to meta analysis
> that seems to be the changelog right now.
I will update the commit message to incorporate data and the feedback received.
Thanks!
--
Qais Yousef
next prev parent reply other threads:[~2025-02-23 23:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 0:19 Qais Yousef
2025-02-12 14:50 ` Joel Fernandes
2025-02-16 16:11 ` Qais Yousef
2025-02-23 7:50 ` Andrea Righi
2025-02-23 10:00 ` Ingo Molnar
2025-02-23 23:21 ` Qais Yousef [this message]
2025-02-24 13:16 ` Vincent Guittot
2025-02-24 23:23 ` Sean Christopherson
2025-02-13 8:24 ` Saravana Kannan
2025-02-16 16:29 ` Qais Yousef
2025-02-16 19:05 ` David Laight
2025-02-22 23:47 ` Qais Yousef
2025-02-28 10:33 ` Attila Fazekas
2025-03-02 12:05 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250223232151.xtsobtuoaofotrxx@airbuntu \
--to=qyousef@layalina.io \
--cc=akpm@linux-foundation.org \
--cc=arighi@nvidia.com \
--cc=dietmar.eggemann@arm.com \
--cc=frederic@kernel.org \
--cc=joelagnelf@nvidia.com \
--cc=jstultz@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=saravanak@google.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®