From: Ricardo Ribalda <ribalda@chromium.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Hans de Goede <hdegoede@redhat.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Ricardo Ribalda <ribalda@chromium.org>,
stable@kernel.org
Subject: [PATCH v2 0/3] media: uvcvideo: Make sure the ctrl cache is in sync with the device
Date: Mon, 24 Feb 2025 10:34:52 +0000 [thread overview]
Message-ID: <20250224-uvc-data-backup-v2-0-de993ed9823b@chromium.org> (raw)
Hans discovered a bug in the error handling of uvc_ctrl_commit(), lets
fix it.
It has been tested with v4l2-compliance -d /dev/video0
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
Changes in v2:
- Fix commit message (Thanks Laurent).
- Change logic for err_ctrl. It looks nicer now.
- Link to v1: https://lore.kernel.org/r/20241210-uvc-data-backup-v1-0-77141e439cc3@chromium.org
---
Ricardo Ribalda (3):
media: uvcvideo: Return the number of processed controls
media: uvcvideo: Send control events for partial succeeds
media: uvcvideo: Rollback non processed entities on error
drivers/media/usb/uvc/uvc_ctrl.c | 53 ++++++++++++++++++++++++++++++----------
1 file changed, 40 insertions(+), 13 deletions(-)
---
base-commit: c2b96a6818159fba8a3bcc38262da9e77f9b3ec7
change-id: 20241210-uvc-data-backup-a0a76df9aee9
Best regards,
--
Ricardo Ribalda <ribalda@chromium.org>
next reply other threads:[~2025-02-24 10:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 10:34 Ricardo Ribalda [this message]
2025-02-24 10:34 ` [PATCH v2 1/3] media: uvcvideo: Return the number of processed controls Ricardo Ribalda
2025-03-03 14:51 ` Hans de Goede
2025-02-24 10:34 ` [PATCH v2 2/3] media: uvcvideo: Send control events for partial succeeds Ricardo Ribalda
2025-03-03 15:50 ` Hans de Goede
2025-04-22 20:55 ` Laurent Pinchart
2025-02-24 10:34 ` [PATCH v2 3/3] media: uvcvideo: Rollback non processed entities on error Ricardo Ribalda
2025-03-03 15:51 ` Hans de Goede
2025-04-07 13:02 ` Hans de Goede
2025-04-10 7:32 ` Ricardo Ribalda
2025-04-22 21:20 ` Laurent Pinchart
2025-04-22 21:13 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250224-uvc-data-backup-v2-0-de993ed9823b@chromium.org \
--to=ribalda@chromium.org \
--cc=hdegoede@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®