From: Boqun Feng <boqun.feng@gmail.com>
To: rcu@vger.kernel.org
Cc: Lai Jiangshan <jiangshanlai@gmail.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Frederic Weisbecker <frederic@kernel.org>,
Neeraj Upadhyay <neeraj.upadhyay@kernel.org>,
Joel Fernandes <joel@joelfernandes.org>,
Boqun Feng <boqun.feng@gmail.com>,
Uladzislau Rezki <urezki@gmail.com>,
Zqiang <qiang.zhang1211@gmail.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Kent Overstreet <kent.overstreet@linux.dev>
Subject: [PATCH rcu 09/20] srcu: Add SRCU_READ_FLAVOR_SLOWGP to flag need for synchronize_rcu()
Date: Sun, 23 Feb 2025 18:22:03 -0800 [thread overview]
Message-ID: <20250224022214.12037-10-boqun.feng@gmail.com> (raw)
In-Reply-To: <20250224022214.12037-1-boqun.feng@gmail.com>
From: "Paul E. McKenney" <paulmck@kernel.org>
This commit switches from a direct test of SRCU_READ_FLAVOR_LITE to a new
SRCU_READ_FLAVOR_SLOWGP macro to check for substituting synchronize_rcu()
for smp_mb() in SRCU grace periods. Right now, SRCU_READ_FLAVOR_SLOWGP
is exactly SRCU_READ_FLAVOR_LITE, but the addition of the _fast() flavor
of SRCU will change that.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Andrii Nakryiko <andrii@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Kent Overstreet <kent.overstreet@linux.dev>
Cc: <bpf@vger.kernel.org>
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
---
include/linux/srcu.h | 3 +++
kernel/rcu/srcutree.c | 6 +++---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/include/linux/srcu.h b/include/linux/srcu.h
index ca00b9af7c23..505f5bdce444 100644
--- a/include/linux/srcu.h
+++ b/include/linux/srcu.h
@@ -49,6 +49,9 @@ int init_srcu_struct(struct srcu_struct *ssp);
#define SRCU_READ_FLAVOR_LITE 0x4 // srcu_read_lock_lite().
#define SRCU_READ_FLAVOR_ALL (SRCU_READ_FLAVOR_NORMAL | SRCU_READ_FLAVOR_NMI | \
SRCU_READ_FLAVOR_LITE) // All of the above.
+#define SRCU_READ_FLAVOR_SLOWGP SRCU_READ_FLAVOR_LITE
+ // Flavors requiring synchronize_rcu()
+ // instead of smp_mb().
#ifdef CONFIG_TINY_SRCU
#include <linux/srcutiny.h>
diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c
index 121dd290cae1..8b5c50bc98e5 100644
--- a/kernel/rcu/srcutree.c
+++ b/kernel/rcu/srcutree.c
@@ -449,7 +449,7 @@ static bool srcu_readers_lock_idx(struct srcu_struct *ssp, int idx, bool gp, uns
}
WARN_ONCE(IS_ENABLED(CONFIG_PROVE_RCU) && (mask & (mask - 1)),
"Mixed reader flavors for srcu_struct at %ps.\n", ssp);
- if (mask & SRCU_READ_FLAVOR_LITE && !gp)
+ if (mask & SRCU_READ_FLAVOR_SLOWGP && !gp)
return false;
return sum == unlocks;
}
@@ -487,7 +487,7 @@ static bool srcu_readers_active_idx_check(struct srcu_struct *ssp, int idx)
unsigned long unlocks;
unlocks = srcu_readers_unlock_idx(ssp, idx, &rdm);
- did_gp = !!(rdm & SRCU_READ_FLAVOR_LITE);
+ did_gp = !!(rdm & SRCU_READ_FLAVOR_SLOWGP);
/*
* Make sure that a lock is always counted if the corresponding
@@ -1205,7 +1205,7 @@ static bool srcu_should_expedite(struct srcu_struct *ssp)
check_init_srcu_struct(ssp);
/* If _lite() readers, don't do unsolicited expediting. */
- if (this_cpu_read(ssp->sda->srcu_reader_flavor) & SRCU_READ_FLAVOR_LITE)
+ if (this_cpu_read(ssp->sda->srcu_reader_flavor) & SRCU_READ_FLAVOR_SLOWGP)
return false;
/* If the local srcu_data structure has callbacks, not idle. */
sdp = raw_cpu_ptr(ssp->sda);
--
2.39.5 (Apple Git-154)
next prev parent reply other threads:[~2025-02-24 2:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 2:21 [PATCH rcu 00/20] SRCU changes for v6.15 Boqun Feng
2025-02-24 2:21 ` [PATCH rcu 01/20] srcu: Make Tiny SRCU able to operate in preemptible kernels Boqun Feng
2025-02-24 2:21 ` [PATCH rcu 02/20] srcu: Define SRCU_READ_FLAVOR_ALL in terms of symbols Boqun Feng
2025-02-24 2:21 ` [PATCH rcu 03/20] srcu: Use ->srcu_gp_seq for rcutorture reader batch Boqun Feng
2025-02-24 2:21 ` [PATCH rcu 04/20] srcu: Pull ->srcu_{un,}lock_count into a new srcu_ctr structure Boqun Feng
2025-02-24 2:21 ` [PATCH rcu 05/20] srcu: Make SRCU readers use ->srcu_ctrs for counter selection Boqun Feng
2025-02-24 2:22 ` [PATCH rcu 06/20] srcu: Make Tree SRCU updates independent of ->srcu_idx Boqun Feng
2025-02-24 2:22 ` [PATCH rcu 07/20] srcu: Force synchronization for srcu_get_delay() Boqun Feng
2025-02-24 2:22 ` [PATCH rcu 08/20] srcu: Rename srcu_check_read_flavor_lite() to srcu_check_read_flavor_force() Boqun Feng
2025-02-24 2:22 ` Boqun Feng [this message]
2025-02-24 2:22 ` [PATCH rcu 10/20] srcu: Pull pointer-to-integer conversion into __srcu_ptr_to_ctr() Boqun Feng
2025-02-24 2:22 ` [PATCH rcu 11/20] srcu: Pull integer-to-pointer conversion into __srcu_ctr_to_ptr() Boqun Feng
2025-02-24 2:22 ` [PATCH rcu 12/20] srcu: Move SRCU Tree/Tiny definitions from srcu.h Boqun Feng
2025-02-24 2:22 ` [PATCH rcu 13/20] srcu: Add SRCU-fast readers Boqun Feng
2025-02-24 2:22 ` [PATCH rcu 14/20] rcutorture: Add ability to test srcu_read_{,un}lock_fast() Boqun Feng
2025-02-24 2:22 ` [PATCH rcu 15/20] refscale: Add srcu_read_lock_fast() support using "srcu-fast" Boqun Feng
2025-02-24 2:22 ` [PATCH rcu 16/20] rcutorture: Make scenario SRCU-P use srcu_read_lock_fast() Boqun Feng
2025-02-24 2:22 ` [PATCH rcu 17/20] srcu: Fix srcu_read_unlock_{lite,nmisafe}() kernel-doc Boqun Feng
2025-02-24 2:22 ` [PATCH rcu 18/20] srcu: Document that srcu_{read_lock,down_read}() can share srcu_struct Boqun Feng
2025-02-24 2:22 ` [PATCH rcu 19/20] srcu: Add srcu_down_read_fast() and srcu_up_read_fast() Boqun Feng
2025-02-24 2:22 ` [PATCH rcu 20/20] srcu: Make SRCU-fast also be NMI-safe Boqun Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250224022214.12037-10-boqun.feng@gmail.com \
--to=boqun.feng@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=dave@stgolabs.net \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=neeraj.upadhyay@kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=qiang.zhang1211@gmail.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®