mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Waiman Long <llong@redhat.com>
Cc: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Boqun Feng <boqun.feng@gmail.com>,
	Joel Granados <joel.granados@kernel.org>,
	Anna Schumaker <anna.schumaker@oracle.com>,
	Lance Yang <ioworker0@gmail.com>,
	Kent Overstreet <kent.overstreet@linux.dev>,
	Yongliang Gao <leonylgao@tencent.com>,
	Tomasz Figa <tfiga@chromium.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] hung_task: Show the blocker task if the task is hung on mutex
Date: Mon, 24 Feb 2025 09:51:51 -0500	[thread overview]
Message-ID: <20250224095151.73e809f8@gandalf.local.home> (raw)
In-Reply-To: <30f8fa10-4527-4e03-91c6-638834412466@redhat.com>

On Sun, 23 Feb 2025 14:53:28 -0500
Waiman Long <llong@redhat.com> wrote:

> >>   +
> >> +#ifdef CONFIG_DETECT_HUNG_TASK_BLOCKER
> >> +static void debug_show_blocker(struct task_struct *task)  
> 
> I think the easiest way forward is to change it to "#if 
> defined(CONFIG_DETECT_HUNG_TASK_BLOCKER) && !defined(CONFIG_PREEMPT_RT)" 
> to skip this feature for PREEMPT_RT right now . Otherwise, you will have 
> to deal with the rtmutex code.

If this isn't supported by PREEMPT_RT (yet), then just make the
DETECT_HUNG_TASK_BLOCKER in the Kconfig be:

	Depends on !PREEMPT_RT

Don't put that dependency in the code.

-- Steve

  reply	other threads:[~2025-02-24 14:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-22  2:03 [PATCH v3 0/2] hung_task: Dump the blocking task stacktrace Masami Hiramatsu (Google)
2025-02-22  2:03 ` [PATCH v3 1/2] hung_task: Show the blocker task if the task is hung on mutex Masami Hiramatsu (Google)
2025-02-23  2:58   ` Lance Yang
2025-02-23 19:34   ` Waiman Long
2025-02-23 19:53     ` Waiman Long
2025-02-24 14:51       ` Steven Rostedt [this message]
2025-02-25  0:48         ` Waiman Long
2025-02-24 23:02     ` Masami Hiramatsu
2025-02-22  2:03 ` [PATCH v3 2/2] samples: Add hung_task detector mutex blocking sample Masami Hiramatsu (Google)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250224095151.73e809f8@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=anna.schumaker@oracle.com \
    --cc=boqun.feng@gmail.com \
    --cc=ioworker0@gmail.com \
    --cc=joel.granados@kernel.org \
    --cc=kent.overstreet@linux.dev \
    --cc=leonylgao@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llong@redhat.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=senozhatsky@chromium.org \
    --cc=tfiga@chromium.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®