From: Antheas Kapenekakis <lkml@antheas.dev>
To: luke@ljones.dev, mario.limonciello@amd.com
Cc: corentin.chary@gmail.com, hdegoede@redhat.com,
ilpo.jarvinen@linux.intel.com, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
Antheas Kapenekakis <lkml@antheas.dev>
Subject: RE: [PATCH] platform/x86: asus-wmi: change quiet to low-power
Date: Tue, 25 Feb 2025 15:25:55 +0100 [thread overview]
Message-ID: <20250225142555.14005-1-lkml@antheas.dev> (raw)
In-Reply-To: <20250224223551.16918-1-luke@ljones.dev>
Hi Luke,
please add appropriate attribution.
Closes: https://lore.kernel.org/all/20250224195059.10185-1-lkml@antheas.dev/
Reported-by: Antheas Kapenekakis <lkml@antheas.dev>
For me, this patch series plus the multi-platform profile one constitute
a double ABI break. Not only does the legacy sysfs for platform profile
regress when there is a second profile handler for a device, but all
hardcoded scripts for Asus devices will have to be updated.
While I would personally like to avoid this, I am ok with it, given
appropriate attribution, since I did go through the effort of reporting it
and providing a mitigation.
@Mario: you added Reviewed-by to a patch without proper attribution. Let's
not rehash our discussion from few days ago. Please try to do better when
it comes to attributions in the future.
Antheas
next prev parent reply other threads:[~2025-02-25 14:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 22:35 Luke Jones
2025-02-25 2:39 ` Mario Limonciello
2025-02-25 6:13 ` Luke Jones
2025-02-25 15:59 ` Armin Wolf
2025-02-25 14:25 ` Antheas Kapenekakis [this message]
2025-02-25 14:49 ` Mario Limonciello
2025-02-25 15:21 ` Antheas Kapenekakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250225142555.14005-1-lkml@antheas.dev \
--to=lkml@antheas.dev \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=mario.limonciello@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®