From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ayushi Makhija <quic_amakhija@quicinc.com>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: robdclark@gmail.com, dmitry.baryshkov@linaro.org,
sean@poorly.run, marijn.suijten@somainline.org,
andersson@kernel.org, robh@kernel.org, robh+dt@kernel.org,
krzk+dt@kernel.org, konradybcio@kernel.org, conor+dt@kernel.org,
andrzej.hajda@intel.com, neil.armstrong@linaro.org,
rfoss@kernel.org, Laurent.pinchart@ideasonboard.com,
jonas@kwiboo.se, jernej.skrabec@gmail.com,
quic_abhinavk@quicinc.com, quic_rajeevny@quicinc.com,
quic_vproddut@quicinc.com, quic_jesszhan@quicinc.com
Subject: Re: [PATCH 07/11] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes
Date: Wed, 26 Feb 2025 09:35:46 +0100 [thread overview]
Message-ID: <20250226-futuristic-messy-rook-e9f85c@krzk-bin> (raw)
In-Reply-To: <ecdc2230-1ce1-4d70-a352-180f6cd29e61@kernel.org>
On Tue, Feb 25, 2025 at 02:31:05PM +0100, Krzysztof Kozlowski wrote:
> On 25/02/2025 13:18, Ayushi Makhija wrote:
> > + pinctrl-0 = <&dsi0_int_pin>,
> > + <&dsi0_cbl_det_pin>,
> > + <&dsi1_int_pin>,
> > + <&dsi1_cbl_det_pin>;
> > + pinctrl-names = "default";
> > +
> > + dsi0_int_pin: gpio2_cfg {
>
>
> No underscores, see DTS coding style.
And as Rob's bot pointed out: insufficient testing. :(
Please be 100% sure everything is tested before you post new version.
You shouldn't use reviewers for the job of tools, that's quite waste of
our time.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-26 8:35 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 12:18 [PATCH 00/11] Add DSI display support for SA8775P target Ayushi Makhija
2025-02-25 12:18 ` [PATCH 01/11] dt-bindings: display: msm-dsi-phy-7nm: document the SA8775P DSI PHY Ayushi Makhija
2025-02-25 12:18 ` [PATCH 02/11] dt-bindings: msm: dsi-controller-main: document the SA8775P DSI CTRL Ayushi Makhija
2025-02-25 12:18 ` [PATCH 03/11] dt-bindings: display: msm: document DSI controller and phy on SA8775P Ayushi Makhija
2025-02-25 14:24 ` Rob Herring (Arm)
2025-02-25 12:18 ` [PATCH 04/11] drm/msm/dsi: add DSI PHY configuration " Ayushi Makhija
2025-02-25 17:14 ` Dmitry Baryshkov
2025-02-25 12:18 ` [PATCH 05/11] drm/msm/dsi: add DSI support for SA8775P Ayushi Makhija
2025-02-25 17:18 ` Dmitry Baryshkov
2025-03-04 9:30 ` Ayushi Makhija
2025-02-25 12:18 ` [PATCH 06/11] arm64: dts: qcom: sa8775p: add Display Serial Interface device nodes Ayushi Makhija
2025-02-25 13:09 ` Konrad Dybcio
2025-02-25 12:18 ` [PATCH 07/11] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes Ayushi Makhija
2025-02-25 13:10 ` Konrad Dybcio
2025-02-25 13:31 ` Krzysztof Kozlowski
2025-02-26 8:35 ` Krzysztof Kozlowski [this message]
2025-03-04 9:58 ` Ayushi Makhija
2025-02-25 17:41 ` Dmitry Baryshkov
2025-02-25 12:18 ` [PATCH 08/11] arm64: dts: qcom: sa8775p-ride: enable Display serial interface Ayushi Makhija
2025-02-25 13:11 ` Konrad Dybcio
2025-02-25 17:55 ` Dmitry Baryshkov
2025-03-04 9:44 ` Ayushi Makhija
2025-03-04 9:48 ` Dmitry Baryshkov
2025-03-04 10:13 ` Ayushi Makhija
2025-02-25 12:18 ` [PATCH 09/11] drm/bridge: anx7625: enable HPD interrupts Ayushi Makhija
2025-02-25 17:56 ` Dmitry Baryshkov
2025-02-25 12:18 ` [PATCH 10/11] drm/bridge: anx7625: update bridge_ops and sink detect logic Ayushi Makhija
2025-02-25 17:58 ` Dmitry Baryshkov
2025-02-25 20:57 ` Dmitry Baryshkov
2025-02-25 12:18 ` [PATCH 11/11] drm/bridge: anx7625: change the gpiod_set_value API Ayushi Makhija
2025-02-25 18:03 ` Dmitry Baryshkov
2025-02-25 20:12 ` [PATCH 00/11] Add DSI display support for SA8775P target Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250226-futuristic-messy-rook-e9f85c@krzk-bin \
--to=krzk@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=andersson@kernel.org \
--cc=andrzej.hajda@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_amakhija@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=quic_rajeevny@quicinc.com \
--cc=quic_vproddut@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®