From: Gur Stavi <gur.stavi@huawei.com>
To: <gur.stavi@huawei.com>
Cc: <andrew+netdev@lunn.ch>, <cai.huoqing@linux.dev>,
<corbet@lwn.net>, <davem@davemloft.net>, <edumazet@google.com>,
<gongfan1@huawei.com>, <guoxin09@huawei.com>,
<helgaas@kernel.org>, <horms@kernel.org>, <kuba@kernel.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<luosifu@huawei.com>, <meny.yossefi@huawei.com>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>,
<przemyslaw.kitszel@intel.com>, <shenchenyang1@hisilicon.com>,
<shijing34@huawei.com>, <sumang@marvell.com>,
<wulike1@huawei.com>, <zhoushuai28@huawei.com>
Subject: Re: [PATCH net-next v06 1/1] hinic3: module initialization and tx/rx logic
Date: Wed, 26 Feb 2025 08:14:06 +0200 [thread overview]
Message-ID: <20250226061406.648948-1-gur.stavi@huawei.com> (raw)
In-Reply-To: <20250226060847.648823-1-gur.stavi@huawei.com>
> > On Tue, 25 Feb 2025 16:53:30 +0200 Gur Stavi wrote:
> > > .../ethernet/huawei/hinic3/hinic3_hw_cfg.c | 25 +
> >
> > drivers/net/ethernet/huawei/hinic3/hinic3_hw_cfg.c:14:36-41: WARNING: conversion to bool not needed here
>
> Don't know what this comment refers to.
> There is nothing related to 'bool' in line 14 or 36-41.
> The only place 'bool' appears in the file is line 243.
My mistake. I looked at the full file instead of only the 1st patch we
actually submitted.
prev parent reply other threads:[~2025-02-26 5:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 14:53 [PATCH net-next v06 0/1] net: hinic3: Add a driver for Huawei 3rd gen NIC Gur Stavi
2025-02-25 14:53 ` [PATCH net-next v06 1/1] hinic3: module initialization and tx/rx logic Gur Stavi
2025-02-25 16:00 ` Joe Damato
2025-02-26 8:41 ` Gur Stavi
2025-02-26 0:23 ` Jakub Kicinski
2025-02-26 6:08 ` Gur Stavi
2025-02-26 6:14 ` Gur Stavi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250226061406.648948-1-gur.stavi@huawei.com \
--to=gur.stavi@huawei.com \
--cc=andrew+netdev@lunn.ch \
--cc=cai.huoqing@linux.dev \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gongfan1@huawei.com \
--cc=guoxin09@huawei.com \
--cc=helgaas@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luosifu@huawei.com \
--cc=meny.yossefi@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=shenchenyang1@hisilicon.com \
--cc=shijing34@huawei.com \
--cc=sumang@marvell.com \
--cc=wulike1@huawei.com \
--cc=zhoushuai28@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®