From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BA09216397 for ; Wed, 26 Feb 2025 12:29:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740572954; cv=none; b=CRqynyb8iBRl7zwSh4FXh1ntUKflHqcdlk2E4bIp9ArZNeK0zaWLgpVS9Evhv7BjhJXgktXLS9XW9QJg7bl4/PO4jQdFQUaCZOBfbydrV7pcLxCWJK+VKnxAOWs3tjJrGS7NvOLjvr8HgmI7Ru19t/VLW9PAIz87n2frIpM8uFU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740572954; c=relaxed/simple; bh=3tPTH0OfW1bXXoDhOFEtxf7pDN2l1bHuBEJiQV3Y4kc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HrkVLLdb5maV1J83SfzTHhSCL903pAMS+eIBv2ViFzTOQj9qPWhOSvH2zHfcwOCc3SUYjhHT7bYpXUcXWaZ4mMykSfQUZME4dBbe86Y4zm+4VUzFfYIWY1DCAPg1d1U+bRzUUZi3uKZ+bVPYNi1eUfIPlM/mzSHiu4PzD9MJgxo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GIf4v6Ma; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GIf4v6Ma" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740572950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YqtUsmTYfSl8QjL4A92EdoUfNd8iKRnEclZHB/5oJQc=; b=GIf4v6MaC8EmwdwyunN157x5d0PciwgSfRDwuLacPOPDKs3bgUSgL/upyrt60uFWt9Duzb bqim0vcGg5T0qV2FNES6nccmnbrdQ5SNlxxdCBuuXlD0uifbeocibCuXM4UM9k3sDxxcXk RXq4dp61DUMCTLIvFN8vgFj6IC5Smw8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-106-GCwjoy2ePGOrOD0k2l92tA-1; Wed, 26 Feb 2025 07:29:08 -0500 X-MC-Unique: GCwjoy2ePGOrOD0k2l92tA-1 X-Mimecast-MFC-AGG-ID: GCwjoy2ePGOrOD0k2l92tA_1740572948 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43942e82719so48672205e9.2 for ; Wed, 26 Feb 2025 04:29:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740572947; x=1741177747; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YqtUsmTYfSl8QjL4A92EdoUfNd8iKRnEclZHB/5oJQc=; b=FgmNg5y3OYQ+a6GTKa7paJftfYAzw+yUoYZDQXBi5yS5k8K3Tl/hZy7Y4N0KevBC8T gO3YI9/w9M/0wcvvMSIzmdBaQRUFbz5VdJmSsWh4RKuy+TsPRfs3YUd/yITCx3dIaF48 D0EIbXzwZ6lh5jNEzocKXFAHkd6+5xY01FG/SNu2LkrUaF+qrdTj2IcSg+lTf5wo1JAG UOEjFHjy3L3AD6vhasPoeNT9XA2KU6VoGLWM9j+nMl1q0PquLmPPSCrX41Zer7yfYSTX 8RAXpwOI19g3CG3HPaS/YeY1t416uoVpLPpfRboy3ltKyKM0qLVQHxet8ZJuLt+SxQ8V U0kw== X-Forwarded-Encrypted: i=1; AJvYcCVYfp4mAZZYxW7raznVDPrvdr6jYZsfKMEpvf2f4aEF2dqEp+m4l/K6gXBdresuiOG5j5JtgCUCYk0YtPk=@vger.kernel.org X-Gm-Message-State: AOJu0YztWsZi+dr7y3w6WK1nB6W0Mxs9HBYNWITBYja89/TTvT1EFcxD cff+VqtYirud4F7E2ukL3opw2+Qbhsl/+CLi21OLAWgCaT7HLlgkvkvM3YzrVVnmJxnG3QoPVTV uTOEQV6LfCqbDFf3Y5kQDLFtrVhJJMXeQrghau2wE3mRGKLHjkRDepBmVMC6Opg== X-Gm-Gg: ASbGncs3GTi0q12BzUykC4tVQt9ZA1jynVfKyQohQq1A7td6U1HiENCk9QMVYvuxks5 5nTq8qpmYaZmgbdwfsJGeIvDMCdwmaBgw6MDB6ZH33jGresSOknd1NaNJx1Ufp02FVmNWvaWDl/ ETff52iqQj/n/1rcDSij7Dxf3roEnIBNwB9aVGeG92S2wsRJ+AzD6niGN2cPh4jpuzfwyVp9Je+ imPlyUy/JfdR8iI1DPnK21uxE9OUKi22hgiUcSCWoI3n8sURSzAviGwgmsYi6K/wXBms5bDFZEK LFENHxtoijuqDllHs9fQXDbVjQ176AtnpejEx3M7OMvbEBRkt8gf4yqFOhJxIB4= X-Received: by 2002:a05:600c:35d6:b0:439:985b:17d6 with SMTP id 5b1f17b1804b1-43ab903603emr23927975e9.27.1740572947511; Wed, 26 Feb 2025 04:29:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IEOqU6+YvkXlQ4vuTagbuCtwCjwmj0H5+Xta6YoRzeguoUafKp6W738/ohg4cf/c9smG6tt4g== X-Received: by 2002:a05:600c:35d6:b0:439:985b:17d6 with SMTP id 5b1f17b1804b1-43ab903603emr23927655e9.27.1740572947018; Wed, 26 Feb 2025 04:29:07 -0800 (PST) Received: from imammedo.users.ipa.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba5711dfsm19946945e9.27.2025.02.26.04.29.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2025 04:29:06 -0800 (PST) Date: Wed, 26 Feb 2025 13:29:05 +0100 From: Igor Mammedov To: Mauro Carvalho Chehab Cc: Jonathan Cameron , "Michael S . Tsirkin" , Shiju Jose , , , Philippe =?UTF-8?B?TWF0?= =?UTF-8?B?aGlldS1EYXVkw6k=?= , Ani Sinha , Cleber Rosa , Dongjiu Geng , Eduardo Habkost , Eric Blake , John Snow , Marcel Apfelbaum , "Markus Armbruster" , Michael Roth , "Paolo Bonzini" , Peter Maydell , Shannon Zhao , Yanan Wang , Zhao Liu , , , Gavin Shan Subject: Re: [PATCH v3 00/14] Change ghes to use HEST-based offsets and add support for error inject Message-ID: <20250226132905.47aa50d2@imammedo.users.ipa.redhat.com> In-Reply-To: <20250226105628.7e60f952@foz.lan> References: <20250203110934.000038d8@huawei.com> <20250203162236.7d5872ff@imammedo.users.ipa.redhat.com> <20250221073823.061a1039@foz.lan> <20250221102127.000059e6@huawei.com> <20250225110115.6090e416@imammedo.users.ipa.redhat.com> <20250226105628.7e60f952@foz.lan> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 26 Feb 2025 10:56:28 +0100 Mauro Carvalho Chehab wrote: > Em Tue, 25 Feb 2025 11:01:15 +0100 > Igor Mammedov escreveu: > > > On Fri, 21 Feb 2025 10:21:27 +0000 > > Jonathan Cameron wrote: > > > > > On Fri, 21 Feb 2025 07:38:23 +0100 > > > Mauro Carvalho Chehab wrote: > > > > > > > Em Mon, 3 Feb 2025 16:22:36 +0100 > > > > Igor Mammedov escreveu: > > > > > > > > > On Mon, 3 Feb 2025 11:09:34 +0000 > > > > > Jonathan Cameron wrote: > > > > > > > > > > > On Fri, 31 Jan 2025 18:42:41 +0100 > > > > > > Mauro Carvalho Chehab wrote: > > > > > > > > > > > > > Now that the ghes preparation patches were merged, let's add support > > > > > > > for error injection. > > > > > > > > > > > > > > On this series, the first 6 patches chang to the math used to calculate offsets at HEST > > > > > > > table and hardware_error firmware file, together with its migration code. Migration tested > > > > > > > with both latest QEMU released kernel and upstream, on both directions. > > > > > > > > > > > > > > The next patches add a new QAPI to allow injecting GHESv2 errors, and a script using such QAPI > > > > > > > to inject ARM Processor Error records. > > > > > > > > > > > > > > If I'm counting well, this is the 19th submission of my error inject patches. > > > > > > > > > > > > Looks good to me. All remaining trivial things are in the category > > > > > > of things to consider only if you are doing another spin. The code > > > > > > ends up how I'd like it at the end of the series anyway, just > > > > > > a question of the precise path to that state! > > > > > > > > > > if you look at series as a whole it's more or less fine (I guess you > > > > > and me got used to it) > > > > > > > > > > however if you take it patch by patch (as if you've never seen it) > > > > > ordering is messed up (the same would apply to everyone after a while > > > > > when it's forgotten) > > > > > > > > > > So I'd strongly suggest to restructure the series (especially 2-6/14). > > > > > re sum up my comments wrt ordering: > > > > > > > > > > 0 add testcase for HEST table with current HEST as expected blob > > > > > (currently missing), so that we can be sure that we haven't messed > > > > > existing tables during refactoring. > > > > > > To potentially save time I think Igor is asking that before you do anything > > > at all you plug the existing test hole which is that we don't test HEST > > > at all. Even after this series I think we don't test HEST. You add > > > a stub hest and exclusion but then in patch 12 the HEST stub is deleted whereas > > > it should be replaced with the example data for the test. > > > > that's what I was saying. > > HEST table should be in DSDT, but it's optional and one has to use > > 'ras=on' option to enable that, which we aren't doing ATM. > > So whatever changes are happening we aren't seeing them in tests > > nor will we see any regression for the same reason. > > > > While white listing tables before change should happen and then updating them > > is the right thing to do, it's not sufficient since none of tests > > run with 'ras' enabled, hence code is not actually executed. > > Ok. Well, again we're not modifying HEST table structure on this > changeset. The only change affecting HEST is when the number of entries > increased from 1 to 2. > > Now, looking at bios-tables-test.c, if I got it right, I should be doing > something similar to the enclosed patch, right? > > If so, I have a couple of questions: > > 1. from where should I get the HEST table? dumping the table from the > running VM? > > 2. what values should I use to fill those variables: > > int hest_offset = 40 /* HEST */; > int hest_entry_size = 4; you don't need to do that, bios-tables-test will dump all ACPI tables for you automatically, you only need to add or extend a test with ras=on option. 1: 1st add empty table and whitelist it ("tests/data/acpi/aarch64/virt/HEST") 2: enable ras in existing tescase --- a/tests/qtest/bios-tables-test.c +++ b/tests/qtest/bios-tables-test.c @@ -2123,7 +2123,8 @@ static void test_acpi_aarch64_virt_tcg(void) data.smbios_cpu_max_speed = 2900; data.smbios_cpu_curr_speed = 2700; test_acpi_one("-cpu cortex-a57 " - "-smbios type=4,max-speed=2900,current-speed=2700", &data); + "-smbios type=4,max-speed=2900,current-speed=2700 " + "-machine ras=on", &data); free_test_data(&data); } then with installed IASL run V=1 QTEST_QEMU_BINARY=./qemu-system-aarch64 ./tests/qtest/bios-tables-test to see diff 3: rebuild tables and follow the rest of procedure to update expected blobs as described in comment at the top of (tests/qtest/bios-tables-test.c) I'd recommend to add 3 patches as the beginning of the series, that way we can be sure that if something changes unintentionally it won't go unnoticed. > > > > > > > > > That indeed doesn't address testing the error data storage which would be > > > a different problem. > > > > I'd skip hardware_errors/CPER testing from QEMU unit tests. > > That's basically requires functioning 'APEI driver' to test that. > > > > Maybe we can use Ani's framework to parse HEST and all the way > > towards CPER record(s) traversal, but that's certainly out of > > scope of this series. > > It could be done on top, but I won't insist even on that > > since Mauro's out of tree error injection testing will > > cover that using actual guest (which I assume he would > > like to run periodically). > > Yeah, my plan is to periodically test it. I intend to setup somewhere > a CI to test Kernel, QEMU and rasdaemon altogether. > > Thanks, > Mauro > > --- > > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c > index 0a333ec43536..31e69d906db4 100644 > --- a/tests/qtest/bios-tables-test.c > +++ b/tests/qtest/bios-tables-test.c > @@ -210,6 +210,8 @@ static void test_acpi_fadt_table(test_data *data) > uint32_t val; > int dsdt_offset = 40 /* DSDT */; > int dsdt_entry_size = 4; > + int hest_offset = 40 /* HEST */; > + int hest_entry_size = 4; > > g_assert(compare_signature(&table, "FACP")); > > @@ -242,6 +244,12 @@ static void test_acpi_fadt_table(test_data *data) > /* update checksum */ > fadt_aml[9 /* Checksum */] = 0; > fadt_aml[9 /* Checksum */] -= acpi_calc_checksum(fadt_aml, fadt_len); > + > + > + > + acpi_fetch_table(data->qts, &table.aml, &table.aml_len, > + fadt_aml + hest_offset, hest_entry_size, "HEST", true); > + g_array_append_val(data->tables, table); > } > > static void dump_aml_files(test_data *data, bool rebuild) > @@ -2411,7 +2419,7 @@ static void test_acpi_aarch64_virt_oem_fields(void) > }; > char *args; > > - args = test_acpi_create_args(&data, "-cpu cortex-a57 "OEM_TEST_ARGS); > + args = test_acpi_create_args(&data, "-ras on -cpu cortex-a57 "OEM_TEST_ARGS); > data.qts = qtest_init(args); > test_acpi_load_tables(&data); > test_oem_fields(&data); >