From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2F36270024 for ; Thu, 27 Feb 2025 09:50:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740649854; cv=none; b=c0gmPInvj7H8bUgEPp/wnOn6t986yLS3l+Ivth6R/Ldow+L6X3sTs0sX1dGyOFQK4QlftG3/RoJ/JiTgF2X3ICJ4RSDfVLfUyCKFEACl1gNqqgOBIics4zMr/+V5aGM7g0NnPXG2Ugeyf13qxJ6Z0plriz42w4Zrs1G8F4s/ybE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740649854; c=relaxed/simple; bh=LYL9cYL6rj6biQ2SWuMn4r7Oi5SZYKYmnfyqUvUiymA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LVmTVLvvUHf9GmH71HmpZYJGSvxIhri4V2Va2jIrjsryCikJP46DeNVjVRu461SoPWyHNwA2EAYqOygbPv/sQ3gkGz7gqKtZmXCe1MQd8uqjVKUbUg0DycSu82gQuTJs+B0XRwMEypJehNqvsodedWFZySGiOGFNYKx5rLhKtE0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UPKGURUM; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UPKGURUM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740649851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LWAZvimGNk1tF+ANGXTAMRK6KN/D4dhCfoJh3bD4+uw=; b=UPKGURUMSPMiHYKZDWnrCDZUM4jUrkxBwn5p3vsw7M6aHfg/IlX4roCWiVhiEMTFiMXRS7 PbnSBZuEp+dSryPIZk1LtUre3krHmh0/UVd8eEidJ4BvSXpXzySjj9iEIag8KBdTKV1BR+ /8Q7O3Ovg2SzXJ80XI3w+Umwyr/WIBs= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-449-Pm_SPCUhOVGPJYG0ec9owQ-1; Thu, 27 Feb 2025 04:50:50 -0500 X-MC-Unique: Pm_SPCUhOVGPJYG0ec9owQ-1 X-Mimecast-MFC-AGG-ID: Pm_SPCUhOVGPJYG0ec9owQ_1740649849 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-38f3bac2944so285718f8f.3 for ; Thu, 27 Feb 2025 01:50:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740649848; x=1741254648; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LWAZvimGNk1tF+ANGXTAMRK6KN/D4dhCfoJh3bD4+uw=; b=lHzVHdd38KxVHNNBGDwB8MnMINystmeproy0Uf2yRj3tJZVl01G7ERSBs7YDRxQz6s amQLA4sjuB1XY2x1i+6iZMBz0rtZwJ2DGcg+9iWtpHeVxxl/e3EqBXWZN3Z/2EcR8fxk 8kXoum4BRXk1k+Ea2WP/o0EqKh49qN/CDyK207W6K05hn1Nlq3KwtdZ/yyTQgnxwPPlD nxwV8+iSYpkJn+R606XyVQn9XaBbnTsv7ekwti0hZw0Sd5egrlk16BCtidj1ZO2KGezB iQEdX3slMcB37xqATFoCnPpeYmHP+mrbFlOLxzo1v+6vYHaqH6eSVuf0tkfVYJGAhMYJ Obuw== X-Forwarded-Encrypted: i=1; AJvYcCX/we+RkN2shW/xKp8B0UUFh9rIqcg2yoI7l//jasv0NC8clNunZbpiQ9vceDVABQbujJA8kg6EqKezswQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6+h7XKuNKm83GjcHuHsRRopu6vmIMLMFRtOQVLT1SNCwQ6BnW k0Z3Ley03ZPRjzQwF5vC1g6Ye+kuADMgxX7eYbPraTfQhzcW8iK1cVCn10kEiNlQeXmFpXZdpHL o+tizgTMldzWU4cTgsbuUi1sYQzWUT6H94l8wgfKk0PKWc4alj88072SnrD07ztBYw1OsWQ== X-Gm-Gg: ASbGncvhWc0kAW7IXOSCKLnqdy0SI6FJQ0liYgp2ZoszAhud3t3G+mocBgS77pb9OT4 y8IFiTSnw08tlLid9IHJIJCu++BYgUari50gZKBKMHXgGZuDWklP2kfzffr4IlpQ12gwEYfkwa/ DHv43rRof/jmHHXYdiZt7GTv8CzdKIHyi9ZvtzvmRxa8HLDx6Rp89dO/PEYX9WCYjdvpoG0HGa2 jJZi90s/HIn4pP3palZZ2a02BhNhxzyijlOLuC22iebY0OgdcP8RQSzJ5vZqM3jn9AK2u0N2tGN ti3Mlx5VlC1xK1k4sk3FiwwaOI0oVgSCcAKQZ45LZLDIet6S8uvx+4EerY1J3KY= X-Received: by 2002:a05:6000:1acf:b0:38d:c2d4:2399 with SMTP id ffacd0b85a97d-390d4f84abamr5489407f8f.41.1740649848471; Thu, 27 Feb 2025 01:50:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IHSS29mgKIIJPNubRNiu6XSsP4jRdBTsm+jLItodsOd+ON4krsICtKTwhV6diQM03lS5OYCZA== X-Received: by 2002:a05:6000:1acf:b0:38d:c2d4:2399 with SMTP id ffacd0b85a97d-390d4f84abamr5489383f8f.41.1740649848097; Thu, 27 Feb 2025 01:50:48 -0800 (PST) Received: from imammedo.users.ipa.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390e47965ddsm1532686f8f.18.2025.02.27.01.50.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2025 01:50:47 -0800 (PST) Date: Thu, 27 Feb 2025 10:50:46 +0100 From: Igor Mammedov To: Mauro Carvalho Chehab Cc: "Michael S . Tsirkin" , Jonathan Cameron , Shiju Jose , qemu-arm@nongnu.org, qemu-devel@nongnu.org, Philippe =?UTF-8?B?TWF0aGll?= =?UTF-8?B?dS1EYXVkw6k=?= , Ani Sinha , Eduardo Habkost , Marcel Apfelbaum , Peter Maydell , Shannon Zhao , Yanan Wang , Zhao Liu , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 08/14] acpi/generic_event_device: add logic to detect if HEST addr is available Message-ID: <20250227105046.3c67b7c2@imammedo.users.ipa.redhat.com> In-Reply-To: <20250227082638.7db90257@foz.lan> References: <20250226165226.49b88429@imammedo.users.ipa.redhat.com> <20250227081927.726a1938@foz.lan> <20250227082638.7db90257@foz.lan> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 27 Feb 2025 08:26:38 +0100 Mauro Carvalho Chehab wrote: > Em Thu, 27 Feb 2025 08:19:27 +0100 > Mauro Carvalho Chehab escreveu: > > > Em Wed, 26 Feb 2025 16:52:26 +0100 > > Igor Mammedov escreveu: > > > > > On Fri, 21 Feb 2025 15:35:17 +0100 > > > Mauro Carvalho Chehab wrote: > > > > > > > > > diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c > > > > index 5346cae573b7..14d8513a5440 100644 > > > > --- a/hw/acpi/generic_event_device.c > > > > +++ b/hw/acpi/generic_event_device.c > > > > @@ -318,6 +318,7 @@ static void acpi_ged_send_event(AcpiDeviceIf *adev, AcpiEventStatusBits ev) > > > > > > > > static const Property acpi_ged_properties[] = { > > > > DEFINE_PROP_UINT32("ged-event", AcpiGedState, ged_event_bitmap, 0), > > > > + DEFINE_PROP_BOOL("x-has-hest-addr", AcpiGedState, ghes_state.use_hest_addr, false), > > > > > > you below set it for 9.2 to false, so > > > shouldn't it be set to true by default here? > > > > Yes, but it is too early to do that here, as the DSDT table was not > > updated to contain the GED device. > > > > We're switching it to true later on, at patch 11:: > > > > d8c44ee13fbe ("arm/virt: Wire up a GED error device for ACPI / GHES") After sleeping on it, what you did here is totally correct. You are right, We can't really flip switch to true here since without 11/14 APEI will stop working properly. Perhaps add to commit message a note explaining why it's false in this patch and where it will be set to true. > > Hmm... too many rebases that on my head things are becoming shady ;-) > > Originally, this was setting it to true, but you requested to move it > to another patch during one of the patch reorder requests. > > Anyway, after all those rebases, I guess it is now safe to set it > to true here without breaking bisectability. I'll move the hunk back > to this patch. > > Thanks, > Mauro >