mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Costa Shulyupin <costa.shul@redhat.com>
Cc: John Kacur <jkacur@redhat.com>, Tomas Glozar <tglozar@redhat.com>,
	"Luis Claudio R. Goncalves" <lgoncalv@redhat.com>,
	Eder Zulian <ezulian@redhat.com>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] rtla: Save trace when option `--trace` is specified
Date: Thu, 27 Feb 2025 20:06:31 -0500	[thread overview]
Message-ID: <20250227200623.60f20571@gandalf.local.home> (raw)
In-Reply-To: <20250127170251.744751-1-costa.shul@redhat.com>

On Mon, 27 Jan 2025 19:02:40 +0200
Costa Shulyupin <costa.shul@redhat.com> wrote:

> +++ b/tools/tracing/rtla/src/osnoise_hist.c
> @@ -981,12 +981,11 @@ int osnoise_hist_main(int argc, char *argv[])
>  
>  	return_value = 0;
>  
> -	if (osnoise_trace_is_off(tool, record)) {
> +	if (osnoise_trace_is_off(tool, record))
>  		printf("rtla osnoise hit stop tracing\n");
> -		if (params->trace_output) {
> -			printf("  Saving trace to %s\n", params->trace_output);
> -			save_trace_to_file(record->trace.inst, params->trace_output);
> -		}
> +	if (params->trace_output) {
> +		printf("  Saving trace to %s\n", params->trace_output);
> +		save_trace_to_file(record->trace.inst, params->trace_output);
>  	}

Without tracing being off, this can run forever if the events come in
faster than it can be recorded. And save trace uses the "trace" file, which
is slow to read.

Are you sure you want that?

-- Steve

  reply	other threads:[~2025-02-28  1:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-27 17:02 Costa Shulyupin
2025-02-28  1:06 ` Steven Rostedt [this message]
2025-03-03 15:34   ` Tomas Glozar
2025-03-03 15:54     ` Costa Shulyupin
2025-03-04  8:03       ` Tomas Glozar
2025-03-03 20:03     ` Steven Rostedt
2025-03-04  8:00       ` Tomas Glozar
2025-03-04  8:16         ` Tomas Glozar
2025-03-04 17:10           ` Steven Rostedt
2025-05-01 14:42             ` Steven Rostedt
2025-05-01 18:12               ` Costa Shulyupin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250227200623.60f20571@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=costa.shul@redhat.com \
    --cc=dan.carpenter@linaro.org \
    --cc=ezulian@redhat.com \
    --cc=jkacur@redhat.com \
    --cc=lgoncalv@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=tglozar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®