From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CD80276D02 for ; Fri, 28 Feb 2025 14:07:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751646; cv=none; b=EjQsLBnXrpA4OqMc+eiXq47m1jRC7ZR8sTYQx+2aZ+aaHAFTYjWtNfEfCm2SfmcUkdd9pzPypuDSxbcFITQS2K47YrNmHEhEQcVMc5BysalNT0XRLvS2ky2fbGI4Vt7Twcf4cstFpx4vGlnlHBdgZNWxnTZTtxg2AgzXjYBc9/s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751646; c=relaxed/simple; bh=D6dkdQq4iA5tj9KDLaYBN/k9ZLQ40l8wYqCnUHgdGG0=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=RtFU2wPVQeWGj+GwqEyAJstDX7jx+LY3H1lrRhTCCzFd5zu2SiYPGFFGpWsvXvMU2KlKw4h812NYNcQFyVadcMWCro29ZBpo4GGX+pso04bXCYbKZU4W51zHeaGORaW3Rhu7Gvx3rA2M1nIUreGBkppai3SB2oBoMGFKEjoTYVs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Krie4Osc; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Krie4Osc" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5e0505275b7so3366976a12.3 for ; Fri, 28 Feb 2025 06:07:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751642; x=1741356442; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=xhLZqgcaujiFhw9G1dCH5p0FiLmGyvslkaMt4uwl9Do=; b=Krie4Osc0DNEinlUAyFTqNzopM5rxbSDXSx+7/YIPnjHeGkHfJbBSUjo5mkF1GKs4q mIrLqoS2F1GPTgXE54L9i6ipSA6qu45Gv9Gj/Jd5dt9ragEQW6UOGl4Cxge2DF6kbgnO GEd/s4zk+TUhPxnvMcjBFvEuok4LJx77ZKCXFieXx3nkrw1uiu3AnSEIUmzN37Sd4E2K 3L9qQIZY4xgnsISUYWuiKGDEyBTxjJEvgyRlJ+0CpB99LzLqq4iCOaMyUjaqL+OyjQE/ IFHVKBpQaQce3fOlqgVaoZI4DddaF1r6ZwiFzNyrWLy4L+0ZYllhH3UXHyok3o4tJpNF TQEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751642; x=1741356442; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xhLZqgcaujiFhw9G1dCH5p0FiLmGyvslkaMt4uwl9Do=; b=lqguEetC+r3Lc5pxVHdXLicIGBXPbIwP+Ds8ZglqL3L8XVlz7/xwIZyr8rtkMzDmeO NwdOONnpdUmAzXrMRmRAkOwzi3MNsGUka8Q3+49mUW++ud7EAG6wjcEacz4Vubj5yMew 0y3RpFkg2hmewNBp1jvkO43LaxTJi0F1hT/p/1asnoQviojO1f67ogOQR+iOvTRtgMv/ GBnd/Oys7t/pVuTMoMN+VKc8q77i5+1pRr+rJ+K8uIJNOQwW2t3p/D5bO2Wq72yeOwwJ YG98nALdi3yaGi2ajMt1vu9RolKHVPkVRVElvd10+iYlEp3QiG3Ol+9JHC5x3nIdzkMk cd4g== X-Gm-Message-State: AOJu0YzI9t4PARZcoA23rgqBuBcW7CZacrowrQKQsuguqbZ4uCarbydC asZ6afiRe3qwc9I+Gi7Q839Idj83LdCA54BPXGo8btAKsamhpyP9PawOJtVk1nY= X-Gm-Gg: ASbGncu4sUv9HbbbdL9A3OmBeyImPmeCYDC80n3iMWy2+o2N3QPZQe55jKST9LuJ7W3 ohNIg0GVwEsndfepOP8rdJVviKYzWqbtcC4ttMVfZmMltajCNEgsoCKMHxCebA1YQOk74NeSfl8 0mHmcT7PfzgpHk/NejkUnWvKXPJOkJ7qPyLuzalXYBn8JzmTd62qZZMxY0BNwE42mZMKmQAC3Ae q4SocclQCH4Cio2YATsTr0ihpGx07qB99G5wDDkV43ZHbEidS2JlA8gwopRgS/njAdCsmhbDb0R 5wqIGT54fecwZx/oHKkYSX3vwPYB24UBrT2RHsmNDY+HRJliY1Z7mzAmi7LaGiO3pbTq5cAK9f1 yx6nC27GkfQ== X-Google-Smtp-Source: AGHT+IHP7pUAJMVQB1Guj47dyI47K7YXQj82SFh5z5QQxgHATc6r4NQ1/TjLpJM/Ncf+/B2eBWDZ7w== X-Received: by 2002:a05:6402:5242:b0:5e4:cfb0:f667 with SMTP id 4fb4d7f45d1cf-5e4d6b691d6mr2481074a12.21.1740751641613; Fri, 28 Feb 2025 06:07:21 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:21 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Subject: [PATCH 00/18] a few rtc driver cleanups Date: Fri, 28 Feb 2025 14:07:13 +0000 Message-Id: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-B4-Tracking: v=1; b=H4sIABHDwWcC/x3MQQqAIBBA0avIrBN0SoiuEi3MphoIE60IxLsnL d/i/wyJIlOCQWSI9HDi01foRoDbrd9I8lINqNAoxF7Gy0l3kPV3SFKjU7PR2JLtoCYh0srvvxu nUj6cRcJTXgAAAA== X-Change-ID: 20250228-rtc-cleanups-12c0b5123ea4 To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 Hi, While looking at RTC, I noticed that various drivers are keeping pointers to data that they're not using themselves throughout their lifetime. So I took the liberty to drop these pointers and this series is the result. The last two patches also convert two drivers to using dev_err_probe(), as I looked slightly closer into those two. They don't exactly fit the general subject of removal of unneeded pointers, but I wanted to share them anyway, since they're ready. All of this was compile-tested only. Cheers, Andre' Signed-off-by: André Draszik --- André Draszik (18): rtc: max77686: drop needless struct max77686_rtc_info::rtc member rtc: s5m: drop needless struct s5m_rtc_info::i2c member rtc: aspeed: drop needless struct aspeed_rtc::rtc_dev member rtc: ds2404: drop needless struct ds2404::rtc member rtc: ep93xx: drop needless struct ep93xx_rtc::rtc member rtc: ftrtc010: drop needless struct ftrtc010_rtc::rtc_dev member rtc: m48t86: drop needless struct m48t86_rtc_info::rtc member rtc: meson: drop needless struct meson_rtc::rtc member rtc: meson-vrtc: drop needless struct meson_vrtc_data::rtc member rtc: pl030: drop needless struct pl030_rtc::rtc member rtc: rx8581: drop needless struct rx8581::rtc member rtc: s35390a: drop needless struct s35390a::rtc member rtc: sd2405al: drop needless struct sd2405al::rtc member rtc: sd3078: drop needless struct sd3078::rtc member rtc: rx8581: drop needless struct rx8581 rtc: sd3078: drop needless struct sd3078 rtc: max77686: use dev_err_probe() where appropriate rtc: s5m: convert to dev_err_probe() where appropriate drivers/rtc/rtc-aspeed.c | 16 ++++----- drivers/rtc/rtc-ds2404.c | 14 ++++---- drivers/rtc/rtc-ep93xx.c | 16 ++++----- drivers/rtc/rtc-ftrtc010.c | 17 +++++---- drivers/rtc/rtc-m48t86.c | 14 ++++---- drivers/rtc/rtc-max77686.c | 37 +++++++++---------- drivers/rtc/rtc-meson-vrtc.c | 12 +++---- drivers/rtc/rtc-meson.c | 16 ++++----- drivers/rtc/rtc-pl030.c | 14 ++++---- drivers/rtc/rtc-rx8581.c | 85 +++++++++++++++++++------------------------- drivers/rtc/rtc-s35390a.c | 22 ++++++------ drivers/rtc/rtc-s5m.c | 58 +++++++++++++----------------- drivers/rtc/rtc-sd2405al.c | 16 ++++----- drivers/rtc/rtc-sd3078.c | 71 +++++++++++++++--------------------- 14 files changed, 183 insertions(+), 225 deletions(-) --- base-commit: 0226d0ce98a477937ed295fb7df4cc30b46fc304 change-id: 20250228-rtc-cleanups-12c0b5123ea4 Best regards, -- André Draszik