From: Neeraj Upadhyay <Neeraj.Upadhyay@amd.com>
To: <kvm@vger.kernel.org>, <seanjc@google.com>, <pbonzini@redhat.com>
Cc: <linux-kernel@vger.kernel.org>, <Thomas.Lendacky@amd.com>,
<nikunj@amd.com>, <Santosh.Shukla@amd.com>,
<Vasant.Hegde@amd.com>, <Suravee.Suthikulpanit@amd.com>,
<bp@alien8.de>, <David.Kaplan@amd.com>, <huibo.wang@amd.com>,
<naveen.rao@amd.com>, <pgonda@google.com>,
<linux-kselftest@vger.kernel.org>, <shuah@kernel.org>
Subject: [RFC PATCH 21/31] KVM: selftests: Add IPI handling support for Secure AVIC
Date: Fri, 28 Feb 2025 15:00:14 +0530 [thread overview]
Message-ID: <20250228093024.114983-22-Neeraj.Upadhyay@amd.com> (raw)
In-Reply-To: <20250228093024.114983-1-Neeraj.Upadhyay@amd.com>
Add support for handling INCOMPLET_IPI #VC exception
handling for Secure AVIC guests. This allows sending
cross-vCPU IPI, using all destination shorthands (broadcast,
fixed) and destination modes (logical/physical) between
Secure AVIC enabled vCPUs. In addition, cross-vCPU NMI
using APIC_ICR writes are supported.
Signed-off-by: Neeraj Upadhyay <Neeraj.Upadhyay@amd.com>
---
tools/testing/selftests/kvm/lib/x86/savic.c | 112 ++++++++++++++++++++
1 file changed, 112 insertions(+)
diff --git a/tools/testing/selftests/kvm/lib/x86/savic.c b/tools/testing/selftests/kvm/lib/x86/savic.c
index 141d31637e51..8259f7521e73 100644
--- a/tools/testing/selftests/kvm/lib/x86/savic.c
+++ b/tools/testing/selftests/kvm/lib/x86/savic.c
@@ -43,6 +43,12 @@ enum lapic_lvt_entry {
#define MSR_AMD64_SECURE_AVIC_ALLOWED_NMI_BIT 1
#define SVM_EXIT_AVIC_UNACCELERATED_ACCESS 0x402
+#define SVM_EXIT_AVIC_INCOMPLETE_IPI 0x401
+
+#define REG_OFF(VEC) (VEC / 32 * 16)
+#define VEC_POS(VEC) (VEC % 32)
+
+#define SAVIC_NMI_REQ_OFFSET 0x278
/*
* Initial pool of guest apic backing page.
@@ -336,6 +342,105 @@ static void handle_savic_unaccel_access(struct ex_regs *regs)
}
}
+static void send_ipi(int cpu, int vector, bool nmi)
+{
+ struct guest_apic_page *apic_page;
+
+ apic_page = &apic_page_pool->guest_apic_page[cpu];
+
+ if (nmi)
+ savic_write_reg(apic_page, SAVIC_NMI_REQ_OFFSET, 1);
+ else
+ savic_write_reg(apic_page, APIC_IRR + REG_OFF(vector), BIT(VEC_POS(vector)));
+}
+
+static bool is_cpu_present(int cpu)
+{
+ struct guest_apic_page *apic_page;
+
+ if (cpu >= KVM_MAX_VCPUS)
+ return false;
+
+ apic_page = &apic_page_pool->guest_apic_page[cpu];
+
+ return savic_read_reg(apic_page, APIC_ID) != 0;
+}
+
+static void savic_send_ipi_all_but(int vector, bool nmi)
+{
+ int cpu;
+ int mycpu = x2apic_read_reg(APIC_ID);
+
+ for (cpu = 0; cpu < KVM_MAX_VCPUS; cpu++) {
+ if (cpu == mycpu)
+ continue;
+ if (!(cpu == 0 || is_cpu_present(cpu)))
+ break;
+ send_ipi(cpu, vector, nmi);
+ }
+}
+
+static bool ipi_match_dest(uint32_t dest, bool logical, int dest_cpu)
+{
+ struct guest_apic_page *apic_page;
+
+ apic_page = &apic_page_pool->guest_apic_page[dest_cpu];
+ uint32_t ldr;
+
+ if (logical) {
+ ldr = savic_read_reg(apic_page, APIC_LDR);
+ return ((ldr >> 16) == (dest >> 16)) &&
+ (ldr & dest & 0xffff) != 0;
+ } else {
+ return dest == savic_read_reg(apic_page, APIC_ID);
+ }
+}
+
+static void savic_send_ipi_target(uint32_t dest, int vector, bool logical,
+ bool nmi)
+{
+ int cpu;
+ int mycpu = x2apic_read_reg(APIC_ID);
+
+ for (cpu = 0; cpu < KVM_MAX_VCPUS; cpu++) {
+ if (cpu == mycpu) {
+ continue;
+ }
+ if (!(cpu == 0 || is_cpu_present(cpu)))
+ break;
+ if (ipi_match_dest(dest, logical, cpu))
+ send_ipi(cpu, vector, nmi);
+ }
+}
+
+static void savic_handle_icr_write(uint64_t icr_data)
+{
+ int dsh = icr_data & APIC_DEST_ALLBUT;
+ int vector = icr_data & APIC_VECTOR_MASK;
+ bool logical = icr_data & APIC_DEST_LOGICAL;
+ bool nmi = (icr_data & APIC_DM_FIXED_MASK) == APIC_DM_NMI;
+ uint64_t self_icr_data = APIC_DEST_SELF | APIC_INT_ASSERT | vector;
+
+ if (nmi)
+ self_icr_data |= APIC_DM_NMI;
+
+ switch (dsh) {
+ case APIC_DEST_ALLINC:
+ savic_send_ipi_all_but(vector, nmi);
+ savic_hv_write_reg(APIC_ICR, icr_data);
+ x2apic_write_reg(APIC_ICR, self_icr_data);
+ break;
+ case APIC_DEST_ALLBUT:
+ savic_send_ipi_all_but(vector, nmi);
+ savic_hv_write_reg(APIC_ICR, icr_data);
+ break;
+ default:
+ savic_send_ipi_target(icr_data >> 32, vector, logical, nmi);
+ savic_hv_write_reg(APIC_ICR, icr_data);
+ break;
+ }
+}
+
void savic_vc_handler(struct ex_regs *regs)
{
uint64_t exit_code = regs->error_code;
@@ -344,6 +449,13 @@ void savic_vc_handler(struct ex_regs *regs)
case SVM_EXIT_AVIC_UNACCELERATED_ACCESS:
handle_savic_unaccel_access(regs);
break;
+ case SVM_EXIT_AVIC_INCOMPLETE_IPI:
+ uint64_t icr_data = regs->rax | (regs->rdx << 32);
+ uint32_t reg = (regs->rcx - APIC_BASE_MSR) << 4;
+
+ GUEST_ASSERT(reg == APIC_ICR);
+ savic_handle_icr_write(icr_data);
+ break;
default:
sev_es_vc_handler(regs);
break;
--
2.34.1
next prev parent reply other threads:[~2025-02-28 9:55 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 9:29 [RFC PATCH 00/31] AMD: Add Secure AVIC KVM selftests Neeraj Upadhyay
2025-02-28 9:29 ` [RFC PATCH 01/31] Add GHCB with setters and getters Neeraj Upadhyay
2025-02-28 9:29 ` [RFC PATCH 02/31] Add arch specific additional guest pages Neeraj Upadhyay
2025-02-28 9:29 ` [RFC PATCH 03/31] Add vm_vaddr_alloc_pages_shared() Neeraj Upadhyay
2025-02-28 9:29 ` [RFC PATCH 04/31] Add GHCB allocations and helpers Neeraj Upadhyay
2025-02-28 9:29 ` [RFC PATCH 05/31] Add is_sev_enabled() helpers Neeraj Upadhyay
2025-02-28 9:29 ` [RFC PATCH 06/31] Add ability for SEV-ES guests to use ucalls via GHCB Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 07/31] KVM: selftests: Fix ghcb_entry returned in ghcb_alloc() Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 08/31] KVM: selftests: Make GHCB entry page size aligned Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 09/31] KVM: selftests: Add support for #VC in x86 exception handlers Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 10/31] KVM: selftests: Add MSR VC handling support for SEV-ES VMs Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 11/31] KVM: selftests: Skip vm_is_gpa_protected() call for APIC MMIO base Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 12/31] KVM: selftests: Add instruction decoding support Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 13/31] " Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 14/31] KVM: selftests: Add MMIO VC exception handling for SEV-ES guests Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 15/31] KVM: selftests: Add instruction decoding for movabs instructions Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 16/31] KVM: selftests: Add SEV guests support in xapic_state_test Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 17/31] KVM: selftests: Add x2apic mode testing in xapic_ipi_test Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 18/31] KVM: selftests: Add SEV VM support " Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 19/31] KVM: selftests: Add Secure AVIC lib Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 20/31] KVM: selftests: Add unaccelerated APIC msrs #VC handling Neeraj Upadhyay
2025-02-28 9:30 ` Neeraj Upadhyay [this message]
2025-02-28 9:30 ` [RFC PATCH 22/31] KVM: selftests: Add args param to kvm_arch_vm_post_create() Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 23/31] KVM: selftests: Add SAVIC GPA notification GHCB call Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 24/31] KVM: selftests: Add Secure AVIC mode to xapic_ipi_test Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 25/31] KVM: selftests: Add Secure AVIC APIC regs test Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 26/31] KVM: selftests: Add test to verify APIC MSR accesses for SAVIC guest Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 27/31] KVM: selftests: Extend savic test with idle halt testing Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 28/31] KVM: selftests: Add IOAPIC tests for Secure AVIC Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 29/31] KVM: selftests: Add cross-vCPU IPI testing for SAVIC guests Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 30/31] KVM: selftests: Add NMI test " Neeraj Upadhyay
2025-02-28 9:30 ` [RFC PATCH 31/31] KVM: selftests: Add MSI injection test for SAVIC Neeraj Upadhyay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250228093024.114983-22-Neeraj.Upadhyay@amd.com \
--to=neeraj.upadhyay@amd.com \
--cc=David.Kaplan@amd.com \
--cc=Santosh.Shukla@amd.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=Vasant.Hegde@amd.com \
--cc=bp@alien8.de \
--cc=huibo.wang@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=naveen.rao@amd.com \
--cc=nikunj@amd.com \
--cc=pbonzini@redhat.com \
--cc=pgonda@google.com \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®