From: Lee Trager <lee@trager.us>
To: Alexander Duyck <alexanderduyck@fb.com>,
Jakub Kicinski <kuba@kernel.org>,
kernel-team@meta.com, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Lee Trager <lee@trager.us>,
Sanman Pradhan <sanman.p211993@gmail.com>,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
Mohsin Bashir <mohsin.bashr@gmail.com>,
Su Hui <suhui@nfschina.com>
Cc: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next 0/3] eth: fbnic: Cleanup macros and string function
Date: Fri, 28 Feb 2025 11:15:25 -0800 [thread overview]
Message-ID: <20250228191935.3953712-1-lee@trager.us> (raw)
We have received some feedback that the macros we use for reading FW mailbox
attributes are too large in scope and confusing to understanding. Additionally
the string function did not provide errors allowing it to silently succeed.
This patch set fixes theses issues.
Lee Trager (3):
eth: fbnic: Prepend TSENE FW fields with FBNIC_FW
eth: fbnic: Update fbnic_tlv_attr_get_string() to work like
nla_strscpy()
eth: fbnic: Replace firmware field macros
drivers/net/ethernet/meta/fbnic/fbnic_fw.c | 109 ++++++++++----------
drivers/net/ethernet/meta/fbnic/fbnic_fw.h | 8 +-
drivers/net/ethernet/meta/fbnic/fbnic_tlv.c | 55 +++++++---
drivers/net/ethernet/meta/fbnic/fbnic_tlv.h | 39 ++-----
4 files changed, 110 insertions(+), 101 deletions(-)
--
2.43.5
next reply other threads:[~2025-02-28 19:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 19:15 Lee Trager [this message]
2025-02-28 19:15 ` [PATCH net-next 1/3] eth: fbnic: Prepend TSENE FW fields with FBNIC_FW Lee Trager
2025-02-28 19:15 ` [PATCH net-next 2/3] eth: fbnic: Update fbnic_tlv_attr_get_string() to work like nla_strscpy() Lee Trager
2025-02-28 19:15 ` [PATCH net-next 3/3] eth: fbnic: Replace firmware field macros Lee Trager
2025-03-05 2:50 ` [PATCH net-next 0/3] eth: fbnic: Cleanup macros and string function Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250228191935.3953712-1-lee@trager.us \
--to=lee@trager.us \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sanman.p211993@gmail.com \
--cc=suhui@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®