From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Lyude Paul <lyude@redhat.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>, Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
Jani Nikula <jani.nikula@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
Jani Nikula <jani.nikula@intel.com>
Subject: [PATCH RFC v2 0/7] drm/display: dp: add new DPCD access functions
Date: Sat, 01 Mar 2025 22:39:35 +0200 [thread overview]
Message-ID: <20250301-drm-rework-dpcd-access-v2-0-4d92602fc7cd@linaro.org> (raw)
Existing DPCD access functions return an error code or the number of
bytes being read / write in case of partial access. However a lot of
drivers either (incorrectly) ignore partial access or mishandle error
codes. In other cases this results in a boilerplate code which compares
returned value with the size.
As suggested by Jani implement new set of DPCD access helpers, which
ignore partial access, always return 0 or an error code. Reimplement
existing helpers using the new functions to ensure backwards
compatibility.
This series targets only the DRM helpers code. If the approach is found
to be acceptable, each of the drivers should be converted on its own.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
Changes in v2:
- Reimplemented new helpers using old ones (Lyude)
- Reworked the drm_dp_dpcd_read_link_status() patch (Lyude)
- Dropped the dp-aux-dev patch (Jani)
- Link to v1: https://lore.kernel.org/r/20250117-drm-rework-dpcd-access-v1-0-7fc020e04dbc@linaro.org
---
Dmitry Baryshkov (7):
drm/display: dp: implement new access helpers
drm/display: dp: change drm_dp_dpcd_read_link_status() return value
drm/display: dp: use new DCPD access helpers
drm/display: dp-aux-dev: use new DCPD access helpers
drm/display: dp-cec: use new DCPD access helpers
drm/display: dp-mst-topology: use new DCPD access helpers
drm/display: dp-tunnel: use new DCPD access helpers
drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 8 +-
.../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 2 +-
drivers/gpu/drm/display/drm_dp_aux_dev.c | 12 +-
drivers/gpu/drm/display/drm_dp_cec.c | 37 ++-
drivers/gpu/drm/display/drm_dp_helper.c | 307 +++++++++------------
drivers/gpu/drm/display/drm_dp_mst_topology.c | 105 ++++---
drivers/gpu/drm/display/drm_dp_tunnel.c | 20 +-
drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.c | 4 +-
drivers/gpu/drm/msm/dp/dp_ctrl.c | 24 +-
drivers/gpu/drm/msm/dp/dp_link.c | 18 +-
drivers/gpu/drm/radeon/atombios_dp.c | 8 +-
include/drm/display/drm_dp_helper.h | 92 +++++-
12 files changed, 322 insertions(+), 315 deletions(-)
---
base-commit: c0eb65494e59d9834af7cbad983629e9017b25a1
change-id: 20241231-drm-rework-dpcd-access-b0fc2e47d613
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
next reply other threads:[~2025-03-01 20:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-01 20:39 Dmitry Baryshkov [this message]
2025-03-01 20:39 ` [PATCH RFC v2 1/7] drm/display: dp: implement new access helpers Dmitry Baryshkov
2025-03-01 20:39 ` [PATCH RFC v2 2/7] drm/display: dp: change drm_dp_dpcd_read_link_status() return value Dmitry Baryshkov
2025-03-01 20:39 ` [PATCH RFC v2 3/7] drm/display: dp: use new DCPD access helpers Dmitry Baryshkov
2025-03-01 20:39 ` [PATCH RFC v2 4/7] drm/display: dp-aux-dev: " Dmitry Baryshkov
2025-03-01 20:39 ` [PATCH RFC v2 5/7] drm/display: dp-cec: " Dmitry Baryshkov
2025-03-01 20:39 ` [PATCH RFC v2 6/7] drm/display: dp-mst-topology: " Dmitry Baryshkov
2025-03-01 20:39 ` [PATCH RFC v2 7/7] drm/display: dp-tunnel: " Dmitry Baryshkov
2025-03-06 12:32 ` [PATCH RFC v2 0/7] drm/display: dp: add new DPCD access functions Jani Nikula
2025-03-06 13:04 ` Jani Nikula
2025-03-06 16:42 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250301-drm-rework-dpcd-access-v2-0-4d92602fc7cd@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jani.nikula@linux.intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®