From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0129220E32A; Mon, 3 Mar 2025 16:29:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741019395; cv=none; b=VAlGI848P5HWRPT5BMHRjmU8IvSFCwBYxSMm7i3T02YyIq6zAIHNAwDEyYNQBTgObRcjUjrNiBE/1jZD9GFx7ZYvbcA3ts7shlSE7UMizcZypSTn5j4zR8WmmrIhJyiK1RFf1uG8IO22fTFFwPULrpvZMhjksXqewegZ41S6zxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741019395; c=relaxed/simple; bh=PFXJy2FtP1emZFy6QDOvJlok8GqsNsNEQzNpXEqasCc=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=seY70L29TOXeHM8BxQpxDPv2Yb+CG/4tKD8r54BlQJSuoU2pk0nxKjgFCz7oN1EsZ7w+fqR+LkfbRUKZ6JRb4nlbzCcWQkkitM86k7+Y9D0P0Zc9c0BsBLeYtfkCjxUeVxEH0hU8mQtxSpzYHjKrh+U9hgqf39Tf35Yw3k2N768= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ujDpEibk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ujDpEibk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 318F8C4CED6; Mon, 3 Mar 2025 16:29:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741019394; bh=PFXJy2FtP1emZFy6QDOvJlok8GqsNsNEQzNpXEqasCc=; h=From:To:Cc:Subject:Date:From; b=ujDpEibkKklbcGK/ipfoD+Si4hnuqaPwlw4eZeW4no9X8p3YQ101XO6bEpDkrlNrm mVgKwbgfhk6JcTy5LcSg+GUSdM1ZeBK/WIGy0sCIVPJeN5RGZ8yuzCwTa/kDbg25gI C1Uha01qvLEdUSLnfV7SQCblMkstrHgOyaRBRJ9RgnKw0D7htMBDoG6wqmEc6/uqwd GcALWyNCHExcrzhccAAVJBZiKJBkW7We0nGZJY743H6P8QA1/IsR7H7rWjTlHGLdX1 QO6dbIKxjMZ4Qjhu6lFRCN6TY8SaiC9iLLVClB37JZvD4TvfuDlJ5YjiIGv1nyVmyT Jy7rkosbAp3UA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Andrew Davis , Nishanth Menon , Vinod Koul , Sasha Levin , kishon@kernel.org, s-vadapalli@ti.com, krzysztof.kozlowski@linaro.org, rogerq@kernel.org, linux-phy@lists.infradead.org Subject: [PATCH AUTOSEL 6.13 01/17] phy: ti: gmii-sel: Do not use syscon helper to build regmap Date: Mon, 3 Mar 2025 11:29:33 -0500 Message-Id: <20250303162951.3763346-1-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.13.5 Content-Transfer-Encoding: 8bit From: Andrew Davis [ Upstream commit 5ab90f40121a9f6a9b368274cd92d0f435dc7cfa ] The syscon helper device_node_to_regmap() is used to fetch a regmap registered to a device node. It also currently creates this regmap if the node did not already have a regmap associated with it. This should only be used on "syscon" nodes. This driver is not such a device and instead uses device_node_to_regmap() on its own node as a hacky way to create a regmap for itself. This will not work going forward and so we should create our regmap the normal way by defining our regmap_config, fetching our memory resource, then using the normal regmap_init_mmio() function. Signed-off-by: Andrew Davis Tested-by: Nishanth Menon Link: https://lore.kernel.org/r/20250123182234.597665-1-afd@ti.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/phy/ti/phy-gmii-sel.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/phy/ti/phy-gmii-sel.c b/drivers/phy/ti/phy-gmii-sel.c index e0ca59ae31531..ff5d5e29629fa 100644 --- a/drivers/phy/ti/phy-gmii-sel.c +++ b/drivers/phy/ti/phy-gmii-sel.c @@ -424,6 +424,12 @@ static int phy_gmii_sel_init_ports(struct phy_gmii_sel_priv *priv) return 0; } +static const struct regmap_config phy_gmii_sel_regmap_cfg = { + .reg_bits = 32, + .val_bits = 32, + .reg_stride = 4, +}; + static int phy_gmii_sel_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -468,7 +474,14 @@ static int phy_gmii_sel_probe(struct platform_device *pdev) priv->regmap = syscon_node_to_regmap(node->parent); if (IS_ERR(priv->regmap)) { - priv->regmap = device_node_to_regmap(node); + void __iomem *base; + + base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(base)) + return dev_err_probe(dev, PTR_ERR(base), + "failed to get base memory resource\n"); + + priv->regmap = regmap_init_mmio(dev, base, &phy_gmii_sel_regmap_cfg); if (IS_ERR(priv->regmap)) return dev_err_probe(dev, PTR_ERR(priv->regmap), "Failed to get syscon\n"); -- 2.39.5