From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ian Rogers <irogers@google.com>,
Kan Liang <kan.liang@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Subject: [PATCH 3/7] perf annotate: Pass annotation_options to annotation_line__print()
Date: Mon, 3 Mar 2025 09:38:03 -0800 [thread overview]
Message-ID: <20250303173807.1765098-4-namhyung@kernel.org> (raw)
In-Reply-To: <20250303173807.1765098-1-namhyung@kernel.org>
The annotation_line__print() has many arguments. But min_percent,
max_lines and percent_type are from struct annotaion_options. So let's
pass a pointer to the option instead of passing them separately to
reduce the number of function arguments.
Actually it has a recursive call if 'queue' is set. Add a new option
instance to pass different values for the case.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/annotate.c | 22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 2e0f70b4872b475a..469fcc945126f4f7 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -760,13 +760,14 @@ static int disasm_line__print(struct disasm_line *dl, u64 start, int addr_fmt_wi
static int
annotation_line__print(struct annotation_line *al, struct symbol *sym, u64 start,
- struct evsel *evsel, int min_pcnt, int printed,
- int max_lines, struct annotation_line *queue, int addr_fmt_width,
- int percent_type)
+ struct evsel *evsel, struct annotation_options *opts,
+ int printed, struct annotation_line *queue, int addr_fmt_width)
{
struct disasm_line *dl = container_of(al, struct disasm_line, al);
struct annotation *notes = symbol__annotation(sym);
static const char *prev_line;
+ int max_lines = opts->max_lines;
+ int percent_type = opts->percent_type;
if (al->offset != -1) {
double max_percent = 0.0;
@@ -786,19 +787,25 @@ annotation_line__print(struct annotation_line *al, struct symbol *sym, u64 start
if (al->data_nr > nr_percent)
nr_percent = al->data_nr;
- if (max_percent < min_pcnt)
+ if (max_percent < opts->min_pcnt)
return -1;
if (max_lines && printed >= max_lines)
return 1;
if (queue != NULL) {
+ struct annotation_options queue_opts = {
+ .max_lines = 1,
+ .percent_type = percent_type,
+ };
+
list_for_each_entry_from(queue, ¬es->src->source, node) {
if (queue == al)
break;
annotation_line__print(queue, sym, start, evsel,
- 0, 0, 1, NULL, addr_fmt_width,
- percent_type);
+ &queue_opts, /*printed=*/0,
+ /*queue=*/NULL,
+ addr_fmt_width);
}
}
@@ -1225,8 +1232,7 @@ int symbol__annotate_printf(struct map_symbol *ms, struct evsel *evsel)
}
err = annotation_line__print(pos, sym, start, evsel,
- opts->min_pcnt, printed, opts->max_lines,
- queue, addr_fmt_width, opts->percent_type);
+ opts, printed, queue, addr_fmt_width);
switch (err) {
case 0:
--
2.48.1.711.g2feabab25a-goog
next prev parent reply other threads:[~2025-03-03 17:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 17:38 [PATCHSET 0/7] perf annotate: Add --code-with-type option Namhyung Kim
2025-03-03 17:38 ` [PATCH 1/7] perf annotate-data: Add annotated_data_type__get_member_name() Namhyung Kim
2025-03-03 17:38 ` [PATCH 2/7] perf annotate: Remove unused len parameter from annotation_line__print() Namhyung Kim
2025-03-03 17:38 ` Namhyung Kim [this message]
2025-03-03 17:38 ` [PATCH 4/7] perf annotate: Pass hist_entry to annotate functions Namhyung Kim
2025-03-03 17:38 ` [PATCH 5/7] perf annotate: Factor out __hist_entry__get_data_type() Namhyung Kim
2025-03-03 17:38 ` [PATCH 6/7] perf annotate: Implement code + data type annotation Namhyung Kim
2025-03-03 17:38 ` [PATCH 7/7] perf annotate: Add --code-with-type option Namhyung Kim
2025-03-05 23:27 ` [PATCHSET 0/7] " Ian Rogers
2025-03-05 23:31 ` Ian Rogers
2025-03-07 0:06 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250303173807.1765098-4-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®