Re: [PATCH v4 00/15] drm/bridge: Various quality of life improvements

[Maxime Ripard <mripard@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 3245 bytes --]

On Mon, Mar 03, 2025 at 05:50:11PM +0100, Herve Codina wrote:
> On Mon, 3 Mar 2025 16:00:33 +0100
> Maxime Ripard <mripard@kernel.org> wrote:
> 
> > On Mon, Mar 03, 2025 at 02:34:04PM +0100, Herve Codina wrote:
> > > Hi Maxime,
> > > 
> > > On Mon, 3 Mar 2025 14:11:05 +0100
> > > Maxime Ripard <mripard@kernel.org> wrote:
> > >   
> > > > On Thu, Feb 27, 2025 at 12:00:04PM +0100, Herve Codina wrote:  
> > > > > Hi Maxime,
> > > > > 
> > > > > On Tue, 25 Feb 2025 17:43:48 +0100
> > > > > Maxime Ripard <mripard@kernel.org> wrote:
> > > > >     
> > > > > > Hi,
> > > > > > 
> > > > > > Here's a series of changes after to the KMS helpers and bridge API
> > > > > > following a bunch of reviews I did.
> > > > > > 
> > > > > > It's mostly centered across providing an easier time to deal with bridge
> > > > > > states, and a somewhat consistent with the other entities API.
> > > > > > 
> > > > > > It's build tested only, with arm64 allmodconfig.
> > > > > > 
> > > > > > Maxime
> > > > > > 
> > > > > > Signed-off-by: Maxime Ripard <mripard@kernel.org>
> > > > > > ---    
> > > > > 
> > > > > I Tried to test this series on my system but I've got a compilation issue.
> > > > >      depmod: ERROR: Cycle detected: drm -> drm_kms_helper -> drm
> > > > >      depmod: ERROR: Found 2 modules in dependency cycles!
> > > > > 
> > > > > CONFIG_DRM=m in my configuration.    
> > > > 
> > > > Could you share your configuration? it doesn't happen with allmodconfig.
> > > >   
> > > 
> > > Here is a defconfig that leads to the issue on my side:  
> > 
> > I still can't reproduce it, sorry. Is this based on linux-next /
> > drm-misc-next, or a private branch?
> > 
> > Maxime
> 
> Got it with this git history (based on 72d0af4accd9 available in
> drm-misc-next):
> 
> f86431f9d3fc (HEAD -> test_maxime_series_drm_next_clean_v4) drm/bridge: ti-sn65dsi86: Use bridge_state crtc pointer
> 27b49a4a713f drm/bridge: tc358768: Convert to atomic helpers
> f3f203c823e3 drm/bridge: tc358768: Stop disabling when failing to enable
> 89f4b115b1ca drm/bridge: tc358775: Switch to atomic commit
> 142be5c7910a drm/bridge: cdns-csi: Switch to atomic helpers
> e6db675d871a drm/bridge: Introduce drm_bridge_is_atomic() helper
> 1745511b7394 drm/bridge: ti-sn65dsi83: Switch to drm_bridge_reset_crtc
> e44654d4c9bd drm/tests: bridge: Provide tests for drm_bridge_reset_crtc
> 671a94f57f99 drm/bridge: Add helper to reset bridge pipeline
> bcf02dc7fb61 drm/tests: Create tests for drm_atomic
> f7b479b6f283 drm/atomic: Introduce helper to lookup connector by encoder
> 56d9fa19b833 drm/tests: Add kunit tests for bridges
> 9c86d5205422 drm/bridge: Provide a helper to retrieve current bridge state
> 3e0010915240 drm/bridge: Add encoder parameter to drm_bridge_funcs.attach
> 72d0af4accd9 (upstream_drm/for-linux-next, upstream_drm/drm-misc-next) drm/msm/dp: Add support for LTTPR handling
> 6dcc3c5121b7 drm/i915/dp: Use the generic helper to control LTTPR transparent mode
> 226a0baf9098 drm/nouveau/dp: Use the generic helper to control LTTPR transparent mode
> ...

Yeah, I found it. It doesn't happen during compilation but during
modules_install. It's fixed now, thanks!

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]