From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA599239579 for ; Tue, 4 Mar 2025 15:10:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741101051; cv=none; b=ZBF3hCIDx9+2vgGjfWQwqoQPRf/5Q9c/IiSYgLoGy19n9NtHYFJAwfHdt0h6dx09drsi8CWUJ/6UNRtWrioUnj7el6WULzpwQk33AQyh+To8A7i3l9s4j25Ged9N1wJJlQR8R9Njih/GsErRDl1VlpY0I97mDVs1PqEQvjIt75c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741101051; c=relaxed/simple; bh=43kkvm0fDoGaY3CU2LfS1Vs/lca8x1zkYXTvuUBDxGY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JMA853adhZxGV5LB8EDwKYMx7EdvtTL+J242yxxH8fpvs7U53VN3/9VDYjUWQaLLF/EZH8PnmLm+62g0F8BkCyWwShxGZwuJ+vU3fq2rci/xkEHA8XXaNlnQJiV/+yV62NIil8gbyRq30VTBrZV1qrrBX7NvFhNUQHSGz7RjWUk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=eITQcMky; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eITQcMky" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-2feb1d7a68fso10230008a91.1 for ; Tue, 04 Mar 2025 07:10:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741101049; x=1741705849; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=vdhvna9uxBeu4mYpj5OPBxZhuzN87zcLw+LVQRQ7m7s=; b=eITQcMkytMhZaS2gd3R9YaW6ig419DuIwvf85dd23hCf0S+5c7oqCFRXj+uFUHQ/IV q7bETRmmzce7WYAxwnQBY/CADwA/7UWuOFxCYZFb/4UXQe213U3gUIqWahJB6P8hxAkJ G3/WVRR2jpojmpoPcCYkZ7pMbQ5LvUAw7lsPQQKT099BprX4J2gd0NCeCpG3gA/02W+N WAe2sKT1TKkcRFSwvS8/DlMWAInVA2b9eyLYhSVFbYnOw0ffhXhNMSJ7V7MO6hdBQ5P/ DQ12WGxSizi/Coc6YXvFmTwVhzH4xpGz/ozg/lB8f24QIRaldCNyCNWsXeyBjygyA6r/ SnxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741101049; x=1741705849; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vdhvna9uxBeu4mYpj5OPBxZhuzN87zcLw+LVQRQ7m7s=; b=jIRAqvICNNEzM9RmHoTTKaLncKbuAclgwpDr/4OHZPBtdiJuapW1EBSEJB0aCDtRtV nYgLCblW/lcO8qv/xqhQ6pNRjbdnnOdNPi46iG56LshCZQK74tKMR1mTYRwXmrcbTz1C /zL43V7+n3UNSncEgajjBpDaEew3gOSw5NHvTnlsaRjTMZhLuItXf7GgYwQR0n0TMXPe uGcCt+QrflcbYiZsIOuKl5giINQSVX9Qk7zg1YFlC0p7VS5uqm2O3+qwvkdDciYjVE5o J/I5bUlcsoaoOvRVUCwZABIp+VIh1cqk3qgTcow8w30l3mt6vG11g5jufKZhkjaJoHVP eo7w== X-Forwarded-Encrypted: i=1; AJvYcCUh9Ds8PGm2q+Nwzad4C7RTQVFxD8zgXTuA+K7F204jD/1oR1qD4hMFPr0MdMNONTRnbLa1YQuG7yaaMCg=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0VQfWWhrA3WcMT3SdOf0zv5uxYM12QPngBOa/pzIgnkMc8WFo L9rND9uR/2z6+k57lrpbabGQ0Y9yQ5PY+/2EneOTbGlx4mLU8/wEwXo09Hie8A== X-Gm-Gg: ASbGnct4RHOFEyciBz7xC6m4zK82XKy23w+gYfnw2i2R60jDzpAJrvUSGyJFNbD8AIM IK3okDNd09p2NuZDehvSXFzOlgynYoZWvKxRzAp9KYvp9JlniSH4iggYEQhH1qjYIKhcvN5U4VB PBthGlAvUD+pBW1W+5srpICfHzpJ71wJLB37/7tXgLpyVxNV9YzPXQ388mu8fhyaCsFmkYv/ZRf QDKkFNsMGggWGvetfmuK/VRXK9CW/QqvsVteo3/knX8/+bNDLJL1iqu6WeBksg2kWE2PLJE61Tn Qfz/142nrttijD8KPxrcUvCpKyT/wssEU3xGxgsoUk2J/Wnct52RiQE= X-Google-Smtp-Source: AGHT+IGfTEua5Nua/thzn0LAom+PoolH5xRKN+uIh0BTTsH6+TMAMWAEwJ3FTRgLK3drwMf2I3fVUQ== X-Received: by 2002:a17:90b:4ac6:b0:2fe:b8ba:62de with SMTP id 98e67ed59e1d1-2febabd9d13mr26339791a91.25.1741101049205; Tue, 04 Mar 2025 07:10:49 -0800 (PST) Received: from thinkpad ([120.60.51.199]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-223852162bcsm59170965ad.8.2025.03.04.07.10.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 07:10:48 -0800 (PST) Date: Tue, 4 Mar 2025 20:40:40 +0530 From: Manivannan Sadhasivam To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, Florian Fainelli , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v2 8/8] PCI: brcmstb: Clarify conversion of irq_domain_set_info() param Message-ID: <20250304151022.qgp253hv5sxvxzdc@thinkpad> References: <20250214173944.47506-1-james.quinlan@broadcom.com> <20250214173944.47506-9-james.quinlan@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250214173944.47506-9-james.quinlan@broadcom.com> On Fri, Feb 14, 2025 at 12:39:36PM -0500, Jim Quinlan wrote: > Just make it clear to the reader that there is a conversion happening, in > this case from an int type to an irq_hw_number_t, an unsigned long int. > > Signed-off-by: Jim Quinlan Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/pci/controller/pcie-brcmstb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c > index cb897d4b2579..f790d5252e9f 100644 > --- a/drivers/pci/controller/pcie-brcmstb.c > +++ b/drivers/pci/controller/pcie-brcmstb.c > @@ -559,7 +559,7 @@ static int brcm_irq_domain_alloc(struct irq_domain *domain, unsigned int virq, > return hwirq; > > for (i = 0; i < nr_irqs; i++) > - irq_domain_set_info(domain, virq + i, hwirq + i, > + irq_domain_set_info(domain, virq + i, (irq_hw_number_t)hwirq + i, > &brcm_msi_bottom_irq_chip, domain->host_data, > handle_edge_irq, NULL, NULL); > return 0; > -- > 2.43.0 > -- மணிவண்ணன் சதாசிவம்