From: Greg KH <gregkh@linuxfoundation.org>
To: Zxyan Zhu <zxyan20@163.com>
Cc: broonie@kernel.org, rafael@kernel.org, dakr@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] regmap: debugfs: Fix name collision without atomic operations
Date: Tue, 4 Mar 2025 17:23:02 +0100 [thread overview]
Message-ID: <2025030437-copious-irrigate-1b63@gregkh> (raw)
In-Reply-To: <20250304142452.3521828-1-zxyan20@163.com>
On Tue, Mar 04, 2025 at 10:24:52PM +0800, Zxyan Zhu wrote:
> The `dummy_index` global variable caused debugfs file name conflicts
> during re-entry, leading to creation failures. Use atomic operations
> to ensure safe and unique debugfs `dummy%d` naming.
>
> Changes since v1:
> - Replaced atomic_read + atomic_inc with atomic_inc_return.
> - Added atomic_dec in the error path to maintain index consistency.
> - Updated the commit message to clarify the fix.
>
> Signed-off-by: Zxyan Zhu <zxyan20@163.com>
> ---
> drivers/base/regmap/regmap-debugfs.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c
> index fb84cda92a75..60c8d9a673b8 100644
> --- a/drivers/base/regmap/regmap-debugfs.c
> +++ b/drivers/base/regmap/regmap-debugfs.c
> @@ -20,7 +20,7 @@ struct regmap_debugfs_node {
> struct list_head link;
> };
>
> -static unsigned int dummy_index;
> +static atomic_t dummy_index = ATOMIC_INIT(0);
> static struct dentry *regmap_debugfs_root;
> static LIST_HEAD(regmap_debugfs_early_list);
> static DEFINE_MUTEX(regmap_debugfs_early_lock);
> @@ -549,6 +549,7 @@ void regmap_debugfs_init(struct regmap *map)
> struct regmap_range_node *range_node;
> const char *devname = "dummy";
> const char *name = map->name;
> + int index;
>
> /*
> * Userspace can initiate reads from the hardware over debugfs.
> @@ -595,12 +596,13 @@ void regmap_debugfs_init(struct regmap *map)
>
> if (!strcmp(name, "dummy")) {
> kfree(map->debugfs_name);
> - map->debugfs_name = kasprintf(GFP_KERNEL, "dummy%d",
> - dummy_index);
> - if (!map->debugfs_name)
> + index = atomic_inc_return(&dummy_index);
> + map->debugfs_name = kasprintf(GFP_KERNEL, "dummy%d", index);
> + if (!map->debugfs_name) {
> + atomic_dec(&dummy_index);
> return;
> + }
> name = map->debugfs_name;
> - dummy_index++;
Shouldn't you just use an idr here if there is a race condition?
There's a lock built into it that should solve all of these issues.
thanks,
greg k-h
next prev parent reply other threads:[~2025-03-04 16:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 14:24 Zxyan Zhu
2025-03-04 14:35 ` Mark Brown
2025-03-04 16:23 ` Greg KH [this message]
2025-03-04 16:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025030437-copious-irrigate-1b63@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=dakr@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=zxyan20@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®