From: Even Xu <even.xu@intel.com>
To: jikos@kernel.org, bentiss@kernel.org
Cc: srinivas.pandruvada@linux.intel.com, mpearson-lenovo@squebb.ca,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Even Xu <even.xu@intel.com>
Subject: [PATCH v2 2/2] HID: Intel-thc-hid: Intel-quickspi: Change device state correctly after S4
Date: Wed, 5 Mar 2025 11:33:31 +0800 [thread overview]
Message-ID: <20250305033331.2544941-3-even.xu@intel.com> (raw)
In-Reply-To: <20250305033331.2544941-1-even.xu@intel.com>
During S4 retore flow, quickspi device was reset by driver and state
was changed to QUICKSPI_RESET. It is needed to be change to
QUICKSPI_ENABLED state after S4 re-initialization finished, otherwise,
device will run in wrong state and HID input data will be dropped.
Signed-off-by: Even Xu <even.xu@intel.com>
Fixes: 6912aaf3fd24 ("HID: intel-thc-hid: intel-quickspi: Add PM implementation")
---
drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
index 59d0b71e6e4f..9170af9be777 100644
--- a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
+++ b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
@@ -909,6 +909,8 @@ static int quickspi_restore(struct device *device)
thc_change_ltr_mode(qsdev->thc_hw, THC_LTR_MODE_ACTIVE);
+ qsdev->state = QUICKSPI_ENABLED;
+
return 0;
}
--
2.40.1
prev parent reply other threads:[~2025-03-05 3:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 3:33 [PATCH v2 0/2] Fix "QuickSPI touch function lost after S4" issue Even Xu
2025-03-05 3:33 ` [PATCH v2 1/2] HID: Intel-thc-hid: Intel-quickspi: Correct device state names gramatically Even Xu
2025-03-05 3:33 ` Even Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250305033331.2544941-3-even.xu@intel.com \
--to=even.xu@intel.com \
--cc=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®