From: Yosry Ahmed <yosry.ahmed@linux.dev>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Nhat Pham <nphamcs@gmail.com>,
Chengming Zhou <chengming.zhou@linux.dev>,
Minchan Kim <minchan@kernel.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Yosry Ahmed <yosry.ahmed@linux.dev>
Subject: [PATCH mm-unstable 1/5] mm: zpool: Add interfaces for object read/write APIs
Date: Wed, 5 Mar 2025 06:11:29 +0000 [thread overview]
Message-ID: <20250305061134.4105762-2-yosry.ahmed@linux.dev> (raw)
In-Reply-To: <20250305061134.4105762-1-yosry.ahmed@linux.dev>
Zsmalloc introduce new APIs to read/write objects besides mapping them.
Add the necessary zpool interfaces.
Signed-off-by: Yosry Ahmed <yosry.ahmed@linux.dev>
---
include/linux/zpool.h | 17 +++++++++++++++
mm/zpool.c | 48 +++++++++++++++++++++++++++++++++++++++++++
mm/zsmalloc.c | 21 +++++++++++++++++++
3 files changed, 86 insertions(+)
diff --git a/include/linux/zpool.h b/include/linux/zpool.h
index 5e6dc46b8cc4c..1784e735ee049 100644
--- a/include/linux/zpool.h
+++ b/include/linux/zpool.h
@@ -52,6 +52,16 @@ void *zpool_map_handle(struct zpool *pool, unsigned long handle,
void zpool_unmap_handle(struct zpool *pool, unsigned long handle);
+
+void *zpool_obj_read_begin(struct zpool *zpool, unsigned long handle,
+ void *local_copy);
+
+void zpool_obj_read_end(struct zpool *zpool, unsigned long handle,
+ void *handle_mem);
+
+void zpool_obj_write(struct zpool *zpool, unsigned long handle,
+ void *handle_mem, size_t mem_len);
+
u64 zpool_get_total_pages(struct zpool *pool);
@@ -90,6 +100,13 @@ struct zpool_driver {
enum zpool_mapmode mm);
void (*unmap)(void *pool, unsigned long handle);
+ void *(*obj_read_begin)(void *pool, unsigned long handle,
+ void *local_copy);
+ void (*obj_read_end)(void *pool, unsigned long handle,
+ void *handle_mem);
+ void (*obj_write)(void *pool, unsigned long handle,
+ void *handle_mem, size_t mem_len);
+
u64 (*total_pages)(void *pool);
};
diff --git a/mm/zpool.c b/mm/zpool.c
index 4bbd12d4b6599..378c2d1e5638f 100644
--- a/mm/zpool.c
+++ b/mm/zpool.c
@@ -320,6 +320,54 @@ void zpool_unmap_handle(struct zpool *zpool, unsigned long handle)
zpool->driver->unmap(zpool->pool, handle);
}
+/**
+ * zpool_obj_read_begin() - Start reading from a previously allocated handle.
+ * @zpool: The zpool that the handle was allocated from
+ * @handle: The handle to read from
+ * @local_copy: A local buffer to use if needed.
+ *
+ * This starts a read operation of a previously allocated handle. The passed
+ * @local_copy buffer may be used if needed by copying the memory into.
+ * zpool_obj_read_end() MUST be called after the read is completed to undo any
+ * actions taken (e.g. release locks).
+ *
+ * Returns: A pointer to the handle memory to be read, if @local_copy is used,
+ * the returned pointer is @local_copy.
+ */
+void *zpool_obj_read_begin(struct zpool *zpool, unsigned long handle,
+ void *local_copy)
+{
+ return zpool->driver->obj_read_begin(zpool->pool, handle, local_copy);
+}
+
+/**
+ * zpool_obj_read_end() - Finish reading from a previously allocated handle.
+ * @zpool: The zpool that the handle was allocated from
+ * @handle: The handle to read from
+ * @handle_mem: The pointer returned by zpool_obj_read_begin()
+ *
+ * Finishes a read operation previously started by zpool_obj_read_begin().
+ */
+void zpool_obj_read_end(struct zpool *zpool, unsigned long handle,
+ void *handle_mem)
+{
+ zpool->driver->obj_read_end(zpool->pool, handle, handle_mem);
+}
+
+/**
+ * zpool_obj_write() - Write to a previously allocated handle.
+ * @zpool: The zpool that the handle was allocated from
+ * @handle: The handle to read from
+ * @handle_mem: The memory to copy from into the handle.
+ * @mem_len: The length of memory to be written.
+ *
+ */
+void zpool_obj_write(struct zpool *zpool, unsigned long handle,
+ void *handle_mem, size_t mem_len)
+{
+ zpool->driver->obj_write(zpool->pool, handle, handle_mem, mem_len);
+}
+
/**
* zpool_get_total_pages() - The total size of the pool
* @zpool: The zpool to check
diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 63c99db71dc1f..d84b300db64e7 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -507,6 +507,24 @@ static void zs_zpool_unmap(void *pool, unsigned long handle)
zs_unmap_object(pool, handle);
}
+static void *zs_zpool_obj_read_begin(void *pool, unsigned long handle,
+ void *local_copy)
+{
+ return zs_obj_read_begin(pool, handle, local_copy);
+}
+
+static void zs_zpool_obj_read_end(void *pool, unsigned long handle,
+ void *handle_mem)
+{
+ zs_obj_read_end(pool, handle, handle_mem);
+}
+
+static void zs_zpool_obj_write(void *pool, unsigned long handle,
+ void *handle_mem, size_t mem_len)
+{
+ zs_obj_write(pool, handle, handle_mem, mem_len);
+}
+
static u64 zs_zpool_total_pages(void *pool)
{
return zs_get_total_pages(pool);
@@ -522,6 +540,9 @@ static struct zpool_driver zs_zpool_driver = {
.free = zs_zpool_free,
.map = zs_zpool_map,
.unmap = zs_zpool_unmap,
+ .obj_read_begin = zs_zpool_obj_read_begin,
+ .obj_read_end = zs_zpool_obj_read_end,
+ .obj_write = zs_zpool_obj_write,
.total_pages = zs_zpool_total_pages,
};
--
2.48.1.711.g2feabab25a-goog
next prev parent reply other threads:[~2025-03-05 6:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 6:11 [PATCH mm-unstable 0/5] Switch zswap to " Yosry Ahmed
2025-03-05 6:11 ` Yosry Ahmed [this message]
2025-03-05 8:18 ` [PATCH mm-unstable 1/5] mm: zpool: Add interfaces for " Sergey Senozhatsky
2025-03-05 14:43 ` Johannes Weiner
2025-03-05 17:32 ` Nhat Pham
2025-03-05 6:11 ` [PATCH mm-unstable 2/5] mm: zswap: Use object read/write APIs instead of object mapping APIs Yosry Ahmed
2025-03-05 14:48 ` Johannes Weiner
2025-03-05 17:35 ` Nhat Pham
2025-03-05 6:11 ` [PATCH mm-unstable 3/5] mm: zpool: Remove " Yosry Ahmed
2025-03-05 8:17 ` Sergey Senozhatsky
2025-03-05 14:49 ` Johannes Weiner
2025-03-05 17:37 ` Nhat Pham
2025-03-06 1:48 ` Herbert Xu
2025-03-06 4:19 ` Herbert Xu
2025-03-06 16:55 ` Yosry Ahmed
2025-03-07 2:38 ` Herbert Xu
2025-03-07 5:19 ` Sergey Senozhatsky
2025-03-06 14:15 ` Johannes Weiner
2025-03-05 6:11 ` [PATCH mm-unstable 4/5] mm: zsmalloc: Remove object mapping APIs and per-CPU map areas Yosry Ahmed
2025-03-05 8:16 ` Sergey Senozhatsky
2025-03-05 14:51 ` Johannes Weiner
2025-03-05 17:39 ` Nhat Pham
2025-03-05 18:57 ` Yosry Ahmed
2025-03-05 6:11 ` [PATCH mm-unstable 5/5] mm: zpool: Remove zpool_malloc_support_movable() Yosry Ahmed
2025-03-05 8:14 ` Sergey Senozhatsky
2025-03-05 14:53 ` Johannes Weiner
2025-03-05 17:05 ` Nhat Pham
2025-03-05 8:18 ` [PATCH mm-unstable 0/5] Switch zswap to object read/write APIs Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250305061134.4105762-2-yosry.ahmed@linux.dev \
--to=yosry.ahmed@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=nphamcs@gmail.com \
--cc=peterz@infradead.org \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®