From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF26B1C5D4E for ; Wed, 5 Mar 2025 18:14:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741198480; cv=none; b=jSSrGDPl7G9CtfbVCyqsj1qWNz+3XBaRTvTfwqTEXVeevJufKuiUVXkha3hzznh0e5QGWns4kIOPUk4kIujaZcYkgew/dZ7z29/G4zkzNG4TQjlYaIUkeZTHq72Ve8G/N+iWFnJI98mE7q9UovVDIja1Wl1QoDyFprS+vasV2P8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741198480; c=relaxed/simple; bh=lDGktsrrvusw3EwyIKgqSW+1nB/A4uH5GaWgGqTDi+g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RVfXBxgrQHo6jJsvPIs2rA6+m7nwgM/mxji6/2pbD4BuMwzscHx3ZLkmE7DfBy1Ehx3KRML/mZW6oQKtQpIY4a4HCjYz7qUGIwWz9BWbh+bqTxsU2A0RVWaaf72fugmr4N67L7FZnAfTZNCsF/gHHNSICWRsqGUf67ClYuBoESg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=Y+QJv0BN; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Y+QJv0BN" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-7c3cf3afc2bso213348585a.0 for ; Wed, 05 Mar 2025 10:14:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1741198476; x=1741803276; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BM3nl1PDUv3g4PwFQ23XNaGdtMsSR0uMk4FDd4zSWU0=; b=Y+QJv0BNv1h50k0q6lHIhHKtGAX+jzCkhA1/+Fi0IVupW6xrJv3OUj+z42+l3i7QIu oaDWLn3lWMRe8hwvUtTfNmmO9msLSIN8fG4TVsbL9DhGNHfX+9MLs6+BxHXsMvOwBQ32 88FUxHbsgqGoHXBYtg8CzakkX0IPm1PiUty6cEBOHpdshKu5FDgCcdByE5gAvvv6YJHv 1K7LjoyXYa5Hu2uugJuoSoefYNQCZYTtkFLeHueHKm+yk64X4R43xkqy98SKUTaFCWcH BUGqUV1XafFjeDkinPilRsDPn5w/4zJkfMrfqv2nH5S57cg2WnTU/25CvNdEcEukPtY/ KfOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741198476; x=1741803276; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BM3nl1PDUv3g4PwFQ23XNaGdtMsSR0uMk4FDd4zSWU0=; b=mQS0jOlxh5TpJcStl4w1xDp5SGQXkcCznSyx9MCVdEWpMXHI6oItcC3xzjvc2zHco0 peWP0/ISntLEy7jxG7QMYWoD6aPrAUr2fg3Ev3pzJ+1W0yhQ9msf8nX+7NNZFkdVH6dc a5VmovOmrHciBwqv+Md9lZlXozrvVMJTOTXWNZ5363G8fFb/szvb/sM8Upri0Bj9HiRR IGm/4UXNq9PWPHw28qq07Q5a8JzoCD3TuE345TRTTVvEMpI0O0rdmsiQzzp0sdSaMx7j fEk7IIFKv/opl0S0AW4zwnDOuyZYEyB1tTHBY0t9zJDbVdB+Oy6cFzxVfceK9d9/GQwK AQUw== X-Forwarded-Encrypted: i=1; AJvYcCUs6F7/Uqt7RVz+ZKPCAVzdRyVR4JTKLmbJatgtE4P9JQOVv1jzry0JiT+uy7FYpsgfmo1kKG2Hqsb37QA=@vger.kernel.org X-Gm-Message-State: AOJu0YzRpbibVTK1T0o1hvEysr4AiervC7m4lgo3bvjOSgKkyAz/Wgau YKCtybdHtE/PJJplV7Z1W3Hab3hFA/G6Bw4IKamrZAJRRknKCvIKHImcQ+utDY4= X-Gm-Gg: ASbGnctHSJGMp5ugLLfucV2xk5weG7/lcFd325jZUbBcK9GSGH16n8OzH3Qw0qxbBKe N3XdOjKTVRXQ5Rt8KQ6/JZeq7b0+xdxdCqJzaT3CxCmm+wgFe19VdYdxu3NsXvH8CDQ/nYTyiGI UdIYsX7HJdJvgRUwSQljwNjzmUmmK/QdJidUQPSS/FkA+W0ZY9mIZn4ryrNsrfnB6UYEuWtNwBO xEQLavuMRorz5R7qXpkf7UmtByA1AOMSZUPN1jvoAMbrcSRKdmfL2Vup6EgHQCNdxgrErOTEYnb ryAU+qd0Q5esKt8CxIk= X-Google-Smtp-Source: AGHT+IGBXOlCQEjAXivcZONN7HD211rRxB+Amwcgf4SScDXv9d/J0SEM3NN6sEdvhUlnOiPXZLnHzQ== X-Received: by 2002:a05:620a:2b44:b0:7c3:c077:fbf2 with SMTP id af79cd13be357-7c3d8ee8505mr677678685a.45.1741198476550; Wed, 05 Mar 2025 10:14:36 -0800 (PST) Received: from ziepe.ca ([130.41.10.206]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6e8976da283sm81577696d6.111.2025.03.05.10.14.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 10:14:35 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1tptGN-00000001U2f-0a3P; Wed, 05 Mar 2025 14:14:35 -0400 Date: Wed, 5 Mar 2025 14:14:35 -0400 From: Jason Gunthorpe To: Robin Murphy Cc: Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Len Brown , Russell King , Greg Kroah-Hartman , Danilo Krummrich , Stuart Yoder , Laurentiu Tudor , Nipun Gupta , Nikhil Agarwal , Joerg Roedel , Will Deacon , Rob Herring , Saravana Kannan , Bjorn Helgaas , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, Charan Teja Kalla Subject: Re: [PATCH v2 3/4] iommu: Keep dev->iommu state consistent Message-ID: <20250305181435.GJ5011@ziepe.ca> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Feb 28, 2025 at 03:46:32PM +0000, Robin Murphy wrote: > @@ -127,6 +128,7 @@ int of_iommu_configure(struct device *dev, struct device_node *master_np, > mutex_unlock(&iommu_probe_device_lock); > return 0; > } > + dev_iommu_present = dev->iommu; I feel like this deserves a comment.. Maybe it is: /* * If of_iommu_configure is called outside the iommu probe path * dev->iommu should be NULL and it needs to remain as NULL * If it is called within the probe path then the dev->iommu * was setup by iommu_init_device() and must not be changed. */ And I think the commit message should explain what consistent means.. AFAICT you are going for !dev->iommu means no probe has succeed / dev->iommu means a probe is ongoing in this call chain or it has succeeded? Otherwise: Reviewed-by: Jason Gunthorpe Jason