From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E9CC192D86 for ; Thu, 6 Mar 2025 03:13:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741230815; cv=none; b=Cui6mMuPyJpSHoyHo1/IwWyoBS8hlZAGJtzFT1dyltn9fxNVuls5JATYwcLH0xNzRTSsXj/1NWgd/glyytt45W29YEQcmab0SHWERsezYIenqZh+AraAzSrhREPddC9DweyGWi5Bw2Z68fACm48yLhimPmbKjT14Q+ilTLlGfhU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741230815; c=relaxed/simple; bh=Tveglffe8ZqIwGSYe2WrroPWZ6zSCid8BKA2Rrxbctc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qPLgTFnXhPjR342cjluZ/RxnBN2avIXUVJgZmDdCnAeIrqTkV9qZwBs71QWXqf9udqhZ2pw1xBbzIR7viruoJsoObiNyNZseOiWAH0RfHZ2BT8l6aY9g1ziUXqj8USSEOeaGwc9xhu1CGBgR3vr+IWMKNR9GlFVpBukd79dWkFY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Al+nf66H; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Al+nf66H" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2235189adaeso3299735ad.0 for ; Wed, 05 Mar 2025 19:13:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741230813; x=1741835613; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=1xC4B23ZVUrI+v0nWKIC4hRtohRTbUpDYv0ldFM8Y84=; b=Al+nf66HEEs5M50XPaD9As54O3i83iWFQYo4pHJWvRRdBLiBuORBNTX1rjz1znKazc 6PzI2oBstzsNXgN0tAnx5zMYiRhxVu1cora1nThZu0mGDN6qeGl29I5d51ly+T01NG7y fMRZ2SnQGqDqGAFgmuXiZoL2AnhVP3mCZqtToEbQRvNcdD/7rr9/U9WmwnECaEmdwu8C pWs8MSWfd3R7RwwaWRjYMHDX1zbBl6QttyeXDQ6pmg8wgOqK0XEz1Yr+vcf8ULWNajd7 W3ej8KnWlUYbZ2AX1ieRESyQPK/iakPnJtr8i1nLONAtxlyeLgD5V7+PGCi8aJ7pBCXe zsNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741230813; x=1741835613; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1xC4B23ZVUrI+v0nWKIC4hRtohRTbUpDYv0ldFM8Y84=; b=cYcl0mzOYF6bGTSo5qS1MPj3KI4dHHfNnvOVLgrNX+wMpHl+V+CqF55aaHdy9OjNSn F0xr8RQhf8yBtOzT9IBNopvHy55xXxnW/7TNywZ5v7o+SrnOOCoEqOad0/X6bYrk1fYs rFmxPcO9YBALPGon1ihGPnltqAOW3wCm6ILQrS2Xlt2L8XqtgIbFFNwAZ6YaltbPhI4R 1yM9uYzHvrFq+v78ucWkilkrFZEdh+3seOkaK3GQTBpUMJR7TeCbTwBGHrsPsptBInNC GPpl88yygaCZCjWwUY3ah+trMR52bjSFg8HNCIfAPiDLoiq4ZFjX9RjXJuIoqhu2Rn2c JH1Q== X-Forwarded-Encrypted: i=1; AJvYcCUd9M0IQpKeHUMdxHhFEWSwcpXElttrJnolwzXw56r9H5Equmg1WflCgPR7cAhqbAsCXn/CggvrIQiVKNE=@vger.kernel.org X-Gm-Message-State: AOJu0YyPpKSo7O4SEBvDznJrquz25EjAfAZB+qyfkBmM4VMp3JyHZt14 t121Z2u58dI5YaF6QeN+l6VuMf4MjCZYVD1p6x5AobnLKJYksk9F9zV7tCIUCg== X-Gm-Gg: ASbGncsq9Uce4NSaWLqd+aPTxsQh5k8Vnwfa8rs4wyRZor/EIUDSgz2aPvZ7ig8b3lv 3HrdIqMTb6qdceNulPsHfmpHeKmocl6D39WKIf0aseDxL70fkmqJZg6YnHXhp267dCOcKb8PNxB GGh56AnPirMBcxdDF8mF2adP/T/3I3cLB7WVIuUJn08aqVHnsrm3iuzu79G3y+kq2IqfS7mSZuL Z89ydbtZMUCe2m4V6ziTNLjldvSnjPiqwaNsTYuQ/wegFnTE0Tod4zILMqCodYrkWB8Gm/92+j5 Z175zBNkcMUd58kOFw5IpZ9Ik6F2a4isLz9KuQrPimyLzOcFYwiCjt8= X-Google-Smtp-Source: AGHT+IFy40lU01QwIDD6NgP1MWN6uVEbwb2emHO+b5oCOTPTFjpkYhW+N4OcEkblRt9yRpkBHJpIww== X-Received: by 2002:a17:902:e5ca:b0:223:517a:d4ed with SMTP id d9443c01a7336-22409457e5dmr21605625ad.15.1741230812657; Wed, 05 Mar 2025 19:13:32 -0800 (PST) Received: from thinkpad ([120.56.193.59]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22410a91c43sm1613815ad.183.2025.03.05.19.13.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 19:13:32 -0800 (PST) Date: Thu, 6 Mar 2025 08:43:25 +0530 From: Manivannan Sadhasivam To: Krishna Chaitanya Chundru Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Helgaas , Jingoo Han , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, quic_mrana@quicinc.com, quic_vbadigan@quicinc.com, Konrad Dybcio Subject: Re: [PATCH v7 1/4] arm64: dts: qcom: x1e80100: Add PCIe lane equalization preset properties Message-ID: <20250306031325.bmx3p6htwtb6l6ji@thinkpad> References: <20250225-preset_v6-v7-0-a593f3ef3951@oss.qualcomm.com> <20250225-preset_v6-v7-1-a593f3ef3951@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250225-preset_v6-v7-1-a593f3ef3951@oss.qualcomm.com> On Tue, Feb 25, 2025 at 05:15:04PM +0530, Krishna Chaitanya Chundru wrote: > Add PCIe lane equalization preset properties for 8 GT/s and 16 GT/s data > rates used in lane equalization procedure. > > Signed-off-by: Krishna Chaitanya Chundru Reviewed-by: Manivannan Sadhasivam One minor nit below. > Reviewed-by: Konrad Dybcio > --- > This patch depends on the this dt binding pull request which got recently > merged: https://github.com/devicetree-org/dt-schema/pull/146 > --- > --- > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > index 4936fa5b98ff..9a18b8f90145 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > @@ -3209,6 +3209,11 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, > phys = <&pcie3_phy>; > phy-names = "pciephy"; > > + eq-presets-8gts = /bits/ 16 <0x5555 0x5555 0x5555 0x5555 > + 0x5555 0x5555 0x5555 0x5555>; > + Get rid of the newline between eq-presets-8gts and eq-presets-16gts. - Mani -- மணிவண்ணன் சதாசிவம்