From: haibo.chen@nxp.com
To: mkl@pengutronix.de, mailhol.vincent@wanadoo.fr
Cc: haibo.chen@nxp.com, ciprianmarian.costea@oss.nxp.com,
han.xu@nxp.com, u.kleine-koenig@baylibre.com,
linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev
Subject: [PATCH 1/2] can: flexcan: only set CAN_STATE_ERROR_ACTIVE when resume has no issue
Date: Thu, 6 Mar 2025 14:59:20 +0800 [thread overview]
Message-ID: <20250306065921.2329517-1-haibo.chen@nxp.com> (raw)
From: Haibo Chen <haibo.chen@nxp.com>
Only set CAN state to CAN_STATE_ERROR_ACTIVE when resume process has
no issue, otherwise keep in CAN_STATE_SLEEPING as suspend did.
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
drivers/net/can/flexcan/flexcan-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexcan/flexcan-core.c
index b347a1c93536..8415ef71f1b1 100644
--- a/drivers/net/can/flexcan/flexcan-core.c
+++ b/drivers/net/can/flexcan/flexcan-core.c
@@ -2311,7 +2311,6 @@ static int __maybe_unused flexcan_resume(struct device *device)
struct flexcan_priv *priv = netdev_priv(dev);
int err;
- priv->can.state = CAN_STATE_ERROR_ACTIVE;
if (netif_running(dev)) {
netif_device_attach(dev);
netif_start_queue(dev);
@@ -2332,6 +2331,7 @@ static int __maybe_unused flexcan_resume(struct device *device)
flexcan_chip_interrupts_enable(dev);
}
}
+ priv->can.state = CAN_STATE_ERROR_ACTIVE;
return 0;
}
--
2.34.1
next reply other threads:[~2025-03-06 6:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 6:59 haibo.chen [this message]
2025-03-06 6:59 ` [PATCH v2 2/2] can: flexcan: disable transceiver during system PM haibo.chen
2025-03-06 7:15 ` Vincent Mailhol
2025-03-06 15:04 ` Frank Li
2025-03-06 7:15 ` [PATCH 1/2] can: flexcan: only set CAN_STATE_ERROR_ACTIVE when resume has no issue Vincent Mailhol
2025-03-06 15:03 ` Frank Li
2025-03-14 9:13 ` Marc Kleine-Budde
2025-03-14 9:42 ` Marc Kleine-Budde
2025-03-14 9:48 ` Bough Chen
2025-03-14 9:53 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306065921.2329517-1-haibo.chen@nxp.com \
--to=haibo.chen@nxp.com \
--cc=ciprianmarian.costea@oss.nxp.com \
--cc=han.xu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®