From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E187219E8; Fri, 7 Mar 2025 23:22:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741389721; cv=none; b=IDQYHZQtA0O95AjlgM5DcQ2RABcFSKXYXN2jhU1/nfQh1FFT67ncyuOK/Ph0iGYLhNfGLwk4/353y9616x3E8t/D8TkS8L5ImtcPyPDvu+DOrvhTqtdXlCzWYQ8X7pyhy4W0e4s0Y0U7zCYztOPC/4wvMQVNTIIQVFfTUAMHVv8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741389721; c=relaxed/simple; bh=Sh5CAa9QPT9G3U65/cuQbm62/4aSJbmfJVZz9dWhH9o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aJF2j6BkkK1ir6de48NjbdkNbvzmoTUVe7/sNgMkJkUllOPyqWW74anLz6HMhKQZCAtH70VXSntby6ms820YFVt4GSyMGemQ1Xk821stCkf8bLI4mSNBZiGbBkc723tlLKjReOpGCLd5mJHbe9FrYXTrQEx8pwrVfCKD51nKQ3c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PqwuO900; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PqwuO900" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D5CDC4CED1; Fri, 7 Mar 2025 23:21:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741389721; bh=Sh5CAa9QPT9G3U65/cuQbm62/4aSJbmfJVZz9dWhH9o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PqwuO900PrZBG+QQUQsPOAyTw/KygQZCo6gzXBJ9DD5Q3d8DVDjZtkiRo47MkNnct MGzLx0jHoZlOHtxc8GcNL3xbdnqQuPBYuClUNPkTdZZ7AGd5ZdKqCVwbKivJNnhBEJ 9YtWzRis1oeB65M2CMh2Gu6JQZGVArXBWChUEc6tulHScRZjTLzqXhYw42DGxB5FrR SwoGpwhSut3m4uhXJOWxFFU1zl2Rw4SyC9SYKvqkiT2tRk4LEZdttowLO6RUT9yfzY 9WNpz+BpBYa5x4WAQWcDAuhmNDbJ8SD4guztXVlPXA+fZhfTq2v94DF6Vnuo1gCCbY u91yVnpAkL3PQ== Date: Fri, 7 Mar 2025 15:21:57 -0800 From: Josh Poimboeuf To: Ingo Molnar Cc: "H. Peter Anvin" , linux-kernel@vger.kernel.org, tip-bot2 for Josh Poimboeuf , linux-tip-commits@vger.kernel.org, "Peter Zijlstra (Intel)" , Linus Torvalds , Brian Gerst , x86@kernel.org Subject: Re: [tip: x86/asm] x86/asm: Make ASM_CALL_CONSTRAINT conditional on frame pointers Message-ID: <20250307232157.comm4lycebr7zmre@jpoimboe> References: <174108458405.14745.4864877018394987266.tip-bot2@tip-bot2> <90B1074B-E7D4-4CE0-8A82-ADEB7BAED7AD@zytor.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Sat, Mar 08, 2025 at 12:05:29AM +0100, Ingo Molnar wrote: > > * H. Peter Anvin wrote: > > > > #endif /* __ASSEMBLY__ */ > > > > So we are going to be using this version despite the gcc maintainers > > telling us it is not supported? > > No, neither patches are in the x86 tree at the moment. FWIW, the existing ASM_CALL_CONSTRAINT is also not supported, so this patch wouldn't have changed anything in that respect. Regardless I plan to post a new patch set soon with a bunch of cleanups. It will keep the existing ASM_CALL_CONSTRAINT in place for GCC, and will use the new __builtin_frame_address(0) input constraint for Clang only. There will be a new asm_call() interface to hide the mess. -- Josh