From: Borislav Petkov <bp@alien8.de>
To: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, daniel.sneddon@linux.intel.com,
tony.luck@intel.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-perf-users@vger.kernel.org,
Josh Poimboeuf <jpoimboe@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Brice Goglin <brice.goglin@gmail.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Perry Yuan <Perry.Yuan@amd.com>,
Dapeng Mi <dapeng1.mi@linux.intel.com>
Subject: Re: [PATCH v7 2/4] x86/cpu: Add cpu_type to struct x86_cpu_id
Date: Sun, 9 Mar 2025 18:32:39 +0100 [thread overview]
Message-ID: <20250309173239.GCZ83Qt2uxtPvMNxVL@fat_crate.local> (raw)
In-Reply-To: <20250306-add-cpu-type-v7-2-f903fb022fd4@linux.intel.com>
On Thu, Mar 06, 2025 at 06:18:20PM -0800, Pawan Gupta wrote:
> diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
> index d67614f7b7f1..18e996acb49a 100644
> --- a/include/linux/mod_devicetable.h
> +++ b/include/linux/mod_devicetable.h
> @@ -692,6 +692,7 @@ struct x86_cpu_id {
> __u16 feature; /* bit index */
> /* Solely for kernel-internal use: DO NOT EXPORT to userspace! */
> __u16 flags;
> + __u8 cpu_type;
The struct is called "x86_cpu_id" and all its members describe a CPU. There's
no need to have more "cpu_" redundancy in the member names - just call that
"type". It is clear that it is about a CPU's type.
The macro names having "CPU" - X86_CPU_TYPE_ANY - are fine I guess.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2025-03-09 17:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 2:17 [PATCH v7 0/4] Utilize cpu-type for CPU matching Pawan Gupta
2025-03-07 2:18 ` [PATCH v7 1/4] x86/cpu: Name CPU matching macro more generically (and shorten) Pawan Gupta
2025-03-09 17:29 ` Borislav Petkov
2025-03-10 16:04 ` Pawan Gupta
2025-03-07 2:18 ` [PATCH v7 2/4] x86/cpu: Add cpu_type to struct x86_cpu_id Pawan Gupta
2025-03-09 17:32 ` Borislav Petkov [this message]
2025-03-10 16:07 ` Pawan Gupta
2025-03-07 2:18 ` [PATCH v7 3/4] x86/cpu: Update x86_match_cpu() to also use cpu-type Pawan Gupta
2025-03-10 10:48 ` Borislav Petkov
2025-03-10 16:24 ` Pawan Gupta
2025-03-07 2:18 ` [PATCH v7 4/4] x86/rfds: Exclude P-only parts from the RFDS affected list Pawan Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250309173239.GCZ83Qt2uxtPvMNxVL@fat_crate.local \
--to=bp@alien8.de \
--cc=Perry.Yuan@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=brice.goglin@gmail.com \
--cc=daniel.sneddon@linux.intel.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jpoimboe@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=rafael@kernel.org \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®