From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 904CE1CAA70 for ; Mon, 10 Mar 2025 20:00:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741636818; cv=pass; b=eiXyr3WGITnc24R4OmOBNVQj96rsAoIHvJ2fpV0FKOJeIVEgx93YUvIHYCnTThAk40v+/3hhZKVBJtbQWPoZgRRZojsdESAM39E9c/DRqYjaqxD3AHzOu/co/WPqypAUhb0DdgDw8E6ZUS5YXsz5QnNz6IB2j0z6FJ8KP4nuu84= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741636818; c=relaxed/simple; bh=GXUNsT7f5ftD/GSXHH2Vh5tGICEzsnhgaee0Q7HojP4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kaIh6p61nHy6Akj/eLSUYS92APcuL0QLEHi8QIt29r07lPO6wPFMUW+RVagZhYG1QEefeI/NjWOE0nKI4HW7SY7No2qFTlFnRGGWa+ORD2YhjER+OuvG1JUDMLGXOgsWVbm/RqYkz4k1fiJ+5b/TLCkurpVpWTlZL/7OPkRfPv8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=ariel.dalessandro@collabora.com header.b=eJbETDYH; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=ariel.dalessandro@collabora.com header.b="eJbETDYH" ARC-Seal: i=1; a=rsa-sha256; t=1741636789; cv=none; d=zohomail.com; s=zohoarc; b=mTWhI5ljOxaH+MZDEieAyDNSUiszcmKsQaV0GCeb1LuLbcokr8+lKYjtkfVgPmYvC9ngOt4G1EmnqXbVbrg2Na5nF651Ang7Rmgxxd3BMuF3oHd4j2s/IocV22Te1XjfvaSCDcTZm2ozP3fCZarMe9KAg+OgwU0M8xCPdhyUa7A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1741636789; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=XnPLtUq7gfXI+7/0APvhFGaW+4ilm1CeUoTlvhHmsDI=; b=CowNFAKRa1rulQAjGp406e5k3Ji8XogVwTmLpPw4E0cGkKvj7/9GlVP1Sm/AE/zmHVMMPjl0nQmW/icflW7iQZD8UtgR8qDwfByHjjZ8wFCxsBbYALIUTWTvs9ZAhW4CypE1baiIS8m95pXqHr5z+4qfrA5KpKTaB0A5RTTjahU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=ariel.dalessandro@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1741636789; s=zohomail; d=collabora.com; i=ariel.dalessandro@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=XnPLtUq7gfXI+7/0APvhFGaW+4ilm1CeUoTlvhHmsDI=; b=eJbETDYHzZaq0ZHObtlo93olKYwZ24KkPAakpeCc9NHqep4SkdkWi6ouJRfo9sHC WgN/SnIxyLCx0XXgHW2+ZiWwZRAIaVe8wEhu6YqMMDddyfxB/TBgqtaP9bpCE93vrsu OHRLcz40aLLG0DMuq4NTPBcOtBNIVCb50wwFGXvE= Received: by mx.zohomail.com with SMTPS id 1741636786814304.76226844373525; Mon, 10 Mar 2025 12:59:46 -0700 (PDT) From: Ariel D'Alessandro To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: boris.brezillon@collabora.com, robh@kernel.org, steven.price@arm.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, kernel@collabora.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, sjoerd@collabora.com, Ariel D'Alessandro Subject: [PATCH v1 0/6] drm/panfrost: Add support for AARCH64_4K page table format Date: Mon, 10 Mar 2025 16:59:15 -0300 Message-ID: <20250310195921.157511-1-ariel.dalessandro@collabora.com> X-Mailer: git-send-email 2.47.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Hi all, Following the previous RFC [0], this is the first iteration on Panfrost support for AARCH64_4K page table format. Currently, Panfrost only supports MMU configuration in LEGACY mode, as named by Bifrost. This is a (modified) version of LPAE "Large Physical Address Extension", which in Linux we've called ARM_MALI_LPAE. This commit adds support for conditionally enabling AARCH64_4K page table format in Panfrost, based on the newly added GPU_CONFIG_AARCH64_4K flag. This way, we can progressively move away from the legacy format once enough testing has been done on each target. The patchset only enables the new format on Mediatek MT8188, which has been tested on a Mediatek Genio 700 EVK (MT8390) board, with an integrated Mali-G57 MC3 GPU. No regressions were reported in Mesa CI [1] for the rest of the currently supported platforms. [0] https://lore.kernel.org/all/20250226183043.140773-1-ariel.dalessandro@collabora.com/ [1] https://gitlab.freedesktop.org/mesa/mesa/ Thanks! Changes in v1: * Added "Set IOMMU_CACHE flag" patch. * Replaced `panfrost_mmu->enable()` function pointer by `cfg` struct prepared during init time. * Made mali_lpae/aarch64_4k name more clear. * Added GPU_CONFIG_AARCH64_4K flag to enable AARCH64_4K page table format. * Enabled AARCH64_4K mode only on mediatek-mt8188. Ariel D'Alessandro (6): drm/panfrost: Set IOMMU_CACHE flag drm/panfrost: Use GPU_MMU_FEATURES_VA_BITS/PA_BITS macros drm/panfrost: Unify panfrost_mmu_enable/disable common code drm/panfrost: Add support for AARCH64_4K page table format drm/panfrost: Enable AARCH64_4K page table format on mediatek_mt8188 drm/panfrost: Set HW_FEATURE_AARCH64_MMU feature flag on Bifrost models drivers/gpu/drm/panfrost/panfrost_device.h | 16 ++ drivers/gpu/drm/panfrost/panfrost_drv.c | 1 + drivers/gpu/drm/panfrost/panfrost_features.h | 3 + drivers/gpu/drm/panfrost/panfrost_mmu.c | 159 ++++++++++++++++--- drivers/gpu/drm/panfrost/panfrost_regs.h | 36 +++++ 5 files changed, 189 insertions(+), 26 deletions(-) -- 2.47.2