From: Stanislav Fomichev <sdf@fomichev.me>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, linux-kernel@vger.kernel.org,
willemdebruijn.kernel@gmail.com, jasowang@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, sdf@fomichev.me,
jdamato@fastly.com, kory.maincent@bootlin.com,
atenart@kernel.org, kuniyu@amazon.com
Subject: [PATCH net-next 0/2] net: bring back dev_addr_sem
Date: Tue, 11 Mar 2025 01:45:05 -0700 [thread overview]
Message-ID: <20250311084507.3978048-1-sdf@fomichev.me> (raw)
Kohei reports an issue with dev_addr_sem conversion to netdev instance
lock in [0]. Based on the discussion, switching to netdev instance
lock to protect the address might not work for the devices that
are not using netdev ops lock.
Bring dev_addr_sem instance lock back but fix the ordering.
0: https://lore.kernel.org/netdev/20250308203835.60633-2-enjuk@amazon.com
Stanislav Fomichev (2):
Revert "net: replace dev_addr_sem with netdev instance lock"
net: reorder dev_addr_sem lock
drivers/net/tap.c | 2 +-
drivers/net/tun.c | 2 +-
include/linux/netdevice.h | 4 +++-
net/core/dev.c | 41 +++++++++++++--------------------------
net/core/dev.h | 3 ++-
net/core/dev_api.c | 19 ++++++++++++++++--
net/core/dev_ioctl.c | 2 +-
net/core/net-sysfs.c | 7 +++++--
net/core/rtnetlink.c | 17 +++++++++++-----
9 files changed, 56 insertions(+), 41 deletions(-)
--
2.48.1
next reply other threads:[~2025-03-11 8:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 8:45 Stanislav Fomichev [this message]
2025-03-11 8:45 ` [PATCH net-next 1/2] Revert "net: replace dev_addr_sem with netdev instance lock" Stanislav Fomichev
2025-03-12 2:11 ` Kuniyuki Iwashima
2025-03-11 8:45 ` [PATCH net-next 2/2] net: reorder dev_addr_sem lock Stanislav Fomichev
2025-03-12 2:27 ` Kuniyuki Iwashima
2025-03-12 8:59 ` Stanislav Fomichev
2025-03-12 13:25 ` [PATCH net-next 0/2] net: bring back dev_addr_sem Lei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250311084507.3978048-1-sdf@fomichev.me \
--to=sdf@fomichev.me \
--cc=andrew+netdev@lunn.ch \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jasowang@redhat.com \
--cc=jdamato@fastly.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®