mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: [for-next][PATCH] ring-buffer: Have parameter to virt_addr_valid() cast to pointer
Date: Tue, 11 Mar 2025 17:41:49 -0400	[thread overview]
Message-ID: <20250311174149.641b63e3@batman.local.home> (raw)


  git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git
ring-buffer/for-next

Head SHA1: 7f4decf8f94431afb7e613ac05e927d3592afe37


Steven Rostedt (1):
      ring-buffer: Have parameter to virt_addr_valid() cast to pointer

----
 kernel/trace/ring_buffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---------------------------
commit 7f4decf8f94431afb7e613ac05e927d3592afe37
Author: Steven Rostedt <rostedt@goodmis.org>
Date:   Sat Mar 8 12:36:49 2025 -0500

    ring-buffer: Have parameter to virt_addr_valid() cast to pointer
    
    Some architectures expect the parameter passed to virt_addr_valid() to be
    a pointer. Cast the unsigned long parameter to a void pointer.
    
    Cc: Masami Hiramatsu <mhiramat@kernel.org>
    Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
    Link: https://lore.kernel.org/20250308123649.1330e9ca@batman.local.home
    Reported-by: kernel test robot <lkp@intel.com>
    Closes: https://lore.kernel.org/oe-kbuild-all/202503090029.zj0DretW-lkp@intel.com/
    Fixes: 10a299da2c2b9 ("ring-buffer: Allow persistent ring buffers to be mmapped")
    Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>

diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 649724efd1be..94be81edffd2 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -7134,7 +7134,7 @@ static int __rb_map_vma(struct ring_buffer_per_cpu *cpu_buffer,
 			goto out;
 		}
 
-		if (virt_addr_valid(cpu_buffer->subbuf_ids[s]))
+		if (virt_addr_valid((void *)cpu_buffer->subbuf_ids[s]))
 			page = virt_to_page((void *)cpu_buffer->subbuf_ids[s]);
 		else
 			page = vmalloc_to_page((void *)cpu_buffer->subbuf_ids[s]);

                 reply	other threads:[~2025-03-11 21:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250311174149.641b63e3@batman.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®