From: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
To: "Bjorn Helgaas" <bhelgaas@google.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Jeff Johnson" <jjohnson@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, mhi@lists.linux.dev,
linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
quic_pyarlaga@quicinc.com, quic_vbadigan@quicinc.com,
quic_vpernami@quicinc.com, quic_mrana@quicinc.com,
Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>,
Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
Miaoqing Pan <quic_miaoqing@quicinc.com>
Subject: [PATCH v2 00/10] bus: mhi: host: Add support for mhi bus bw
Date: Thu, 13 Mar 2025 17:10:07 +0530 [thread overview]
Message-ID: <20250313-mhi_bw_up-v2-0-869ca32170bf@oss.qualcomm.com> (raw)
As per MHI spec sec 14, MHI supports bandwidth scaling to reduce power
consumption. MHI bandwidth scaling is advertised in devices that contain
the bandwidth scaling capability registers. If enabled, the device
aggregates bandwidth requirements and sends them to the host in the form
of an event. After the host performs the bandwidth switch, it sends an
acknowledgment by ringing a doorbell.
if the host supports bandwidth scaling events, then it must set
BW_CFG.ENABLED bit, set BW_CFG.DB_CHAN_ID to the channel ID to the
doorbell that will be used by the host to communicate the bandwidth
scaling status and BW_CFG.ER_INDEX to the index for the event ring
to which the device should send bandwidth scaling request in the
bandwidth scaling capability register.
As part of mmio init check if the bw scale capability is present or not,
if present advertise host supports bw scale by setting all the required
fields.
MHI layer will only forward the bw scaling request to the controller
driver, it is responsibility of the controller driver to do actual bw
scaling and then pass status to the MHI. MHI will response back to the
device based up on the status of the bw scale received.
Add a new get_misc_doorbell() to get doorbell for misc capabilities to
use the doorbell with mhi events like MHI BW scale etc.
Use workqueue & mutex for the bw scale events as the pci_set_target_speed()
which will called by the mhi controller driver can sleep.
If the driver want to move higher data rate/speed then the current data
rate/speed then the controller driver may need to change certain votes
so that link may come up in requested data rate/speed like QCOM PCIe
controllers need to change their RPMh (Resource Power Manager-hardened)
state. And also once link retraining is done controller drivers needs
to adjust their votes based on the final data rate/speed.
Some controllers also may need to update their bandwidth voting like
ICC bw votings etc.
So, add pre_scale_bus_bw() & post_scale_bus_bw() op to call before & after
the link re-train. There is no explicit locking mechanisms as these are
called by a single client endpoint driver
In case of PCIe switch, if there is a request to change target speed for a
downstream port then no need to call these function ops as these are
outside the scope of the controller drivers.
Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
---
Changes in v2:
- Update the comments.
- Split the icc bw patch as sepertate one (Bjorn)
- update the aspm disablement comment (Bjorn)
- Use FIELD_GET & FIELD_PREP instead of hard macros and couple of nits
suggested by (Ilpo Järvinen)
- Create a new function to change lnkcntrl2speed to enum pci_bus_speed (Jeff)
- Link to v1: https://lore.kernel.org/r/20250217-mhi_bw_up-v1-0-9bad1e42bdb1@oss.qualcomm.com
---
Krishna Chaitanya Chundru (8):
PCI: update current bus speed as part of pci_bus_add_devices()
PCI/bwctrl: Add support to scale bandwidth before & after link re-training
PCI: dwc: Implement .pre_scale_bus_bw() & .post_scale_bus_bw hook
PCI: qcom: Extract core logic from qcom_pcie_icc_opp_update()
PCI: qcom: Add support for PCIe bus bw scaling
bus: mhi: host: Add support for Bandwidth scale
PCI: Export pci_set_target_speed()
PCI: Add function to convert lnkctl2speed to pci_bus_speed
Miaoqing Pan (1):
wifi: ath11k: add support for MHI bandwidth scaling
Vivek Pernamitta (1):
bus: mhi: host: Add support to read MHI capabilities
drivers/bus/mhi/common.h | 20 ++++
drivers/bus/mhi/host/init.c | 93 +++++++++++++++++-
drivers/bus/mhi/host/internal.h | 7 +-
drivers/bus/mhi/host/main.c | 101 +++++++++++++++++++-
drivers/bus/mhi/host/pm.c | 10 +-
drivers/net/wireless/ath/ath11k/mhi.c | 41 ++++++++
drivers/pci/bus.c | 3 +
drivers/pci/controller/dwc/pcie-designware-host.c | 21 +++++
drivers/pci/controller/dwc/pcie-designware.h | 2 +
drivers/pci/controller/dwc/pcie-qcom.c | 110 +++++++++++++++++-----
drivers/pci/pci.c | 12 +++
drivers/pci/pcie/bwctrl.c | 16 ++++
include/linux/mhi.h | 13 +++
include/linux/pci.h | 14 +++
14 files changed, 431 insertions(+), 32 deletions(-)
---
base-commit: 80e54e84911a923c40d7bee33a34c1b4be148d7a
change-id: 20250217-mhi_bw_up-f31306a5631b
Best regards,
--
Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
next reply other threads:[~2025-03-13 11:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 11:40 Krishna Chaitanya Chundru [this message]
2025-03-13 11:40 ` [PATCH v2 01/10] PCI: update current bus speed as part of pci_bus_add_devices() Krishna Chaitanya Chundru
2025-03-13 17:00 ` Bjorn Helgaas
2025-04-25 15:46 ` Manivannan Sadhasivam
2025-03-13 17:00 ` Bjorn Helgaas
2025-03-13 11:40 ` [PATCH v2 02/10] PCI/bwctrl: Add support to scale bandwidth before & after link re-training Krishna Chaitanya Chundru
2025-04-25 15:57 ` Manivannan Sadhasivam
2025-05-16 12:49 ` Krishna Chaitanya Chundru
2025-03-13 11:40 ` [PATCH v2 03/10] PCI: dwc: Implement .pre_scale_bus_bw() & .post_scale_bus_bw hook Krishna Chaitanya Chundru
2025-04-25 16:02 ` Manivannan Sadhasivam
2025-03-13 11:40 ` [PATCH v2 04/10] PCI: qcom: Extract core logic from qcom_pcie_icc_opp_update() Krishna Chaitanya Chundru
2025-03-13 11:40 ` [PATCH v2 05/10] PCI: qcom: Add support for PCIe bus bw scaling Krishna Chaitanya Chundru
2025-04-25 16:07 ` Manivannan Sadhasivam
2025-03-13 11:40 ` [PATCH v2 06/10] bus: mhi: host: Add support to read MHI capabilities Krishna Chaitanya Chundru
2025-03-13 17:05 ` Bjorn Helgaas
2025-04-25 16:18 ` Manivannan Sadhasivam
2025-03-13 11:40 ` [PATCH v2 07/10] bus: mhi: host: Add support for Bandwidth scale Krishna Chaitanya Chundru
2025-04-25 16:43 ` Manivannan Sadhasivam
2025-05-06 4:29 ` Krishna Chaitanya Chundru
2025-05-17 2:20 ` Krishna Chaitanya Chundru
2025-03-13 11:40 ` [PATCH v2 08/10] PCI: Export pci_set_target_speed() Krishna Chaitanya Chundru
2025-03-13 11:40 ` [PATCH v2 09/10] PCI: Add function to convert lnkctl2speed to pci_bus_speed Krishna Chaitanya Chundru
2025-03-13 17:16 ` Bjorn Helgaas
2025-03-13 23:48 ` Jeff Johnson
2025-03-13 11:40 ` [PATCH v2 10/10] wifi: ath11k: add support for MHI bandwidth scaling Krishna Chaitanya Chundru
2025-03-13 17:28 ` Bjorn Helgaas
2025-03-18 5:23 ` Krishna Chaitanya Chundru
2025-03-13 23:53 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250313-mhi_bw_up-v2-0-869ca32170bf@oss.qualcomm.com \
--to=krishna.chundru@oss.qualcomm.com \
--cc=ath11k@lists.infradead.org \
--cc=bhelgaas@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=jingoohan1@gmail.com \
--cc=jjohnson@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mhi@lists.linux.dev \
--cc=quic_miaoqing@quicinc.com \
--cc=quic_mrana@quicinc.com \
--cc=quic_pyarlaga@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=quic_vpernami@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®