From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10ADD1F755B for ; Thu, 13 Mar 2025 07:59:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741852769; cv=none; b=BjJ3pCIBEhKilIuru6GGwLPx4mmkahyhorDK3rVTs2N55NXwplfRfd+wmHmZRQlTIUWbbMV/IeQ/1lbUG8cBpKgtxExRzps1Q/D+1ehAc0slKwQhbb3wFNfIttPJ+4ZTqXmt9Au33dAIyjJFISmaIBD4B52ji3yUlDno7cpDXVw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741852769; c=relaxed/simple; bh=e0npNEEjX/utUW3cZBUcJMvYNMAeFt+qoNkbCAFK+aw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FSUvhf2zqUIcswDuabN9I/IpGE9POWESLgfa1Ie7wx5TiD/PEiTqsZWmF2XVnd6hOlwj1K6t14i/shK27D4MeMMRU6nxCBG3zXgar+VG0nHNlz/36UBCGdLpa4D/Rr6M16revbcd2xKy2vyPnbFgOvcNq0qvTW3Ue4W9prNlvCA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=MUnPelFL; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=PcLhGXH5; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="MUnPelFL"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="PcLhGXH5" Date: Thu, 13 Mar 2025 08:59:24 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1741852765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OsKP8joiC/AFQkri/bU6lzIAtOi6ZEtSVz09/Tvs7uU=; b=MUnPelFLHF2+ZJUe6YgeQ7EU/mn9xiiIFm8Yb0qlTvYpect/PnhtRMCDDPjo+7Xo0oTnwq BYpbUq9u+PTrxtPUoTYSTqA+iHswg0gzrVBi70IQs0GZM6bSxzdq/cuTIe52J4KggT3OF3 ksrAkt5axY358I+NiMnvFFaCWG+P/e4TG857Wt67vqnImbPNN6+0pnamxsrd1HWihS7fzI 7sUdjx2X5rirTgAj24+nxwDix1AKWUCcFU6yJHXuZL3BtjTN3WIWdWmDCWV2191SQ9aoX/ 666MjTvh3FujRVo/KtoSw8qqsksSCopIvY/K5ut+ah9jZLYxtNqLHnbaxHymmQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1741852765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OsKP8joiC/AFQkri/bU6lzIAtOi6ZEtSVz09/Tvs7uU=; b=PcLhGXH5Fm2ECNrwOxHtfjfA9b93KJHm76F2MCNyjLR1Cxg7SK9DBRUsTIgEE/ZLT+2Ls7 aNv2gFWW1gUUe0Ag== From: Sebastian Andrzej Siewior To: Andrew Morton Cc: linux-kernel@vger.kernel.org, =?utf-8?B?QW5kcsOp?= Almeida , Darren Hart , Davidlohr Bueso , Ingo Molnar , Juri Lelli , Peter Zijlstra , Thomas Gleixner , Valentin Schneider , Waiman Long , Uladzislau Rezki , Christoph Hellwig , linux-mm@kvack.org, Christoph Hellwig Subject: Re: [PATCH v10 19/21] mm: Add vmalloc_huge_node() Message-ID: <20250313075924.qulV64zL@linutronix.de> References: <20250312151634.2183278-1-bigeasy@linutronix.de> <20250312151634.2183278-20-bigeasy@linutronix.de> <20250312150206.54afabcf993bbc55f0066886@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250312150206.54afabcf993bbc55f0066886@linux-foundation.org> On 2025-03-12 15:02:06 [-0700], Andrew Morton wrote: > On Wed, 12 Mar 2025 16:16:32 +0100 Sebastian Andrzej Siewior wrote: > > > From: Peter Zijlstra > > > > To enable node specific hash-tables. > > "... using huge pages if possible"? > > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -3966,6 +3966,13 @@ void *vmalloc_huge_noprof(unsigned long size, gfp_t gfp_mask) > > } > > EXPORT_SYMBOL_GPL(vmalloc_huge_noprof); > > > > +void *vmalloc_huge_node_noprof(unsigned long size, gfp_t gfp_mask, int node) > > +{ > > + return __vmalloc_node_range_noprof(size, 1, VMALLOC_START, VMALLOC_END, > > + gfp_mask, PAGE_KERNEL, VM_ALLOW_HUGE_VMAP, > > + node, __builtin_return_address(0)); > > +} > > + > > kerneldoc please? Okay. > > I suppose we can now simplify vmalloc_huge_noprof() to use this: > > static inline void *vmalloc_huge_noprof(unsigned long size, gfp_t gfp_mask) > { > return vmalloc_huge_node_noprof(size, gfp_mask, NUMA_NO_NODE); > } Do you want me to stash this into this one or as a follow up? Sebastian