From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAE5F1DA63D for ; Thu, 13 Mar 2025 17:44:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741887866; cv=none; b=pAwGP9LAkfnzrMg0Ax1aKeDo/hFMIqfR1cjUyhn1foB4bwp3xoTrraQn7iwU+mxuxkLwm0ZN9tKZPZkEQR3ptK1eSLszpajuNzzjWD5U7OxBU1qTIu8SkxJEsh6EA0ampWQ4mP5GsWdY+cQPBAkbmWSibDStLoDVpN18/9F+b7k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741887866; c=relaxed/simple; bh=QV8C66sQqd3HvWMDCeN2JGXKbNAkGEFguMVZSlaWutk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=miSopvbHx6SaVN72noOd6VHW65Y/ldeq7z4uiRKQJe8lDmrb/GMt680nu+gYj6nqEfBR+MmIrN6i7EoP1fTj/css46bUQfH7g6Trb0KfiDtZFuardqzbI7vXFMuN0L9XMcMrcAXCNd/lWQ6/U3fHO+KKeC1O4rsA4OsHNbrVqmg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KOhrg+Lu; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KOhrg+Lu" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2ff6ae7667dso2746581a91.0 for ; Thu, 13 Mar 2025 10:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741887864; x=1742492664; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=NhFJsw8uawrCjQJevU/7j+bAkPgtLqvzMAQJU5JD9+8=; b=KOhrg+LuXx7d9C6KKulJtOIW47AXQK03Ii3Cdb1e4XkkFTDbh7Va+0TMluG+MCqfwi l+7euXp9RUPz0YFDNLbSfFz/lPSl8QveFsz1oay9BCjynTdYEL23qLaIBrqws0OXTyMk v9GnLz34MNflm1o1A4hkwzLh3Jnyow7897BmBLFbK0yLnJWTfrFOIpVCTN8ekNwh91CB Hnf2mEXr+a4EwpJO1tO2q7uVi6xWz/V3xm1unERXYKCPWTboYEkATbQELOqu3gnIvz3k blPWgp5c8StBhUIZ1RK9yaYEMT5Uix+EYVCRWru43Guhwsslkh/Lc80wZY52jqwBs4GL OnFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741887864; x=1742492664; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NhFJsw8uawrCjQJevU/7j+bAkPgtLqvzMAQJU5JD9+8=; b=uGVsFRTWMFb4aO5vvLKKrnrnlrC3hkjruyKFaY3lCK1CLvV+D61YYnVx34LvZeYxTG 0RwCudPxPwe14AKNcaBPP4DICrA0m9v8uFXitAcCNgogdt/WWaVNEvtAWeWOEJdg5vMo tdD2scgoQ3c5tnz0KK2EwvJ8GcGVqGlYiLQEk/egHppWEH4zwRi9195Wbeo7GlXLJrtH J67nyZDG3pkUx8KcKcmEJOq43vhOUK9AOA1B0QnyDgchm81Gl/ar4Nc2Soq03NYWYuys pvAaHBonCui/UIuHHy8KsQEuSwAC/k1skHFOt8HhgI7HpyvM2fpA/tWX7QPTFBWHHltu 7h+A== X-Forwarded-Encrypted: i=1; AJvYcCXulF166qxvAjoExOQU9eC5AwMl6y4PJPzGM80KYY5p9sxFqbecwjX8CXpiEngL2T6xrX1NqJlELUiLarA=@vger.kernel.org X-Gm-Message-State: AOJu0Yyy5UllGl+BLOX5f/8K1V86fWQvE7yefMPCMjmrnXT/YrFf6d2C sJUW1TtcgenQx+GHWBaQs4ttiJo/u206TXGVL0KxiH2SV3PnKR+2vhcysEYYQGUETBHHhY1PCsc = X-Gm-Gg: ASbGnctGEXSF4gUZfUoGTDpeSMnDCpsdTgwS/5rR+hTV1O0pvu3Ax9uUNHNW1IN7EfW jEmy/113O8V2kY9jA94URgGyxoUOiA42/gbQqZTcgdhF5aXlOVHXTqBi75j7vBcrzYBa+U4BYx0 Ixhc193iOuWG1oB8qOlAx+BMUByHo0a4cltYyiplSYBhWJI8lrz5MXZcmdoafLML0cidEfXwe/9 PIbVkDrMVxIG0Zem/LosxahEv+1Pm7l/lmPOpaCe+TodjeeeoxcTx7sC/lnoDHALcCjHeVUpdCD zvHzf3vOZf71fiSpYJT2reik/GQZpiEcaAFROUZNk5GdLqNOydfofg== X-Google-Smtp-Source: AGHT+IEaq+Fi1cGt0rAKa6Fc1r8aIz7Paw4eI3nREquhMURMlKswOymRbr7ex68I++4IhbW37kjVlQ== X-Received: by 2002:a17:90b:54c4:b0:2ff:52b8:2767 with SMTP id 98e67ed59e1d1-3014e8619f7mr487146a91.19.1741887864312; Thu, 13 Mar 2025 10:44:24 -0700 (PDT) Received: from thinkpad ([120.60.60.84]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-30138b4751fsm1670259a91.12.2025.03.13.10.44.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 10:44:23 -0700 (PDT) Date: Thu, 13 Mar 2025 23:14:16 +0530 From: Manivannan Sadhasivam To: Siddharth Vadapalli Cc: lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, vigneshr@ti.com, kishon@kernel.org, cassel@kernel.org, wojciech.jasko-EXT@continental-corporation.com, thomas.richard@bootlin.com, bwawrzyn@cisco.com, linux-pci@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srk@ti.com Subject: Re: [PATCH 1/4] PCI: cadence: Add support to build pcie-cadence library as a kernel module Message-ID: <20250313174416.n3c4srf6hb2l3bvg@thinkpad> References: <20250307103128.3287497-1-s-vadapalli@ti.com> <20250307103128.3287497-2-s-vadapalli@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250307103128.3287497-2-s-vadapalli@ti.com> On Fri, Mar 07, 2025 at 04:01:25PM +0530, Siddharth Vadapalli wrote: > From: Kishon Vijay Abraham I > > Currently, the Cadence PCIe controller driver can be built as a built-in > module only. Since PCIe functionality is not a necessity for booting, add > support to build the Cadence PCIe driver as a loadable module as well. > > Signed-off-by: Kishon Vijay Abraham I > Signed-off-by: Siddharth Vadapalli Reviewed-by: Manivannan Sadhasivam > --- > drivers/pci/controller/cadence/Kconfig | 6 +++--- > drivers/pci/controller/cadence/pcie-cadence-ep.c | 6 ++++++ > drivers/pci/controller/cadence/pcie-cadence-host.c | 9 +++++++++ > drivers/pci/controller/cadence/pcie-cadence.c | 12 ++++++++++++ > drivers/pci/controller/cadence/pcie-cadence.h | 4 ++-- > 5 files changed, 32 insertions(+), 5 deletions(-) > > diff --git a/drivers/pci/controller/cadence/Kconfig b/drivers/pci/controller/cadence/Kconfig > index 8a0044bb3989..82b58096eea0 100644 > --- a/drivers/pci/controller/cadence/Kconfig > +++ b/drivers/pci/controller/cadence/Kconfig > @@ -4,16 +4,16 @@ menu "Cadence-based PCIe controllers" > depends on PCI > > config PCIE_CADENCE > - bool > + tristate > > config PCIE_CADENCE_HOST > - bool > + tristate > depends on OF > select IRQ_DOMAIN Even though this was added earlier, looks like not needed. - Mani -- மணிவண்ணன் சதாசிவம்