From: adamsimonelli@gmail.com
To: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Slaby <jirislaby@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
John Ogness <john.ogness@linutronix.de>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Petr Mladek <pmladek@suse.com>
Cc: Adam Simonelli <adamsimonelli@gmail.com>
Subject: [PATCH v10 0/1] Optionally allow ttynull to be selected as a default console
Date: Thu, 13 Mar 2025 20:41:03 -0400 [thread overview]
Message-ID: <20250314004104.3103656-1-adamsimonelli@gmail.com> (raw)
From: Adam Simonelli <adamsimonelli@gmail.com>
When switching to a CONFIG_VT=n world, at least on x86 systems,
/dev/console becomes /dev/ttyS0. This can cause some undesired effects.
/dev/console's behavior is now tied to the physical /dev/ttyS0, which when
disconnected can cause isatty() to fail when /dev/ttyS0 is disconnected,
and users who upgrade to a theoretical vt-less kernel from their
distribution who have a device such as a science instrument connected to
their /dev/ttyS0 port will suddenly see it receive kernel log messages.
When the new CONFIG_NULL_TTY_DEFAULT_CONSOLE option is turned on, this will
allow the ttynull device to be leveraged as the default console. Distributions
that had CONFIG_VT turned on before will be able to leverage this option
to where /dev/console is still backed by a pseudo device, avoiding these
issues, without needing to enable the entire VT subsystem.
v2:
rebase
v3:
Clarify commit messages.
Guard the all the register_console()s in ttynull to prevent it from being
registered twice.
Only change the link order if CONFIG_NULL_TTY_CONSOLE is enabled, otherwise
use the existing order for ttynull if only CONFIG_NULL_TTY is enabled.
Document why the link order changes in the drivers/tty/Makefile file.
Replace #ifdefs
v4:
Remember to actually include the changes to v3 in the cover letter.
v5:
Correct code formatting in Makefile comment.
v6:
Change to CONFIG_NULL_TTY_DEFAULT_CONSOLE
Set the index to -1, and don't set the flags
Use add_preferred_console() instead of register_console() in ttynull's
console_initcall when CONFIG_NULL_TTY_DEFAULT_CONSOLE is enabled
v7
Add a commit message to the first commit, and the Suggested-by
Correct Kconfig tabs/spaces formatting
Invert the console_set_on_cmdline check
v8
Update Documentation.
Remove the "CONFIG_" in the help text when mentioning other configuration
options.
Update commit message
v9
Spell pseudo correctly in the cover letter.
Use more clear, and suggested help text for NULL_TTY_DEFAULT_CONSOLE.
Do not set ttynull's index to -1 anymore.
Do not rely on link order, call add_preferred_console() in console_init().
Merge the Documentation/admin-guide/serial-console.rst change into one commit.
v10
Fix commit message to mention the option correctly. Don't mention the older
commit option from older revisions.
Adam Simonelli (1):
printk: Add an option to allow ttynull to be a default console device
Documentation/admin-guide/serial-console.rst | 4 +++-
drivers/tty/Kconfig | 19 ++++++++++++++++++-
kernel/printk/printk.c | 5 +++++
3 files changed, 26 insertions(+), 2 deletions(-)
--
2.45.2
next reply other threads:[~2025-03-14 0:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 0:41 adamsimonelli [this message]
2025-03-14 0:41 ` [PATCH v10 1/1] printk: Add an option to allow ttynull to be a default console device adamsimonelli
2025-03-14 9:44 ` Petr Mladek
2025-03-14 12:52 ` Adam Simonelli
2025-03-14 16:05 ` Adam Simonelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250314004104.3103656-1-adamsimonelli@gmail.com \
--to=adamsimonelli@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®