From: Li Huafei <lihuafei1@huawei.com>
To: <namhyung@kernel.org>, <acme@kernel.org>, <leo.yan@linux.dev>,
<james.clark@linaro.org>, <mark.rutland@arm.com>,
<john.g.garry@oracle.com>, <will@kernel.org>,
<irogers@google.com>
Cc: <mike.leach@linaro.org>, <peterz@infradead.org>,
<mingo@redhat.com>, <alexander.shishkin@linux.intel.com>,
<jolsa@kernel.org>, <kjain@linux.ibm.com>, <mhiramat@kernel.org>,
<atrajeev@linux.vnet.ibm.com>, <sesse@google.com>,
<adrian.hunter@intel.com>, <kan.liang@linux.intel.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-perf-users@vger.kernel.org>, <lihuafei1@huawei.com>
Subject: [PATCH 7/7] perf annotate-data: Handle the access to the 'current' pointer on arm64
Date: Sat, 15 Mar 2025 00:21:37 +0800 [thread overview]
Message-ID: <20250314162137.528204-8-lihuafei1@huawei.com> (raw)
In-Reply-To: <20250314162137.528204-1-lihuafei1@huawei.com>
According to the implementation of the 'current' macro on ARM64, the
sp_el0 register stores the pointer to the current task's task_struct.
For example:
mrs x1, sp_el0
ldr x2, [x1, #1896]
We can infer that the ldr instruction is accessing a member of the
task_struct structure at an offset of 1896. The key is to construct the
data type for x1. The instruction 'mrs x1, sp_el0' belongs to the inline
function get_current(). By finding the DIE of the inline function
through its instruction address, and then obtaining the DIE for its
return type, which should be 'struct task_struct *'. Then, we update the
register state of x1 with this type information.
Signed-off-by: Li Huafei <lihuafei1@huawei.com>
---
tools/perf/arch/arm64/annotate/instructions.c | 71 +++++++++++++++----
1 file changed, 57 insertions(+), 14 deletions(-)
diff --git a/tools/perf/arch/arm64/annotate/instructions.c b/tools/perf/arch/arm64/annotate/instructions.c
index f2053e7f60a8..c5a0a6381547 100644
--- a/tools/perf/arch/arm64/annotate/instructions.c
+++ b/tools/perf/arch/arm64/annotate/instructions.c
@@ -263,6 +263,20 @@ update_insn_state_arm64(struct type_state *state, struct data_loc_info *dloc,
Dwarf_Die type_die;
int sreg, dreg;
u32 insn_offset = dl->al.offset;
+ static regex_t add_regex, mrs_regex;
+ static bool regex_compiled;
+
+ if (!regex_compiled) {
+ /*
+ * Matching the operand assembly syntax of the add instruction:
+ *
+ * <Xd|SP>, <Xn|SP>, #<imm>
+ */
+ regcomp(&add_regex, "^([xw][0-9]{1,2}|sp), ([xw][0-9]{1,2}|sp), #(0x[0-9a-f]+)",
+ REG_EXTENDED);
+ regcomp(&mrs_regex, "^(x[0-9]{1,2}), sp_el0", REG_EXTENDED);
+ regex_compiled = true;
+ }
/* Access global variables via PC relative addressing, for example:
*
@@ -296,20 +310,6 @@ update_insn_state_arm64(struct type_state *state, struct data_loc_info *dloc,
regmatch_t match[4];
char *ops = strdup(dl->ops.raw);
u64 offset;
- static regex_t add_regex;
- static bool regex_compiled;
-
- /*
- * Matching the operand assembly syntax of the add instruction:
- *
- * <Xd|SP>, <Xn|SP>, #<imm>
- */
- if (!regex_compiled) {
- regcomp(&add_regex,
- "^([xw][0-9]{1,2}|sp), ([xw][0-9]{1,2}|sp), #(0x[0-9a-f]+)",
- REG_EXTENDED);
- regex_compiled = true;
- }
if (!ops)
return;
@@ -351,6 +351,49 @@ update_insn_state_arm64(struct type_state *state, struct data_loc_info *dloc,
return;
}
+ if (!strncmp(dl->ins.name, "mrs", 3)) {
+ regmatch_t match[2];
+ char *ops = strdup(dl->ops.raw);
+ Dwarf_Die func_die;
+ Dwarf_Attribute attr;
+ u64 ip = dloc->ms->sym->start + dl->al.offset;
+ u64 pc = map__rip_2objdump(dloc->ms->map, ip);
+
+ if (!ops)
+ return;
+
+ if (regexec(&mrs_regex, dl->ops.raw, 2, match, 0))
+ return;
+
+ ops[match[1].rm_eo] = '\0';
+ sreg = get_arm64_regnum(ops + match[1].rm_so);
+ if (sreg < 0 || !has_reg_type(state, sreg)) {
+ free(ops);
+ return;
+ }
+
+ /*
+ * Find the inline function 'get_current()' Dwarf_Die and
+ * obtain its return value data type, which should be
+ * 'struct task_struct *'.
+ */
+ if (!die_find_inlinefunc(cu_die, pc, &func_die) ||
+ !dwarf_attr_integrate(&func_die, DW_AT_type, &attr) ||
+ !dwarf_formref_die(&attr, &type_die)) {
+ free(ops);
+ return;
+ }
+
+ tsr = &state->regs[sreg];
+ tsr->type = type_die;
+ tsr->kind = TSR_KIND_TYPE;
+ tsr->ok = true;
+
+ pr_debug_dtp("mrs sp_el0 [%x] -> reg%d", insn_offset, sreg);
+ free(ops);
+ return;
+ }
+
if (strncmp(dl->ins.name, "ld", 2))
return;
--
2.25.1
next prev parent reply other threads:[~2025-03-14 8:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 16:21 [PATCH 0/7] Add data type profiling support for arm64 Li Huafei
2025-03-14 16:21 ` [PATCH 1/7] perf annotate: Handle arm64 load and store instructions Li Huafei
2025-03-18 1:32 ` Namhyung Kim
2025-03-18 17:15 ` Leo Yan
2025-03-14 16:21 ` [PATCH 2/7] perf annotate: Advance the mem_ref check to mov__parse() Li Huafei
2025-03-18 18:02 ` Leo Yan
2025-03-14 16:21 ` [PATCH 3/7] perf annotate: Add 'extract_reg_offset' callback function to extract register number and access offset Li Huafei
2025-03-14 16:21 ` [PATCH 4/7] perf annotate: Support for the 'extract_reg_offset' callback function in arm64 Li Huafei
2025-03-18 1:45 ` Namhyung Kim
2025-03-14 16:21 ` [PATCH 5/7] perf annotate-data: Support instruction tracking for arm64 Li Huafei
2025-03-18 1:51 ` Namhyung Kim
2025-03-14 16:21 ` [PATCH 6/7] perf annotate-data: Handle arm64 global variable access Li Huafei
2025-03-18 2:01 ` Namhyung Kim
2025-03-14 16:21 ` Li Huafei [this message]
2025-03-18 2:06 ` [PATCH 7/7] perf annotate-data: Handle the access to the 'current' pointer on arm64 Namhyung Kim
2025-03-18 1:25 ` [PATCH 0/7] Add data type profiling support for arm64 Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250314162137.528204-8-lihuafei1@huawei.com \
--to=lihuafei1@huawei.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sesse@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®